fanquake 4e1a38c6df Merge bitcoin/bitcoin#28196: BIP324 connection support ...

db9888feec net: detect wrong-network V1 talking to V2Transport (Pieter Wuille)
91e1ef8684 test: add unit tests for V2Transport (Pieter Wuille)
297c888997 net: make V2Transport preallocate receive buffer space (Pieter Wuille)
3ffa5fb49e net: make V2Transport send uniformly random number garbage bytes (Pieter Wuille)
0be752d9f8 net: add short message encoding/decoding support to V2Transport (Pieter Wuille)
8da8642062 net: make V2Transport auto-detect incoming V1 and fall back to it (Pieter Wuille)
13a7f01557 net: add V2Transport class with subset of BIP324 functionality (Pieter Wuille)
dc2d7eb810 crypto: Spanify EllSwiftPubKey constructor (Pieter Wuille)
5f4b2c6d79 net: remove unused Transport::SetReceiveVersion (Pieter Wuille)
c3fad1f29d net: add have_next_message argument to Transport::GetBytesToSend() (Pieter Wuille)

Pull request description:

  This is part of #27634.

  This implements the BIP324 v2 transport (which implements all of what the BIP calls transport layer *and* application layer), though in a non-exposed way. It is tested through an extensive fuzz test, which verifies that v2 transports can talk to v2 transports, and v1 transports can talk to v2 transports, and a unit test that exercises a number of unusual scenarios. The transport is functionally complete, including:
  * Autodetection of incoming V1 connections.
  * Garbage, both sending and receiving.
  * Short message type IDs, both sending and receiving.
  * Ignore packets (receiving only, but tested in a unit test).
  * Session IDs are visible in `getpeerinfo` output (for manual comparison).

  Things that are not included, left for future PRs, are:
  * Actually using the v2 transport for connections.
  * Support for the `NODE_P2P_V2` service flag.
  * Retrying downgrade to V1 when attempted outbound V2 connections immediately fail.
  * P2P functional and unit tests

ACKs for top commit:
  naumenkogs:
    ACK db9888feec
  theStack:
    re-ACK db9888feec
  mzumsande:
    Code Review ACK db9888feec

Tree-SHA512: 8906ac1e733a99e1f31c9111055611f706d80bbfc2edf6a07fa6e47b21bb65baacd1ff17993cbbf588063b2f5ad30b3af674a50c7bc8e8ebf4671483a21bbfeb

2023-09-08 10:24:03 +01:00

..

util

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

addition_overflow.cpp

…

addrman.cpp

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

base_encode_decode.cpp

…

bech32.cpp

…

bip324.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

bitdeque.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

block_header.cpp

…

block.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

coins_view.cpp

fuzz: coins_view: remove an incorrect assertion

2023-08-11 18:11:07 +02:00

coinscache_sim.cpp

…

connman.cpp

fuzz: use ConnmanTestMsg in connman

2023-07-22 13:42:17 -03:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector

2023-08-17 15:31:56 -04:00

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

crypto: require key on ChaCha20 initialization

2023-08-17 15:31:27 -04:00

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector

2023-08-17 15:31:56 -04:00

crypto.cpp

refactor: use Span for SipHash::Write

2023-07-17 13:27:46 +02:00

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

wallet: accurately account for the size of the witness stack

2023-08-25 12:40:12 +02:00

deserialize.cpp

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

…

fuzz.h

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

FuzzedDataProvider.h

fuzz: Bump FuzzedDataProvider.h

2023-07-17 09:39:52 +02:00

golomb_rice.cpp

refactor: use Span for SipHash::Write

2023-07-17 13:27:46 +02:00

headerssync.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

integer.cpp

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

key_io.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

key.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

Merge bitcoin/bitcoin#27746: Rework validation logic for assumeutxo

2023-07-31 16:18:20 -04:00

locale.cpp

…

merkleblock.cpp

…

message.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

mini_miner.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

miniscript.cpp

miniscript: make GetStackSize independent of P2WSH context

2023-08-25 11:56:09 +02:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

Use serialization parameters for CAddress serialization

2023-09-05 10:13:25 +02:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

p2p_transport_serialization.cpp

net: make V2Transport send uniformly random number garbage bytes

2023-09-07 09:04:55 -04:00

parse_hd_keypath.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

refactor: Revert addition of univalue sighash string check

2023-07-27 09:36:05 +02:00

partially_downloaded_block.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

policy_estimator_io.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

policy_estimator.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

poolresource.cpp

…

pow.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager

2023-08-18 12:52:30 -04:00

process_messages.cpp

net: move message conversion to wire bytes from PushMessage to SocketSendData

2023-08-23 20:13:49 -04:00

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

rolling_bloom_filter.cpp

…

rpc.cpp

fuzz: introduce and use ConsumePrivateKey helper

2023-09-06 13:59:12 +02:00

script_assets_test_minimizer.cpp

…

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

script_sign.cpp

Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization

2023-09-07 11:34:34 +01:00

script.cpp

Rename script/standard.{cpp/h} to script/solver.{cpp/h}

2023-08-14 17:39:49 -04:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

socks5.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

span.cpp

…

spanparsing.cpp

…

string.cpp

…

strprintf.cpp

…

system.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

timedata.cpp

…

torcontrol.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

transaction.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

txorphan.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

txrequest.cpp

…

util.cpp

Merge bitcoin/bitcoin#28361: fuzz: add ConstructPubKeyBytes util function

2023-09-07 16:22:16 +01:00

util.h

Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization

2023-09-07 11:34:34 +01:00

utxo_snapshot.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00

utxo_total_supply.cpp

…

validation_load_mempool.cpp

refactor: Add and use kernel::ImportMempoolOptions

2023-08-07 11:32:34 +02:00

versionbits.cpp

scripted-diff: Use new FUZZ_TARGET macro everywhere

2023-07-13 20:37:14 +02:00