highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
538fedde1d9c96a2bbe06cacc0cd6903135fbc83
bitcoin/src/node
History
Ava Chow 8efd03ad04 Merge bitcoin/bitcoin#29494: build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes 
fa09451f8e Add lint check for bitcoin-config.h include IWYU pragma (MarcoFalke)
dddd40ba82 scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes (MarcoFalke)

Pull request description:

  The `bitcoin-config.h` includes have issues:

  * The header is incompatible with iwyu, because symbols may be defined or not defined. So the `IWYU pragma: keep` is needed to keep the include when a symbol is not defined on a platform. Compare the previous discussion in https://github.com/bitcoin/bitcoin/pull/29408#issuecomment-1948959711
  * Guarding the includes by `HAVE_CONFIG_H` is verbose and brittle. Now that all build config dependencies have been removed from low level headers, the benefits are questionable, and the guard can be removed. The linter could also be tricked by guarding the include by `#if defined(HAVE_C0NFIG_H)` (`O` replaced by `0`). Compare the previous discussion in https://github.com/bitcoin/bitcoin/pull/29404#discussion_r1483189853 .

ACKs for top commit:
  achow101:
    ACK fa09451f8e
  TheCharlatan:
    ACK fa09451f8e
  hebasto:
    re-ACK fa09451f8e, only rebased since my recent [review](https://github.com/bitcoin/bitcoin/pull/29494#pullrequestreview-2028864535) (`timedata.cpp` removed in https://github.com/bitcoin/bitcoin/pull/29623).

Tree-SHA512: 47cb973f7f24bc625acc4e78683371863675d186780236d55d886cf4130e05a78bb04f1d731aae7088313b8e963a9677cc77cf518187dbd99d776f6421ca9b52
2024-05-07 14:14:03 -04:00
..
abort.cpp
node: Make translations of fatal errors consistent
2024-03-21 16:40:22 +01:00
abort.h
node: Make translations of fatal errors consistent
2024-03-21 16:40:22 +01:00
blockmanager_args.cpp
refactor: Move stopafterblockimport handling out of blockstorage
2023-07-11 12:00:57 +02:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
node: Make translations of fatal errors consistent
2024-03-21 16:40:22 +01:00
blockstorage.h
refactor: Use reference instead of pointer in IsBlockPruned
2023-12-07 12:02:54 +01:00
caches.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
caches.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
chainstate.cpp
refactor: Remove call to ShutdownRequested from chainstate init
2023-12-04 15:39:15 -04:00
chainstate.h
refactor: Remove call to ShutdownRequested from chainstate init
2023-12-04 15:39:15 -04:00
chainstatemanager_args.cpp
refactor: Move {MAX,DEFAULT}_SCRIPTCHECK_THREADS constants
2023-10-03 10:52:17 +01:00
chainstatemanager_args.h
refactor: Move {MAX,DEFAULT}_SCRIPTCHECK_THREADS constants
2023-10-03 10:52:17 +01:00
coin.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
coin.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
refactor, txdb: Add CoinsViewOptions struct
2023-02-10 04:39:11 -04:00
connection_types.cpp
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
connection_types.h
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
context.cpp
kernel: Add notification interface
2023-05-20 12:03:22 +02:00
context.h
scripted-diff: Rename MainSignals to ValidationSignals
2024-02-15 14:45:51 +01:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
refactor, dbwrapper: Add DBParams and DBOptions structs
2023-02-10 04:39:11 -04:00
eviction.cpp
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
eviction.h
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
interface_ui.cpp
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interface_ui.h
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interfaces.cpp
Merge bitcoin/bitcoin#29494: build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes
2024-05-07 14:14:03 -04:00
kernel_notifications.cpp
scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes
2024-05-01 08:33:04 +02:00
kernel_notifications.h
node: Make translations of fatal errors consistent
2024-03-21 16:40:22 +01:00
mempool_args.cpp
mempool: persist with XOR
2023-11-09 19:44:50 +01:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
miner.cpp
refactor: Fix timedata includes
2024-02-01 13:52:05 +01:00
miner.h
[refactor] rewrite BlockAssembler inBlock and failedTx as sets of txids
2023-11-10 16:44:45 +01:00
mini_miner.cpp
[refactor] Miniminer var cached_descendants to descendants
2023-11-07 08:56:43 -06:00
mini_miner.h
[refactor] updating miniminer comments to be more accurate
2023-11-08 14:45:18 -06:00
minisketchwrapper.cpp
Use steady clock in SeedStrengthen and FindBestImplementation
2023-03-02 14:48:28 +01:00
minisketchwrapper.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
peerman_args.cpp
Merge bitcoin/bitcoin#28149: net processing: clamp PeerManager::Options user input
2023-08-09 14:26:03 +02:00
peerman_args.h
[net processing] Introduce PeerManager options
2023-07-24 18:30:59 +02:00
protocol_version.h
Rename version.h to node/protocol_version.h
2023-11-30 11:28:31 +01:00
psbt.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
psbt.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
README.md
doc: Remove irrelevant link to GitHub
2021-04-06 09:34:21 +02:00
timeoffsets.cpp
Add TimeOffsets helper class
2024-04-10 17:01:27 +02:00
timeoffsets.h
Add TimeOffsets helper class
2024-04-10 17:01:27 +02:00
transaction.cpp
refactor: De-globalize g_signals
2024-02-15 14:37:01 +01:00
transaction.h
RPC: Add maxfeerate and maxburnamount args to submitpackage
2024-03-13 09:45:43 -04:00
txreconciliation.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
utxo_snapshot.cpp
lint: remove /* Continued */ markers from codebase
2023-08-03 17:52:24 +01:00
utxo_snapshot.h
refactor: Remove unused nchaintx from SnapshotMetadata constructor
2023-10-12 11:14:32 +02:00
validation_cache_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
validation_cache_args.h
validationcaches: Add and use ValidationCacheSizes
2022-08-03 12:03:27 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.

Reference in New Issue View Git Blame Copy Permalink