highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 15:19:07 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
53b72372da91c5e90df865bc15961e16feb4a983
bitcoin/src/node
History
merge-script 48d4b936e0 Merge bitcoin/bitcoin#33511: init: Fix Ctrl-C shutdown hangs during wait calls 
c25a5e670b init: Signal m_tip_block_cv on Ctrl-C (Ryan Ofsky)
6a29f79006 test: Test SIGTERM handling during waitforblockheight call (Ryan Ofsky)

Pull request description:

  Signal `m_tip_block_cv` when Ctrl-C is pressed or `SIGTERM` is received, the same way it is currently signaled when the `stop` RPC is called. This lets RPC calls like `waitforblockheight` and IPC calls like `waitTipChanged` be interrupted, instead of waiting for their original timeouts and delaying shutdown.

  This issue was reported by plebhash in #33463. These hangs have been present since #30409. A similar bug was also fixed previously in Qt in #18452 and this PR simplifies that fix.

ACKs for top commit:
  Sjors:
    tACK c25a5e670b
  TheCharlatan:
    ACK c25a5e670b
  enirox001:
    Concept ACK c25a5e6

Tree-SHA512: 320aaa74fd308e826521c48c9a8aca4bd5f5530064cda2303d251d8e93e50c474bcd0db760ce04921928e73abefe4847aff797ac9ca7c89e74e5051bbed061cd
2025-11-12 10:16:29 -05:00
..
abort.cpp
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
abort.h
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
blockmanager_args.cpp
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
Merge bitcoin/bitcoin#33724: refactor: Return uint64_t from GetSerializeSize
2025-11-12 09:48:10 -05:00
blockstorage.h
Merge bitcoin/bitcoin#33724: refactor: Return uint64_t from GetSerializeSize
2025-11-12 09:48:10 -05:00
caches.cpp
coins: warn on oversized -dbcache
2025-09-17 11:36:21 -07:00
caches.h
coins: warn on oversized -dbcache
2025-09-17 11:36:21 -07:00
chainstate.cpp
log: [refactor] Use info level for init logs
2025-07-25 09:50:50 +02:00
chainstate.h
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
chainstatemanager_args.cpp
Remove checkpoints
2025-03-13 11:13:13 +00:00
chainstatemanager_args.h
refactor: Clamp worker threads in ChainstateManager constructor
2024-11-18 11:13:20 +01:00
coin.cpp
refactor: Rely on returned value of GetCoin instead of parameter
2024-09-18 20:03:47 +02:00
coin.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
refactor, txdb: Add CoinsViewOptions struct
2023-02-10 04:39:11 -04:00
connection_types.cpp
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
connection_types.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
context.cpp
fees: refactor: rename fees to block_policy_estimator
2025-10-27 10:41:02 +01:00
context.h
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
refactor, dbwrapper: Add DBParams and DBOptions structs
2023-02-10 04:39:11 -04:00
eviction.cpp
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
eviction.h
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
interface_ui.cpp
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
interface_ui.h
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
interfaces.cpp
Merge bitcoin/bitcoin#33511: init: Fix Ctrl-C shutdown hangs during wait calls
2025-11-12 10:16:29 -05:00
kernel_notifications.cpp
kernel: make blockTip index const
2025-09-05 15:46:44 +01:00
kernel_notifications.h
kernel: make blockTip index const
2025-09-05 15:46:44 +01:00
mempool_args.cpp
[doc] assert that default min relay feerate and incremental are the same
2025-08-11 16:58:26 -04:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
mempool_persist.cpp
mempool, refactor: Convert uint256 to Txid
2025-08-11 16:26:35 +01:00
mempool_persist.h
mempool: move LoadMempool/DumpMempool to node
2024-06-26 22:47:09 +00:00
miner.cpp
Merge bitcoin/bitcoin#33745: mining: check witness commitment in submitBlock
2025-11-12 10:03:48 -05:00
miner.h
interfaces: add interruptWait method
2025-10-27 19:22:12 +01:00
mini_miner.cpp
refactor: Convert mini_miner from uint256 to Txid
2025-08-11 16:12:42 +01:00
mini_miner.h
refactor: Convert mini_miner from uint256 to Txid
2025-08-11 16:12:42 +01:00
minisketchwrapper.cpp
log: [refactor] Use info level for init logs
2025-07-25 09:50:50 +02:00
minisketchwrapper.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
peerman_args.cpp
[prep/config] remove -maxorphantx
2025-07-14 16:13:10 -04:00
peerman_args.h
doc: add & amend copyright headers
2025-05-20 09:43:21 +01:00
protocol_version.h
Rename version.h to node/protocol_version.h
2023-11-30 11:28:31 +01:00
psbt.cpp
psbt: Check sighash types in SignPSBTInput and take sighash as optional
2025-05-14 14:00:43 -07:00
psbt.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
README.md
…
timeoffsets.cpp
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00
timeoffsets.h
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00
transaction.cpp
Merge bitcoin/bitcoin#33567: node: change a tx-relay on/off flag to enum
2025-10-31 14:59:58 -04:00
transaction.h
Merge bitcoin/bitcoin#33567: node: change a tx-relay on/off flag to enum
2025-10-31 14:59:58 -04:00
txdownloadman_impl.cpp
refactor: Convert remaining instances from uint256 to Txid
2025-08-11 16:47:43 +01:00
txdownloadman_impl.h
scripted-diff: rename OrphanTxBase to OrphanInfo
2025-08-01 11:52:32 -04:00
txdownloadman.h
scripted-diff: rename OrphanTxBase to OrphanInfo
2025-08-01 11:52:32 -04:00
txorphanage.cpp
Merge bitcoin/bitcoin#32941: p2p: TxOrphanage revamp cleanups
2025-08-04 16:47:54 +01:00
txorphanage.h
scripted-diff: rename "ann" variables to "latency_score"
2025-08-01 11:52:32 -04:00
txreconciliation.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
types.h
node: change a tx-relay on/off flag to enum
2025-10-15 08:52:48 +02:00
utxo_snapshot.cpp
streams: remove unused code
2024-09-19 07:33:02 -04:00
utxo_snapshot.h
assumeutxo: Drop block height from metadata
2024-08-08 23:55:06 +02:00
warnings.cpp
scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
2024-10-10 12:22:12 +02:00
warnings.h
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.

Reference in New Issue View Git Blame Copy Permalink