highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 07:09:15 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
541976b42ebd980b627b65575b8cafc06bd731d0
bitcoin/src
History
Andrew Chow 541976b42e Merge bitcoin/bitcoin#27850: test: Add unit & functional test coverage for blockstore 
de8f9123af test: cover read-only blockstore (Matthew Zipkin)
5c2185b3b6 ci: enable chattr +i capability inside containers (Matthew Zipkin)
e573f24202 unit test: add coverage for BlockManager (Matthew Zipkin)

Pull request description:

  This PR adds unit and functional tests to cover the behavior described in #2039. In particular, that bitcoind will crash on startup if a reindex is requested but the `blk` files are read-only. Eventually this behavior can be updated with https://github.com/bitcoin/bitcoin/pull/27039. This PR just commits the test coverage from #27039 as suggested in https://github.com/bitcoin/bitcoin/pull/27039#issuecomment-1584915782

ACKs for top commit:
  jonatack:
    ACK de8f9123af modulo suggestions in https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1319010039, tested on macOS, but not on Linux for the Linux-related change in the last push
  achow101:
    ACK de8f9123af
  MarcoFalke:
    lgtm ACK de8f9123af 📶

Tree-SHA512: b9bd684035dcea11c901b649fc39f397a2155a9a8459f3348e67947e387e45312fddeccb52981aef486f8a31deebb5356a7901c1bb94b78f82c24192a369af73
2023-09-14 13:21:14 -04:00
..
bench
Merge bitcoin/bitcoin#28423: kernel: Remove protocol.h/netaddress.h/compat.h from kernel headers
2023-09-14 11:11:38 +01:00
common
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
compat
Sort includes in compat.h
2023-08-08 17:50:41 +02:00
config
…
consensus
consensus/validation.h: remove needless GetTransactionOutputWeight helper
2023-09-08 11:16:06 +02:00
crc32c
Update crc32c subtree to latest upstream master
2022-08-13 13:55:38 +01:00
crypto
crypto: make ChaCha20::SetKey wipe buffer
2023-08-17 15:37:41 -04:00
index
Remove unused GetType() from CBufferedFile and CAutoFile
2023-09-12 12:35:13 +02:00
init
init: remove config option names from translated -loglevel strings
2023-06-15 10:27:56 -06:00
interfaces
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
ipc
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
kernel
Merge bitcoin/bitcoin#28423: kernel: Remove protocol.h/netaddress.h/compat.h from kernel headers
2023-09-14 11:11:38 +01:00
leveldb
Update leveldb-subtree subtree to latest upstream
2022-09-29 16:43:30 +01:00
logging
Use steady clock for logging timer
2023-01-31 18:48:50 +01:00
minisketch
Update minisketch subtree to latest upstream
2022-10-23 15:03:04 +01:00
node
Merge bitcoin/bitcoin#28423: kernel: Remove protocol.h/netaddress.h/compat.h from kernel headers
2023-09-14 11:11:38 +01:00
policy
Merge bitcoin/bitcoin#28251: validation: fix coins disappearing mid-package evaluation
2023-09-13 17:51:00 +01:00
primitives
Remove version/hashing options from CBlockLocator/CDiskBlockIndex
2023-09-08 13:40:15 +00:00
qt
qt: Update translation source file
2023-09-01 08:08:36 +01:00
rpc
Merge bitcoin/bitcoin#28291: rpc: removed StrFormatInternalBug quote delimitation
2023-09-05 11:41:02 +03:00
script
Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization
2023-09-07 11:34:34 +01:00
secp256k1
Update secp256k1 subtree to upstream release 0.4.0
2023-09-04 12:51:20 -04:00
support
Don't derive secure_allocator from std::allocator
2023-07-24 22:33:40 -07:00
test
Merge bitcoin/bitcoin#27850: test: Add unit & functional test coverage for blockstore
2023-09-14 13:21:14 -04:00
univalue
Remove unused raw-pointer read helper from univalue
2023-07-27 14:24:52 +02:00
util
[refactor] Remove compat.h from kernel headers
2023-09-12 22:51:48 +02:00
wallet
[refactor] Define MessageStartChars as std::array
2023-09-12 22:49:49 +02:00
zmq
p2p, refactor: return std::optional<CNetAddr> in LookupHost
2023-05-26 13:41:07 -03:00
.bear-tidy-config
ci: filter all subtrees from tidy output
2023-06-29 11:59:31 +01:00
.clang-format
…
.clang-tidy
refactor: Enable all clang-tidy plugin bitcoin tests
2023-08-16 14:48:06 +02:00
addrdb.cpp
kernel: Move MessageStartChars to its own file
2023-09-12 22:51:38 +02:00
addrdb.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addresstype.cpp
Refactor: Remove confusing static_cast
2023-08-17 15:55:07 +02:00
addresstype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
addrman_impl.h
Replace READWRITEAS macro with AsBase wrapping function
2023-08-28 17:48:15 +02:00
addrman.cpp
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addrman.h
doc: update Select function description
2023-05-24 12:03:18 -07:00
arith_uint256.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
arith_uint256.h
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
attributes.h
Introduce platform-agnostic ALWAYS_INLINE macro
2023-05-04 20:57:51 +01:00
banman.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
banman.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
base58.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
base58.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
bech32.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
bech32.h
…
bip324.cpp
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bip324.h
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bitcoin-chainstate.cpp
[refactor] Add missing includes for next commit
2023-09-12 22:51:42 +02:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
[refactor] Add missing includes for next commit
2023-09-12 22:51:42 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
blockencodings.cpp
refactor: Fix logging.h includes
2023-08-05 10:42:56 +02:00
blockencodings.h
script: remove out-of-date snprintf TODO
2023-02-15 14:42:28 -08:00
blockfilter.cpp
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
blockfilter.h
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
chain.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
chain.h
Remove version/hashing options from CBlockLocator/CDiskBlockIndex
2023-09-08 13:40:15 +00:00
chainparams.cpp
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparams.h
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparamsbase.cpp
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsbase.h
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsseeds.h
p2p: update hardcoded mainnet seeds for 25.x
2023-04-20 06:08:22 -07:00
checkqueue.h
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
clientversion.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
clientversion.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins.cpp
Use PoolAllocator for CCoinsMap
2023-03-23 19:38:38 +01:00
coins.h
Use PoolAllocator for CCoinsMap
2023-03-23 19:38:38 +01:00
compressor.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
compressor.h
…
core_io.h
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
core_memusage.h
…
core_read.cpp
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
core_write.cpp
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
cuckoocache.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
dbwrapper.cpp
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
dbwrapper.h
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
deploymentinfo.cpp
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentinfo.h
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentstatus.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
deploymentstatus.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
dummywallet.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
external_signer.cpp
Fix clang-tidy performance-unnecessary-copy-initialization warnings
2023-05-09 18:48:52 +02:00
external_signer.h
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
flatfile.cpp
refactor: Extract util/fs_helpers from util/system
2023-03-23 12:52:00 +01:00
flatfile.h
Merge bitcoin/bitcoin#27254: refactor: Extract util/fs from util/system
2023-04-03 14:41:22 +01:00
hash.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
hash.h
Remove unused legacy CHashVerifier
2023-09-05 10:13:50 +02:00
headerssync.cpp
[headerssync] Make m_commit_offset protected
2022-12-12 21:06:04 +00:00
headerssync.h
[headerssync] Make m_commit_offset protected
2022-12-12 21:06:04 +00:00
httprpc.cpp
scripted-diff: Use UniValue::find_value method
2023-05-09 18:47:14 +02:00
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#27949: http: update libevent workaround to correct version
2023-06-28 12:20:25 +01:00
httpserver.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
i2p.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
i2p.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
indirectmap.h
…
init.cpp
[refactor] Add CChainParams member to CConnman
2023-09-12 22:51:45 +02:00
init.h
refactor: index, decouple 'Init' from 'Start'
2023-07-10 10:47:17 -03:00
key_io.cpp
[refactor] Add missing includes for next commit
2023-09-12 22:51:42 +02:00
key_io.h
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
key.cpp
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
key.h
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
logging.cpp
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
logging.h
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
Makefile.am
kernel: Move MessageStartChars to its own file
2023-09-12 22:51:38 +02:00
Makefile.bench.include
Merge bitcoin/bitcoin#28008: BIP324 ciphersuite
2023-08-10 11:58:59 +02:00
Makefile.crc32c.include
build: Create .la library for crc32c
2022-04-26 16:25:38 -04:00
Makefile.leveldb.include
Use more specific path when including memenv.h header
2022-06-23 15:33:01 +02:00
Makefile.minisketch.include
build: Build minisketch test in make check, not in make
2022-07-21 10:42:09 +01:00
Makefile.qt_locale.include
qt: Translation updates from Transifex
2023-09-01 07:39:00 +01:00
Makefile.qt.include
Build: Log when test -f fails in Makefile
2023-02-03 22:33:14 +01:00
Makefile.qttest.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.test_fuzz.include
[fuzz] Move ConsumeNetAddr to fuzz/util/net.h
2022-11-17 14:52:45 +00:00
Makefile.test_util.include
Merge bitcoin/bitcoin#27425: test: move remaining rand code from util/setup_common to util/random
2023-07-19 10:26:11 +01:00
Makefile.test.include
Merge bitcoin/bitcoin#28008: BIP324 ciphersuite
2023-08-10 11:58:59 +02:00
Makefile.univalue.include
…
mapport.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
mapport.h
Remove configure-time setting of DEFAULT_UPNP
2023-01-28 15:24:13 +00:00
memusage.h
Calculate memory usage correctly for unordered_maps that use PoolAllocator
2023-03-23 19:38:38 +01:00
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost
2023-05-30 11:39:59 -04:00
net_permissions.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
net_processing.cpp
Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization
2023-09-07 11:34:34 +01:00
net_processing.h
net processing: clamp -blockreconstructionextratxn to uint32_t bounds
2023-07-25 21:51:20 +01:00
net_types.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
net_types.h
…
net.cpp
[refactor] Remove netaddress.h from kernel headers
2023-09-12 22:51:46 +02:00
net.h
[refactor] Remove netaddress.h from kernel headers
2023-09-12 22:51:46 +02:00
netaddress.cpp
net, refactor: pass reference for peer address in GetReachabilityFrom
2023-06-05 11:02:47 -04:00
netaddress.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
netbase.cpp
Remove now-unnecessary poll, fcntl includes from net(base).cpp
2023-06-28 16:35:45 -05:00
netbase.h
p2p, refactor: return std::optional<CNetAddr> in LookupHost
2023-05-26 13:41:07 -03:00
netgroup.cpp
refactor: Use HashWriter over legacy CHashWriter (via SerializeHash)
2023-08-25 17:09:32 +02:00
netgroup.h
[netgroupman] Remove NetGroupManager::GetAsmap()
2022-04-20 14:35:53 +01:00
netmessagemaker.h
…
noui.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
noui.h
…
outputtype.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
outputtype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
pow.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
pow.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
prevector.h
util: implement prevector's move ctor & move assignment
2023-03-26 15:49:52 +02:00
protocol.cpp
[refactor] Define MessageStartChars as std::array
2023-09-12 22:49:49 +02:00
protocol.h
kernel: Move MessageStartChars to its own file
2023-09-12 22:51:38 +02:00
psbt.cpp
Move Taproot{SpendData/Builder} to signingprovider.{h/cpp}
2023-08-14 17:38:27 -04:00
psbt.h
Merge bitcoin/bitcoin#25939: rpc: In utxoupdatepsbt also look for the tx in the txindex
2023-04-21 14:06:12 -04:00
pubkey.cpp
crypto: Spanify EllSwiftPubKey constructor
2023-09-07 08:53:45 -04:00
pubkey.h
crypto: Spanify EllSwiftPubKey constructor
2023-09-07 08:53:45 -04:00
random.cpp
[refactor] Remove compat.h from kernel headers
2023-09-12 22:51:48 +02:00
random.h
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
randomenv.cpp
[refactor] Remove compat.h from kernel headers
2023-09-12 22:51:48 +02:00
randomenv.h
…
rest.cpp
rest: bugfix, fix crash error when calling /deploymentinfo
2023-06-12 10:24:14 -03:00
rest.h
Handle query string when parsing data format
2022-03-10 12:01:53 +01:00
reverse_iterator.h
doc: remove usages of C++11
2023-01-12 13:42:44 +00:00
scheduler.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
scheduler.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
serialize.h
[refactor] Allow std::array<std::byte, N> in serialize.h
2023-09-12 22:44:28 +02:00
shutdown.cpp
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
shutdown.h
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
signet.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
signet.h
…
span.h
refactor: Use reinterpret_cast where appropriate
2023-07-24 15:32:35 +02:00
streams.cpp
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
streams.h
scripted-diff: Rename CBufferedFile to BufferedFile
2023-09-12 12:55:29 +02:00
sync.cpp
…
sync.h
doc: Export threadsafety.h from sync.h
2023-01-25 09:33:26 +01:00
threadsafety.h
…
timedata.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
timedata.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
tinyformat.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
torcontrol.cpp
doc, refactor: Changing -torcontrol help to specify that a default port is used
2023-08-17 23:58:47 -05:00
torcontrol.h
doc, refactor: Changing -torcontrol help to specify that a default port is used
2023-08-17 23:58:47 -05:00
txdb.cpp
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
txdb.h
move-only: Move CBlockTreeDB to node/blockstorage
2023-08-01 15:27:33 +02:00
txmempool.cpp
Merge bitcoin/bitcoin#28251: validation: fix coins disappearing mid-package evaluation
2023-09-13 17:51:00 +01:00
txmempool.h
Merge bitcoin/bitcoin#28251: validation: fix coins disappearing mid-package evaluation
2023-09-13 17:51:00 +01:00
txorphanage.cpp
[log] add more logs related to orphan handling
2023-08-29 16:41:22 +01:00
txorphanage.h
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
txrequest.cpp
refactor: use Span for SipHash::Write
2023-07-17 13:27:46 +02:00
txrequest.h
…
uint256.cpp
refactor: modernize the implementation of uint256.*
2022-12-10 14:34:44 -06:00
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#28423: kernel: Remove protocol.h/netaddress.h/compat.h from kernel headers
2023-09-14 11:11:38 +01:00
validation.h
Merge bitcoin/bitcoin#28251: validation: fix coins disappearing mid-package evaluation
2023-09-13 17:51:00 +01:00
validationinterface.cpp
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
validationinterface.h
refactor: add kernel/cs_main.*
2023-01-05 09:05:14 +00:00
version.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
versionbits.cpp
refactor: use braced init for integer constants instead of c style casts
2023-01-03 19:31:29 -06:00
versionbits.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
walletinitinterface.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
warnings.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
warnings.h
…