mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-05 18:23:03 +01:00

Files

Ava Chow 1a8f51e745 Merge bitcoin/bitcoin#28843 : [refactor] Cleanup BlockAssembler mempool usage

192dac1d33 [refactor] Cleanup BlockAssembler mempool usage (TheCharlatan)

Pull request description:

  The `addPackageTxs` method of the `BlockAssembler` currently has access to two mempool variables, as an argument and as a member. Clean this up and clarify that they both are the same mempool instance by removing the argument and instead only using the member variable in the method.

  This was noticed in this PR review: https://github.com/bitcoin/bitcoin/pull/25223#discussion_r898164322.

ACKs for top commit:
  achow101:
    ACK 192dac1d33
  danielabrozzoni:
    re-ACK 192dac1
  stickies-v:
    ACK 192dac1d33

Tree-SHA512: a5ae7d6d771fbb5b54f23624b4d3429acf07bbe38179a462a078c825d60c89a725ad4e13fe7067eebea7dfec63c56c8f39b5077b0d949d594f500affcc1272d1

2024-11-14 16:30:48 -05:00

abort.cpp

refactor: Split up NodeContext shutdown_signal and shutdown_request

2024-10-01 09:10:54 +02:00

abort.h

refactor: Split up NodeContext shutdown_signal and shutdown_request

2024-10-01 09:10:54 +02:00

blockmanager_args.cpp

Add -blocksxor boolean option

2024-07-26 17:30:53 +02:00

blockmanager_args.h

…

blockstorage.cpp

streams: remove unused code

2024-09-19 07:33:02 -04:00

blockstorage.h

validation: Use span for ImportBlocks paths

2024-08-30 12:39:46 +02:00

caches.cpp

…

caches.h

…

chainstate.cpp

Merge bitcoin/bitcoin#31064 : init: Correct coins db cache size setting

2024-10-29 15:12:41 -04:00

chainstate.h

…

chainstatemanager_args.cpp

node: use uint256::FromUserHex for -assumevalid parsing

2024-08-23 13:53:40 +01:00

chainstatemanager_args.h

…

coin.cpp

refactor: Rely on returned value of GetCoin instead of parameter

2024-09-18 20:03:47 +02:00

coin.h

…

coins_view_args.cpp

…

coins_view_args.h

…

connection_types.cpp

…

connection_types.h

…

context.cpp

Introduce Mining interface

2024-06-18 18:47:51 +02:00

context.h

refactor: Split up NodeContext shutdown_signal and shutdown_request

2024-10-01 09:10:54 +02:00

database_args.cpp

…

database_args.h

…

eviction.cpp

…

eviction.h

…

interface_ui.cpp

…

interface_ui.h

add missing #include <cstdint> for GCC 15

2024-08-12 11:15:11 +01:00

interfaces.cpp

Merge bitcoin/bitcoin#31130 : Drop miniupnp dependency

2024-10-28 10:47:34 +00:00

kernel_notifications.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

kernel_notifications.h

refactor: Use wait_for predicate to check for interrupt

2024-10-01 09:11:08 +02:00

mempool_args.cpp

Remove -mempoolfullrbf option

2024-10-28 11:53:20 -04:00

mempool_args.h

…

mempool_persist_args.cpp

…

mempool_persist_args.h

…

mempool_persist.cpp

streams: remove AutoFile::Get() entirely

2024-09-13 21:59:29 -04:00

mempool_persist.h

mempool: move LoadMempool/DumpMempool to node

2024-06-26 22:47:09 +00:00

miner.cpp

Merge bitcoin/bitcoin#28843 : [refactor] Cleanup BlockAssembler mempool usage

2024-11-14 16:30:48 -05:00

miner.h

[refactor] Cleanup BlockAssembler mempool usage

2024-10-21 15:55:35 +02:00

mini_miner.cpp

MiniMiner: use FeeFrac in AncestorFeerateComparator

2024-07-09 17:22:51 +01:00

mini_miner.h

Don't use iterator addresses in IteratorComparator

2024-06-19 10:14:31 +01:00

minisketchwrapper.cpp

…

minisketchwrapper.h

…

peerman_args.cpp

…

peerman_args.h

…

protocol_version.h

…

psbt.cpp

…

psbt.h

…

README.md

…

timeoffsets.cpp

refactor: remove warnings globals

2024-06-13 11:20:49 +01:00

timeoffsets.h

refactor: remove warnings globals

2024-06-13 11:20:49 +01:00

transaction.cpp

rpc: clarify ALREADY_IN_CHAIN rpc errors

2024-08-05 15:45:58 +01:00

transaction.h

…

txdownloadman_impl.cpp

[p2p] filter 1p1c for child txid in recent rejects

2024-10-24 21:23:56 -04:00

txdownloadman_impl.h

[doc] comment fixups from n30110

2024-10-30 21:13:01 -04:00

txdownloadman.h

[doc] comment fixups from n30110

2024-10-30 21:13:01 -04:00

txreconciliation.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

txreconciliation.h

…

types.h

rpc: clarify ALREADY_IN_CHAIN rpc errors

2024-08-05 15:45:58 +01:00

utxo_snapshot.cpp

streams: remove unused code

2024-09-19 07:33:02 -04:00

utxo_snapshot.h

assumeutxo: Drop block height from metadata

2024-08-08 23:55:06 +02:00

warnings.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

warnings.h

refactor: remove warnings globals

2024-06-13 11:20:49 +01:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.