highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
5cf4d266d9b1e7bd9394e7581398de5bc540ae99
bitcoin/src/node
History
fanquake 08ea835220 Merge bitcoin/bitcoin#28583: refactor: [tidy] modernize-use-emplace 
fa05a726c2 tidy: modernize-use-emplace (MarcoFalke)

Pull request description:

  Constructing a temporary unnamed object only to copy or move it into a container seems both verbose in code and a strict performance penalty.

  Fix both issues via the `modernize-use-emplace` tidy check.

ACKs for top commit:
  Sjors:
    re-utACK fa05a726c2
  hebasto:
    ACK fa05a726c2.
  TheCharlatan:
    ACK fa05a726c2

Tree-SHA512: 4408a094f406e7bf6c1468c2b0798f68f4d952a1253cf5b20bdc648ad7eea4a2c070051fed46d66fd37bce2ce6f85962484a1d32826b7ab8c9baba431eaa2765
2023-10-16 15:35:50 +01:00
..
abort.cpp
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
abort.h
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
blockmanager_args.cpp
refactor: Move stopafterblockimport handling out of blockstorage
2023-07-11 12:00:57 +02:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
blockstorage.h
blockstorage: segment normal/assumedvalid blockfiles
2023-09-30 06:40:17 -04:00
caches.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
caches.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
chainstate.cpp
validation: remove unused mempool param in DetectSnapshotChainstate
2023-10-06 18:11:24 +02:00
chainstate.h
validation: Stricter assumeutxo error handling in LoadChainstate
2023-06-15 15:11:32 -04:00
chainstatemanager_args.cpp
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
chainstatemanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
coin.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
coin.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
refactor, txdb: Add CoinsViewOptions struct
2023-02-10 04:39:11 -04:00
connection_types.cpp
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
connection_types.h
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
context.cpp
kernel: Add notification interface
2023-05-20 12:03:22 +02:00
context.h
refactor: init indexes, decouple 'Start()' from the creation step
2023-07-07 19:31:27 -03:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
refactor, dbwrapper: Add DBParams and DBOptions structs
2023-02-10 04:39:11 -04:00
eviction.cpp
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
eviction.h
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
interface_ui.cpp
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interface_ui.h
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interfaces.cpp
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
kernel_notifications.cpp
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
kernel_notifications.h
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
mempool_args.cpp
config: default acceptnonstdtxn=0 on all chains
2023-08-28 22:09:39 +10:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
miner.cpp
refactor: Fix logging.h includes
2023-08-05 10:42:56 +02:00
miner.h
Remove unused includes from txmempool.h
2023-08-17 16:25:31 +02:00
mini_miner.cpp
Make MiniMinerMempoolEntry fields private
2023-09-13 14:33:54 -04:00
mini_miner.h
Make MiniMinerMempoolEntry fields private
2023-09-13 14:33:54 -04:00
minisketchwrapper.cpp
Use steady clock in SeedStrengthen and FindBestImplementation
2023-03-02 14:48:28 +01:00
minisketchwrapper.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
peerman_args.cpp
Merge bitcoin/bitcoin#28149: net processing: clamp PeerManager::Options user input
2023-08-09 14:26:03 +02:00
peerman_args.h
[net processing] Introduce PeerManager options
2023-07-24 18:30:59 +02:00
psbt.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
psbt.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
README.md
doc: Remove irrelevant link to GitHub
2021-04-06 09:34:21 +02:00
transaction.cpp
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
transaction.h
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
txreconciliation.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
utxo_snapshot.cpp
lint: remove /* Continued */ markers from codebase
2023-08-03 17:52:24 +01:00
utxo_snapshot.h
refactor: Remove unused nchaintx from SnapshotMetadata constructor
2023-10-12 11:14:32 +02:00
validation_cache_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
validation_cache_args.h
validationcaches: Add and use ValidationCacheSizes
2022-08-03 12:03:27 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.

Reference in New Issue View Git Blame Copy Permalink