61de64df67
ee1b9b231aCalculateFeerateDiagramsForRBF: update misleading description of old diagram contents (Greg Sanders)a9d42b9aa5CompareFeerateDiagram: short-circuit comparison when detected as incomparable (Greg Sanders)cebcced65eremove erroneous CompareFeerateDiagram comment about slope (Greg Sanders)a0376e1061unit test: clarify unstated assumption for calc_feerate_diagram_rbf chunking (Greg Sanders)890cb015f3s/effected/affected/ (Greg Sanders)d9391ec095CalculateFeerateDiagramsForRBF: remove size tie-breaking from chunking conflicts (Greg Sanders)b684d82d7efuzz: Add more invariant checks for package_rbf (Greg Sanders)2a3ada8b21fuzz: finer grained ImprovesFeerateDiagram check on error result (Greg Sanders)c377ae9ba0unit test: improve ImprovesFeerateDiagram coverage with one less vb case (Greg Sanders)d2bf923eb1unit test: make calc_feerate_diagram_rbf less brittle (Greg Sanders)defe023f6efuzz: add PrioritiseTransaction coverage in diagram checks (Greg Sanders)216d5ff162unit test: add coverage showing priority affects diagram check results (Greg Sanders)a80d80936aunit test: add CheckConflictTopology case for not the only child (Greg Sanders)69bd18ca80unit test: check tx4 conflict error message (Greg Sanders)c0c37f07ebunit test: have CompareFeerateDiagram tested with diagrams both ways (Greg Sanders)b62e2c0fa5ImprovesFeerateDiagram: Spelling fix and removal of unused diagram vectors (Greg Sanders)bb42402945doc: fix comment about non-existing CompareFeeFrac (Greg Sanders) Pull request description: Follow-ups to https://github.com/bitcoin/bitcoin/pull/29242 ACKs for top commit: glozow: ACKee1b9b231a, reviewed the changes and package_rbf fuzzer seems to run fine murchandamus: crACKee1b9b231aismaelsadeeq: Code review ACKee1b9b231awillcl-ark: ACKee1b9b231aTree-SHA512: 8399fe12064fb49b0e4c73258968b57be1d9c2e35701b2d3b0bb67e2e4052e44216358238f92508e4697d0fb6176518d5b885474054d3deda242f669e99262a7
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.