mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 07:09:15 +01:00

Files

Andrew Chow 8d4a058ac4 Merge bitcoin/bitcoin#23997 : wallet: avoid rescans under assumed-valid blocks

817326a828 wallet: avoid rescans if under the snapshot (James O'Beirne)

Pull request description:

  This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11) (parent PR: #15606)

  ---

  Refuse to load a wallet if it requires a rescan lower than the height of assumed-valid blocks.

  Of course in live code right now, `BLOCK_ASSUMED_VALID` block index entries don't exist since they're a unique flag introduced by the use of UTXO snapshots, so this is prophylactic code exercised only by unittests.

ACKs for top commit:
  achow101:
    ACK 817326a828
  ryanofsky:
    Code review ACK 817326a828. This seems like the simplest change we can make to avoid wallet problems when an assumeutxo snapshot is loaded.

Tree-SHA512: cfa44b2eb33d1818d30df45210d0dde1e9b78cc9b7c88cb985054dc28427bba9e0905debe4196065d1d3a5ce7bca7e605e629d5ce5f0225b25395746e6d3d596

2022-07-18 14:39:55 -04:00

blockstorage.cpp

LoadMempool: Pass in load_path, stop using gArgs

2022-07-15 12:26:20 -04:00

blockstorage.h

LoadMempool: Pass in load_path, stop using gArgs

2022-07-15 12:26:20 -04:00

caches.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

caches.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

chainstate.cpp

Do not pass Consensus::Params& to Chainstate helpers

2022-05-18 18:45:30 +02:00

chainstate.h

Do not pass Consensus::Params& to Chainstate helpers

2022-05-18 18:45:30 +02:00

coin.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

coin.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

connection_types.cpp

[net] Move ConnectionType to its own file

2022-07-06 18:13:53 +02:00

connection_types.h

[net] Move ConnectionType to its own file

2022-07-06 18:13:53 +02:00

context.cpp

init: Initialize globals with kernel::Context's life

2022-06-02 11:40:03 -04:00

context.h

kernel: Introduce empty and unused kernel::Context

2022-05-31 14:18:31 -04:00

eviction.cpp

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

eviction.h

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

interface_ui.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interface_ui.h

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#23997 : wallet: avoid rescans under assumed-valid blocks

2022-07-18 14:39:55 -04:00

mempool_persist_args.cpp

DumpMempool: Pass in dump_path, stop using gArgs

2022-07-15 11:30:50 -04:00

mempool_persist_args.h

Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel

2022-07-15 12:26:20 -04:00

miner.cpp

miner: Make mempool optional for BlockAssembler

2022-06-06 15:38:09 -04:00

miner.h

miner: Make mempool optional for BlockAssembler

2022-06-06 15:38:09 -04:00

minisketchwrapper.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

minisketchwrapper.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

psbt.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

psbt.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

README.md

doc: Remove irrelevant link to GitHub

2021-04-06 09:34:21 +02:00

transaction.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

refactor: Remove defunct attributes.h includes

2022-05-21 13:54:33 -05:00

utxo_snapshot.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.