mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-29 21:33:02 +02:00

Files

Ava Chow 78567b052d Merge bitcoin/bitcoin#30697 : Bugfix: Ensure Atomicity in Wallet Settings Updates from Chain Interface

1b41d45d46 wallet: bugfix: ensure atomicity in settings updates (ismaelsadeeq)

Pull request description:

  This PR fixes #30620.

  As outlined in the issue, creating two wallets with `load_on_startup=true` simultaneously results in only one wallet being added to the startup file.

  The current issue arises because the wallet settings update process involves:
  1. Obtaining the settings value while acquiring the settings lock.
  2. Modifying the settings value.
  3. Overwriting the settings value while acquiring the settings lock again.

  This sequence is not thread-safe. Different threads could modify the same base value simultaneously, overwriting data from other workers without realizing it.

  The PR attempts to  fix this by modifying the chain interface's `updateRwSetting` method to accept a function that will be called with the settings reference. This function will either update or delete the setting and return an enum indicating whether the settings need to be overwritten in this or not.

  Additionally, this PR introduces two new methods to the chain interface:
  - `overwriteRwSetting`: This method replaces the setting with a new value.
  Used in `VerifyWallets`
  - `deleteRwSettings`: This method completely erases a specified setting.
  This method is currently used only in `overwriteRwSetting`.

  These changes ensure that updates are race-free across all clients.

ACKs for top commit:
  achow101:
    ACK 1b41d45d46
  furszy:
    self-code-ACK 1b41d45d46

Tree-SHA512: 50cda612b782aeb5e03e2cf63cc44779a013de1c535b883b57af4de22f24b0de80b4edecbcda235413baec0a12bdf0e5750fb6731c9e67d32e742d8c63f08c13

2024-08-27 12:29:20 -04:00

abort.cpp

…

abort.h

…

blockmanager_args.cpp

…

blockmanager_args.h

…

blockstorage.cpp

…

blockstorage.h

…

caches.cpp

…

caches.h

…

chainstate.cpp

…

chainstate.h

…

chainstatemanager_args.cpp

…

chainstatemanager_args.h

…

coin.cpp

…

coin.h

…

coins_view_args.cpp

…

coins_view_args.h

…

connection_types.cpp

…

connection_types.h

…

context.cpp

…

context.h

…

database_args.cpp

…

database_args.h

…

eviction.cpp

…

eviction.h

…

interface_ui.cpp

…

interface_ui.h

add missing #include <cstdint> for GCC 15

2024-08-12 11:15:11 +01:00

interfaces.cpp

wallet: bugfix: ensure atomicity in settings updates

2024-08-26 13:41:56 +01:00

kernel_notifications.cpp

…

kernel_notifications.h

…

mempool_args.cpp

…

mempool_args.h

…

mempool_persist_args.cpp

…

mempool_persist_args.h

…

mempool_persist.cpp

…

mempool_persist.h

…

miner.cpp

miner: adjust clock to timewarp rule

2024-08-20 18:51:37 +02:00

miner.h

…

mini_miner.cpp

…

mini_miner.h

…

minisketchwrapper.cpp

…

minisketchwrapper.h

…

peerman_args.cpp

…

peerman_args.h

…

protocol_version.h

…

psbt.cpp

…

psbt.h

…

README.md

…

timeoffsets.cpp

…

timeoffsets.h

…

transaction.cpp

…

transaction.h

…

txreconciliation.cpp

…

txreconciliation.h

…

types.h

…

utxo_snapshot.cpp

…

utxo_snapshot.h

…

warnings.cpp

…

warnings.h

…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.