Russell Yanofsky e9fd366044 refactor: Remove null setting check in GetSetting() ...

Also rename the "result_complete" variable in GetSettingsList() to "done" to be
more consistent with GetSetting().

This change doesn't affect current behavior but could be useful in the future
to support dynamically changing settings at runtime and adding new settings
sources, because it lets high priority sources reset settings back to default
(see test).

By removing a special case for null, this change also helps merge code treat
settings values more like black boxes, and interfere less with settings parsing
and retrieval.

2019-11-13 15:23:06 -05:00

7.4 KiB

Raw Blame History

View Raw