70398ae05bmapport: make ProcessPCP void (Antoine Poinsot)9e6cba2988mapport: remove unnecessary 'g_mapport_enabled' (Antoine Poinsot)8fb45fcda0mapport: remove unnecessary 'g_mapport_current' variable (Antoine Poinsot)1b223cb19bmapport: merge DispatchMapPort into StartMapPort (Antoine Poinsot)9bd936fa34mapport: drop unnecessary function (Antoine Poinsot)2a6536cedamapport: rename 'use_pcp' to 'enable' (Antoine Poinsot)c4e82b854cmapport: make 'enabled' and 'current' bool (Antoine Poinsot) Pull request description: Followup to #31130, this does a couple cleanups to `src/mapport.*` to clarify the logic now that there is a single protocol option for port mapping. ACKs for top commit: laanwj: Code review ACK70398ae05bTheCharlatan: ACK70398ae05bTree-SHA512: d9a3ab4fcd59a7cf4872415c40cc7ac3a98dfc5aa25e195d4df880bb588bac286c30c3471e9d9499de379a75f45dcd0a82019eba3cb9f342004ae1482d0ba075
src/node/
The src/node/ directory contains code that needs to access node state
(state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar
classes).
Code in src/node/ is meant to be segregated from code in
src/wallet/ and src/qt/, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/,
src/wallet/, or src/qt/ directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/ classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp and
src/txmempool.cpp might be moved there.