highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
8405fdb06e8ff3220590bfac84e98547067ec6b7
bitcoin/src/node
History
Ava Chow 8405fdb06e Merge bitcoin/bitcoin#33169: interfaces, chain, refactor: Remove unused getTipLocator and incaccurate getActiveChainLocator 
2b00030af8 interfaces, chain, refactor: Remove inaccurate getActiveChainLocator (pablomartin4btc)
110a0f405c interfaces, chain, refactor: Remove unused getTipLocator (pablomartin4btc)

Pull request description:

  Remove `Chain::getTipLocator`, `Chain::GetLocator()`, and `Chain::getActiveChainLocator`:
  - `Chain::getTipLocator` is no longer used.
  - `Chain::GetLocator`, replaced its call by `GetLocator()`, which uses `LocatorEntries`, avoiding direct access to the chain itself (change suggested by l0rinc while reviewing this PR to maintain consistency with the overall refactoring).
  - `Chain::getActiveChainLocator`, whose name was misleading, has functionality redundant with Chain::findBlock.
    - Additionally, the comment for getActiveChainLocator became inaccurate following changes in commit ed470940cd (from PR #25717).

  This is a [follow-up](https://github.com/bitcoin/bitcoin/pull/29652#issuecomment-3151665095) to #29652.

ACKs for top commit:
  achow101:
    ACK 2b00030af8
  furszy:
    ACK 2b00030af8
  stickies-v:
    ACK 2b00030af8
  w0xlt:
    ACK 2b00030af8

Tree-SHA512: b12ba6a15feeaeec692d69204a6e155e3af43edfac25597dabf14cacca1e4a2152574816e58dc544f39043c5721f5e707acf544f4541d3b9c0f8c0c40069215e
2025-08-14 11:30:45 -07:00
..
abort.cpp
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
abort.h
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
blockmanager_args.cpp
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
log: [refactor] Use info level for init logs
2025-07-25 09:50:50 +02:00
blockstorage.h
refactor: encapsulate vector/array keys into Obfuscation
2025-07-16 14:33:07 -07:00
caches.cpp
node: cap -dbcache to 1GiB on 32-bit architectures
2025-05-19 16:39:58 -04:00
caches.h
init: Use size_t consistently for cache sizes
2025-01-15 15:44:56 +01:00
chainstate.cpp
log: [refactor] Use info level for init logs
2025-07-25 09:50:50 +02:00
chainstate.h
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
chainstatemanager_args.cpp
Remove checkpoints
2025-03-13 11:13:13 +00:00
chainstatemanager_args.h
refactor: Clamp worker threads in ChainstateManager constructor
2024-11-18 11:13:20 +01:00
coin.cpp
refactor: Rely on returned value of GetCoin instead of parameter
2024-09-18 20:03:47 +02:00
coin.h
…
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
…
connection_types.cpp
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
connection_types.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
context.cpp
Introduce Mining interface
2024-06-18 18:47:51 +02:00
context.h
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
…
eviction.cpp
…
eviction.h
…
interface_ui.cpp
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
interface_ui.h
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
interfaces.cpp
Merge bitcoin/bitcoin#33169: interfaces, chain, refactor: Remove unused getTipLocator and incaccurate getActiveChainLocator
2025-08-14 11:30:45 -07:00
kernel_notifications.cpp
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
kernel_notifications.h
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
mempool_args.cpp
log: [refactor] Use info level for init logs
2025-07-25 09:50:50 +02:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
…
mempool_persist.cpp
mempool, refactor: Convert uint256 to Txid
2025-08-11 16:26:35 +01:00
mempool_persist.h
mempool: move LoadMempool/DumpMempool to node
2024-06-26 22:47:09 +00:00
miner.cpp
validation: refactor TestBlockValidity
2025-06-14 14:32:45 +02:00
miner.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
mini_miner.cpp
refactor: Convert mini_miner from uint256 to Txid
2025-08-11 16:12:42 +01:00
mini_miner.h
refactor: Convert mini_miner from uint256 to Txid
2025-08-11 16:12:42 +01:00
minisketchwrapper.cpp
log: [refactor] Use info level for init logs
2025-07-25 09:50:50 +02:00
minisketchwrapper.h
…
peerman_args.cpp
[prep/config] remove -maxorphantx
2025-07-14 16:13:10 -04:00
peerman_args.h
doc: add & amend copyright headers
2025-05-20 09:43:21 +01:00
protocol_version.h
Rename version.h to node/protocol_version.h
2023-11-30 11:28:31 +01:00
psbt.cpp
psbt: Check sighash types in SignPSBTInput and take sighash as optional
2025-05-14 14:00:43 -07:00
psbt.h
…
README.md
…
timeoffsets.cpp
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00
timeoffsets.h
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00
transaction.cpp
mempool, refactor: Convert uint256 to Txid
2025-08-11 16:26:35 +01:00
transaction.h
mempool, refactor: Convert uint256 to Txid
2025-08-11 16:26:35 +01:00
txdownloadman_impl.cpp
refactor: Convert remaining instances from uint256 to Txid
2025-08-11 16:47:43 +01:00
txdownloadman_impl.h
scripted-diff: rename OrphanTxBase to OrphanInfo
2025-08-01 11:52:32 -04:00
txdownloadman.h
scripted-diff: rename OrphanTxBase to OrphanInfo
2025-08-01 11:52:32 -04:00
txorphanage.cpp
Merge bitcoin/bitcoin#32941: p2p: TxOrphanage revamp cleanups
2025-08-04 16:47:54 +01:00
txorphanage.h
scripted-diff: rename "ann" variables to "latency_score"
2025-08-01 11:52:32 -04:00
txreconciliation.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
types.h
Add checkBlock to Mining interface
2025-06-14 14:32:45 +02:00
utxo_snapshot.cpp
streams: remove unused code
2024-09-19 07:33:02 -04:00
utxo_snapshot.h
assumeutxo: Drop block height from metadata
2024-08-08 23:55:06 +02:00
warnings.cpp
scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
2024-10-10 12:22:12 +02:00
warnings.h
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.

Reference in New Issue View Git Blame Copy Permalink