mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-11 16:17:54 +02:00
4565cff72c
A missing Init::makeMining implementation was causing internal code using the
mining interface (like the `waitforblockheight` RPC method) to not work when
running inside the `bitcoin-gui` binary. It was working the other bitcoin
binaries ('bitocind`, `bitcoin-qt`, and `bitcoin-node`) because they
implmemented `Init::makeMining` methods in commit
8ecb681678 from #30200, but the `bitcoin-gui`
init class was forgotten in that change.
This bug was reported by Matthew Zipkin <pinheadmz@gmail.com>
https://github.com/bitcoin/bitcoin/pull/32297#pullrequestreview-2932651216
59 lines
2.2 KiB
C++
59 lines
2.2 KiB
C++
// Copyright (c) 2021-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <init.h>
|
|
#include <interfaces/chain.h>
|
|
#include <interfaces/echo.h>
|
|
#include <interfaces/init.h>
|
|
#include <interfaces/ipc.h>
|
|
#include <interfaces/mining.h>
|
|
#include <interfaces/node.h>
|
|
#include <interfaces/rpc.h>
|
|
#include <interfaces/wallet.h>
|
|
#include <node/context.h>
|
|
#include <util/check.h>
|
|
|
|
#include <memory>
|
|
|
|
namespace init {
|
|
namespace {
|
|
const char* EXE_NAME = "bitcoin-gui";
|
|
|
|
class BitcoinGuiInit : public interfaces::Init
|
|
{
|
|
public:
|
|
BitcoinGuiInit(const char* arg0) : m_ipc(interfaces::MakeIpc(EXE_NAME, arg0, *this))
|
|
{
|
|
InitContext(m_node);
|
|
m_node.init = this;
|
|
}
|
|
std::unique_ptr<interfaces::Node> makeNode() override { return interfaces::MakeNode(m_node); }
|
|
std::unique_ptr<interfaces::Chain> makeChain() override { return interfaces::MakeChain(m_node); }
|
|
std::unique_ptr<interfaces::Mining> makeMining() override { return interfaces::MakeMining(m_node); }
|
|
std::unique_ptr<interfaces::WalletLoader> makeWalletLoader(interfaces::Chain& chain) override
|
|
{
|
|
return MakeWalletLoader(chain, *Assert(m_node.args));
|
|
}
|
|
std::unique_ptr<interfaces::Echo> makeEcho() override { return interfaces::MakeEcho(); }
|
|
std::unique_ptr<interfaces::Rpc> makeRpc() override { return interfaces::MakeRpc(m_node); }
|
|
interfaces::Ipc* ipc() override { return m_ipc.get(); }
|
|
// bitcoin-gui accepts -ipcbind option even though it does not use it
|
|
// directly. It just returns true here to accept the option because
|
|
// bitcoin-node accepts the option, and bitcoin-gui accepts all bitcoin-node
|
|
// options and will start the node with those options.
|
|
bool canListenIpc() override { return true; }
|
|
const char* exeName() override { return EXE_NAME; }
|
|
node::NodeContext m_node;
|
|
std::unique_ptr<interfaces::Ipc> m_ipc;
|
|
};
|
|
} // namespace
|
|
} // namespace init
|
|
|
|
namespace interfaces {
|
|
std::unique_ptr<Init> MakeGuiInit(int argc, char* argv[])
|
|
{
|
|
return std::make_unique<init::BitcoinGuiInit>(argc > 0 ? argv[0] : "");
|
|
}
|
|
} // namespace interfaces
|