mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-11 21:20:39 +02:00
8c64ff0242
da7d7dbc7ccontrib: remove deprecated --deep codesign flag (Sjors Provoost)ad4eeaf859ci: avoid modifying GOAL in 03_test_script.sh (Sjors Provoost) Pull request description: Replace the deprecated `codesign --deep` with explicit, and minimal, per-component signing of Frameworks, Plugins and the top-level bundle. The CI signature check introduced in #34787 is updated to use `--strict`. Can be tested with: ```sh cmake -B build -DBUILD_GUI=ON # delete artifacts before rebuilding the `deploy` target rm -rf build/Bitcoin-Qt.app build/bitcoin-macos-app.zip cmake --build build -t deploy codesign --verify --deep --strict --verbose=4 build/dist/Bitcoin-Qt.app ``` Fixes #32486, supersedes #33592 (this is a condensed version) Additionally this PR modifies `03_test_script.sh` to avoid modifying `GOAL` in place. That was causing the `codesign --verify` step to get skipped entirely. ACKs for top commit: fanquake: ACKda7d7dbc7c- I think we should try and cleanup `macdeployqtplus` somewhat, but that can happen in future. willcl-ark: Light ACKda7d7dbc7cTree-SHA512: 54e6d38a327a9a241d842728390770e7819d45180c69c288f1e26c5706aff8ebedbb4f608c4a45b2b186e3369181b116aa82134a38fcaabf3af3711be14b9863