8daac1d6eb
Move block template defaulting into helper functions for BlockCreateOptions. FlattenMiningOptions() fills hardcoded defaults and MergeMiningOptions() overlays defaults without replacing caller-provided values. Use the shared option type in BlockAssembler so IPC callers and internal callers can pass through the same options path. This commit does not change behavior, except for dropping the "Specified " prefix from startup option error messages. Keep the -blockmintxfee ParseMoney check in ReadMiningArgs() instead of CheckMiningOptions(), because CheckMiningOptions() only sees the parsed CFeeRate value and not the original string. Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
src/node/
The src/node/ directory contains code that needs to access node state
(state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar
classes).
Code in src/node/ is meant to be segregated from code in
src/wallet/ and src/qt/, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/,
src/wallet/, or src/qt/ directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/ classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp and
src/txmempool.cpp might be moved there.