f18f9ef4d3
Amend bumpfee for inputs with overlapping ancestry (Murch)2e35e944da
Bump unconfirmed parent txs to target feerate (Murch)3e3e052411
coinselection: Move GetSelectionWaste into SelectionResult (Andrew Chow)c57889da66
[node] interface to get bump fees (glozow)c24851be94
Make MiniMinerMempoolEntry fields private (Murch)ac6030e4d8
Remove unused imports (Murch)d2f90c31ef
Fix calculation of ancestor set feerates in test (Murch)a1f7d986e0
Match tx names to index in miniminer overlap test (Murch) Pull request description: Includes some commits to address follow-ups from #27021: https://github.com/bitcoin/bitcoin/pull/27021#issuecomment-1554675156 Reduces the effective value of unconfirmed UTXOs by the fees necessary to bump their ancestor transactions to the same feerate. While the individual UTXOs always account for their full ancestry before coin-selection, we can correct potential overestimates with a second pass where we establish the ancestry and bump fee for the whole input set collectively. Fixes #9645 Fixes #9864 Fixes #15553 ACKs for top commit: S3RK: ACKf18f9ef4d3
ismaelsadeeq: ACKf18f9ef4d3
achow101: ACKf18f9ef4d3
brunoerg: crACKf18f9ef4d3
t-bast: ACKf18f9ef4d3
, I reviewed the latest changes and run e2e tests against eclair, everything looks good 👍 Tree-SHA512: b65180c4243b1f9d13c311ada7a1c9f2f055d530d6c533b78c2068b50b8c29ac1321e89e85675b15515760d4f1b653ebd9da77b37c7be52d9bc565a3538f0aa6
src/node/
The src/node/
directory contains code that needs to access node state
(state in CChain
, CBlockIndex
, CCoinsView
, CTxMemPool
, and similar
classes).
Code in src/node/
is meant to be segregated from code in
src/wallet/
and src/qt/
, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/
,
src/wallet/
, or src/qt/
directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/
classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp
and
src/txmempool.cpp
might be moved there.