mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-18 22:35:39 +01:00

Files

fanquake bd616bc16a Merge bitcoin/bitcoin#24917 : Make BlockManager::LoadBlockIndex private

fa1970f075 Make BlockManager::LoadBlockIndex private (MarcoFalke)

Pull request description:

  * After commit fa27f03b49 `BlockManager::LoadBlockIndex` is only called by `BlockManager::LoadBlockIndexDB`. Thus, it can be made `private`.

  * After commit c600ee3816 `m_best_invalid` is no longer accessed by `BlockManager::LoadBlockIndex`. Thus, the unused `friend` can be removed.

ACKs for top commit:
  mruddy:
    ACK fa1970f075 I verified by double checking references, then applying the patch, and running `make check`. LGTM.

Tree-SHA512: 9b36b4c59bf7ad01171764ce61b1be9750fc92d105c4fe939b1a6a70027ab6300d5d2a2fc3e82f981e22c3987f2ca84e092d2e1f8463fa320af9f05048580c0a

2022-04-26 20:20:07 +01:00

blockstorage.cpp

blockstorage: Add prune locks to BlockManager

2022-04-25 23:21:58 +02:00

blockstorage.h

Merge bitcoin/bitcoin#24917 : Make BlockManager::LoadBlockIndex private

2022-04-26 20:20:07 +01:00

caches.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

caches.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

chainstate.cpp

scripted-diff: Rename pindexBestHeader, fHavePruned

2022-04-19 14:36:18 -04:00

chainstate.h

Avoid implicit-integer-sign-change in VerifyLoadedChainstate

2022-02-21 10:29:37 +01:00

coin.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

coin.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

coinstats.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

coinstats.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

context.cpp

[init] Add netgroupman to node.context

2022-04-19 10:25:40 +01:00

context.h

[init] Add netgroupman to node.context

2022-04-19 10:25:40 +01:00

interfaces.cpp

scripted-diff: Rename pindexBestHeader, fHavePruned

2022-04-19 14:36:18 -04:00

miner.cpp

Remove buggy and confusing IncrementExtraNonce

2022-04-01 11:00:42 +02:00

miner.h

Remove buggy and confusing IncrementExtraNonce

2022-04-01 11:00:42 +02:00

minisketchwrapper.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

minisketchwrapper.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

psbt.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

psbt.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

README.md

doc: Remove irrelevant link to GitHub

2021-04-06 09:34:21 +02:00

transaction.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

ui_interface.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

ui_interface.h

refactor: Make MessageBoxFlags enum underlying type unsigned

2022-01-31 09:27:12 +01:00

utxo_snapshot.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.