mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-30 18:35:54 +02:00

Files

MacroFake a1fff275e7 Merge bitcoin/bitcoin#25704 : refactor: Remove almost all validation option globals

aaaa7bd0ba iwyu: Add missing includes (MacroFake)
fa9ebec096 Remove g_parallel_script_checks (MacroFake)
fa7c834b9f Move ::fCheckBlockIndex into ChainstateManager (MacroFake)
fa43188d86 Move ::fCheckpointsEnabled into ChainstateManager (MacroFake)
cccca83099 Move ::nMinimumChainWork into ChainstateManager (MacroFake)
fa29d0b57c Move ::hashAssumeValid into ChainstateManager (MacroFake)
faf44876db Move ::nMaxTipAge into ChainstateManager (MacroFake)

Pull request description:

  It seems preferable to assign globals to a class (in this case `ChainstateManager`), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test behaviour.

ACKs for top commit:
  dergoegge:
    Code review ACK aaaa7bd0ba
  ryanofsky:
    Code review ACK aaaa7bd0ba. No changes since last review, other than rebase
  aureleoules:
    reACK aaaa7bd0ba

Tree-SHA512: 83ec3ba0fb4f1dad95810d4bd4e578454e0718dc1bdd3a794cc4e48aa819b6f5dad4ac4edab3719bdfd5f89cbe23c2740a50fd56c1ff81c99e521c5f6d4e898d

2022-10-26 11:41:57 +02:00

blockstorage.cpp

Merge bitcoin/bitcoin#25667 : assumeutxo: snapshot initialization

2022-10-13 10:19:27 -04:00

blockstorage.h

Merge bitcoin/bitcoin#24858 : incorrect blk file size calculation during reindex results in recoverable blk file corruption

2022-10-12 14:13:54 -04:00

caches.cpp

refactor: move DEFAULT_TXINDEX from validation to txindex

2022-10-03 18:19:39 +01:00

caches.h

…

chainstate.cpp

iwyu: Add missing includes

2022-10-18 14:12:52 +02:00

chainstate.h

refactor: Fix iwyu on node/chainstate

2022-07-21 20:23:23 +02:00

chainstatemanager_args.cpp

Move ::fCheckBlockIndex into ChainstateManager

2022-10-18 14:11:48 +02:00

chainstatemanager_args.h

Move ::nMinimumChainWork into ChainstateManager

2022-10-18 14:09:17 +02:00

coin.cpp

…

coin.h

…

connection_types.cpp

[net] Move ConnectionType to its own file

2022-07-06 18:13:53 +02:00

connection_types.h

[net] Move ConnectionType to its own file

2022-07-06 18:13:53 +02:00

context.cpp

…

context.h

…

eviction.cpp

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

eviction.h

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

interface_ui.cpp

Make validation interface capable of signalling header presync

2022-08-29 08:10:35 -04:00

interface_ui.h

Make validation interface capable of signalling header presync

2022-08-29 08:10:35 -04:00

interfaces.cpp

refactor: mempool: use CTxMempool::Limits

2022-10-05 13:07:11 +01:00

mempool_args.cpp

Merge bitcoin/bitcoin#25872 : Fix issues when calling std::move(const&)

2022-08-31 08:38:24 +01:00

mempool_args.h

scripted-diff: Move mempool_args to src/node

2022-08-02 15:31:01 +02:00

mempool_persist_args.cpp

DumpMempool: Pass in dump_path, stop using gArgs

2022-07-15 11:30:50 -04:00

mempool_persist_args.h

Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel

2022-07-15 12:26:20 -04:00

miner.cpp

Merge bitcoin/bitcoin#26118 : log: Use steady clock for bench logging

2022-10-10 12:00:34 +02:00

miner.h

scripted-diff: rename CChainState -> Chainstate

2022-09-09 11:47:27 -04:00

minisketchwrapper.cpp

…

minisketchwrapper.h

…

psbt.cpp

Verify PSBT inputs rather than check for fields being empty

2022-10-17 11:13:02 -04:00

psbt.h

…

README.md

…

transaction.cpp

…

transaction.h

…

txreconciliation.cpp

p2p: Finish negotiating reconciliation support

2022-10-17 12:35:44 +03:00

txreconciliation.h

p2p: Finish negotiating reconciliation support

2022-10-17 12:35:44 +03:00

utxo_snapshot.cpp

init: add utxo snapshot detection

2022-09-13 13:30:14 -04:00

utxo_snapshot.h

init: add utxo snapshot detection

2022-09-13 13:30:14 -04:00

validation_cache_args.cpp

validationcaches: Use size_t for sizes

2022-08-03 12:03:28 -04:00

validation_cache_args.h

validationcaches: Add and use ValidationCacheSizes

2022-08-03 12:03:27 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.