highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-02 03:02:35 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
MarcoFalke a9f6428708
Merge bitcoin/bitcoin#23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const 
7e88f61b285e6a356ea4f6ba384858f109559985 multiprocess: Make interfaces::Chain::isTaprootActive non-const (Russell Yanofsky)

Pull request description:

  `interfaces::Chain` is an abstract class, so declaring the method const would be exposing internal implementation details of subclasses to interface callers. And specifically this doesn't work because the multiprocess implementation of the `interfaces::Chain::isTaprootActive` method can't be const because IPC connection state and request state is not constant during the call.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

ACKs for top commit:
  jamesob:
    ACK 7e88f61b28

Tree-SHA512: 1c5ed89870aeb7170b9048c41299ab650dfa3d0978088e08c4c866fa0babb292722710b16f25540f26667220cb4747b1c256c4bd42893c552291eccc155346a3
2021-10-13 07:19:13 +02:00
..
blockstorage.cpp
Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode)
2021-10-04 22:45:43 +02:00
blockstorage.h
add missing atomic include
2021-06-22 11:06:30 +02:00
coin.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
coin.h
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coinstats.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
coinstats.h
[MOVEONLY] consensus: move amount.h into consensus
2021-09-30 07:41:57 +08:00
context.cpp
validation: Farewell, global Chainstate!
2021-06-10 15:05:25 -04:00
context.h
scripted-diff: Rename CAddrMan to AddrMan
2021-09-28 22:21:10 -04:00
interfaces.cpp
Merge bitcoin/bitcoin#23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const
2021-10-13 07:19:13 +02:00
psbt.cpp
[MOVEONLY] consensus: move amount.h into consensus
2021-09-30 07:41:57 +08:00
psbt.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
README.md
doc: Remove irrelevant link to GitHub
2021-04-06 09:34:21 +02:00
transaction.cpp
[GetTransaction] remove unneeded cs_main lock acquire
2021-08-02 18:31:02 +02:00
transaction.h
refactor: move GetTransaction(...) to node/transaction.cpp
2021-07-22 15:53:17 +02:00
ui_interface.cpp
gui: change combiner for signals to optional_last_value
2020-07-01 21:40:51 +08:00
ui_interface.h
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
utxo_snapshot.h
validation: remove nchaintx from assumeutxo metadata
2021-04-26 13:22:37 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.