highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-03 04:16:11 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
aa69471ecd553dbcd7dd6d1b2e59dfb69d6a0cf3
bitcoin/src
History
MarcoFalke aa69471ecd Merge #21572: Fix wrong wallet RPC context set after #21366 
937fd4a66f Fix wrong wallet RPC context set after #21366 (Russell Yanofsky)

Pull request description:

  This bug doesn't have any effects currently because it only affects
  external signer RPCs which aren't currently using the wallet context,
  but it does cause an appveyor failure in a upcoming PR:

  https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/38512882

  This bug is subtle and could have been avoided if JSONRPCRequest didn't
  have constructors that were so loose with type checking.  Suggested
  change
  https://github.com/bitcoin/bitcoin/pull/21366#issuecomment-792044351
  eliminates these and would be a good followup for a future PR.

  This PR just implements the simplest possible fix.

ACKs for top commit:
  theStack:
    Code-review ACK 937fd4a66f
  meshcollider:
    Code review ACK 937fd4a66f

Tree-SHA512: 53e6265ed6c7abb47d2b3e77d1604edfeb993c3a2440f0c19679cfeb23516965e6707ff486196a0acfbeff21c79a9a08b5cd33bae9a232d33d0134bca1bd0ff3
2021-04-07 10:53:26 +02:00
..
bench
Merge #20861: BIP 350: Implement Bech32m and use it for v1+ segwit addresses
2021-03-18 20:37:21 +01:00
compat
compat: remove memcpy -> memmove backwards compatibility alias
2021-03-10 14:31:10 +08:00
config
…
consensus
…
crc32c
…
crypto
…
index
refactor: Remove negative lock annotations from globals
2021-04-05 08:42:15 +02:00
interfaces
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
leveldb
…
logging
…
node
refactor: Prefer clean assert over UB in coinstats
2021-04-04 07:37:43 +02:00
policy
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
primitives
…
qt
Merge #21557: test: small cleanup in RPCNestedTests tests
2021-04-06 08:45:08 +02:00
rpc
Merge #21302: wallet: createwallet examples for descriptor wallets
2021-04-05 15:31:41 +02:00
script
Merge #21166: Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it
2021-04-07 12:47:41 +08:00
secp256k1
…
support
…
test
Merge #21617: fuzz: Fix uninitialized read in i2p test
2021-04-07 10:39:27 +02:00
univalue
…
util
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
wallet
Merge #21572: Fix wrong wallet RPC context set after #21366
2021-04-07 10:53:26 +02:00
zmq
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
.clang-format
…
addrdb.cpp
log: Clarify log message when file does not exist
2021-02-18 15:08:35 +01:00
addrdb.h
…
addrman.cpp
…
addrman.h
…
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
naming nits
2021-03-17 17:59:22 -07:00
bech32.h
naming nits
2021-03-17 17:59:22 -07:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #18335: bitcoin-cli: print useful error if bitcoind rpc work queue exceeded
2021-03-19 20:52:16 +01:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
Merge #21560: net: Add Tor v3 hardcoded seeds
2021-04-06 10:47:51 +02:00
chainparams.h
Merge #21560: net: Add Tor v3 hardcoded seeds
2021-04-06 10:47:51 +02:00
chainparamsbase.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
chainparamsbase.h
…
chainparamsseeds.h
net: Deserialize hardcoded seeds from BIP155 blob
2021-04-05 14:00:48 +02:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
simplify ChainstateManager::SnapshotBlockhash() return semantics
2021-02-12 07:53:29 -06:00
coins.h
Merge #18030: doc: Coin::IsSpent() can also mean never existed
2021-03-23 11:11:02 +01:00
compat.h
net: extend Sock with methods for robust send & read until terminator
2021-03-01 17:36:16 +01:00
compressor.cpp
…
compressor.h
…
core_io.h
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
core_memusage.h
…
core_read.cpp
…
core_write.cpp
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
dummywallet.cpp
wallet: add -signer argument for external signer command
2021-02-23 14:34:30 +01:00
flatfile.cpp
…
flatfile.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
fs.cpp
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
httprpc.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
httpserver.cpp
Merge #18335: bitcoin-cli: print useful error if bitcoind rpc work queue exceeded
2021-03-19 20:52:16 +01:00
httpserver.h
…
i2p.cpp
i2p: use pointers to Sock to accommodate mocking
2021-03-16 13:59:18 +01:00
i2p.h
i2p: use pointers to Sock to accommodate mocking
2021-03-16 13:59:18 +01:00
indirectmap.h
…
init.cpp
Merge #21366: refactor: replace util::Ref with std::any (C++17)
2021-03-31 20:17:39 +02:00
init.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
key_io.cpp
Use Bech32m encoding for v1+ segwit addresses
2021-03-16 10:48:36 -07:00
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
net: implement the necessary parts of the I2P SAM protocol
2021-03-01 18:19:37 +01:00
logging.h
net: implement the necessary parts of the I2P SAM protocol
2021-03-01 18:19:37 +01:00
Makefile.am
remove unused class util::Ref and its unit test
2021-03-29 23:29:47 +02:00
Makefile.bench.include
…
Makefile.crc32c.include
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
Makefile.leveldb.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
Qt: add Android packaging support
2021-03-21 22:33:27 +01:00
Makefile.qttest.include
test: remove qt byteswap compattests
2021-03-29 11:12:26 +08:00
Makefile.test_fuzz.include
build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
2021-03-04 12:34:46 +08:00
Makefile.test_util.include
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
Makefile.test.include
Merge #21366: refactor: replace util::Ref with std::any (C++17)
2021-03-31 20:17:39 +02:00
mapport.cpp
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
mapport.h
…
memusage.h
…
merkleblock.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
merkleblock.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
miner.cpp
miner: Add chainstate member to BlockAssembler
2021-03-24 15:40:56 -04:00
miner.h
miner: Add chainstate member to BlockAssembler
2021-03-24 15:40:56 -04:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
net_processing.h
[net_processing] Keep addrman reference in PeerManager
2021-03-20 10:24:40 +00:00
net_types.h
…
net.cpp
Merge #21560: net: Add Tor v3 hardcoded seeds
2021-04-06 10:47:51 +02:00
net.h
[net] Changes to RunInactivityChecks
2021-04-01 11:35:27 +01:00
netaddress.cpp
net: add I2P to the reachability map
2021-03-01 18:19:46 +01:00
netaddress.h
net: extend CNetAddr::SetSpecial() to support I2P
2021-03-01 13:22:11 +01:00
netbase.cpp
Merge #21387: p2p: Refactor sock to add I2P fuzz and unit tests
2021-03-30 17:41:13 +02:00
netbase.h
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
psbt.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
…
randomenv.cpp
rand: only try and use freeifaddrs if available
2021-03-29 11:08:29 +08:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
shutdown: Use RAII TokenPipe in shutdown
2021-03-04 18:24:00 +01:00
shutdown.h
…
signet.cpp
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
signet.h
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
span.h
…
streams.h
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
sync.cpp
…
sync.h
refactor: Remove negative lock annotations from globals
2021-04-05 08:42:15 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
…
timedata.cpp
…
timedata.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
tinyformat.h
…
torcontrol.cpp
torcontrol: Move TorControlReply, TorControlConnection and TorController to improve testability
2021-03-02 12:21:32 +00:00
torcontrol.h
tests: Add fuzzing harness for TorController
2021-03-02 12:21:32 +00:00
txdb.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
txdb.h
…
txmempool.cpp
refactor: return std::nullopt instead of {}
2021-03-22 11:22:06 +08:00
txmempool.h
fuzz: Add tx_pool fuzz targets
2021-03-18 18:43:52 +01:00
txorphanage.cpp
scripted-diff: Update txorphanage naming convention
2021-02-27 01:08:09 +10:00
txorphanage.h
refactor: Remove negative lock annotations from globals
2021-04-05 08:42:15 +02:00
txrequest.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
txrequest.h
…
uint256.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
uint256.h
…
undo.h
…
validation.cpp
Fix assumeutxo crash due to missing base_blockhash
2021-04-04 07:38:02 +02:00
validation.h
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
…
versionbits.cpp
…
versionbits.h
validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}
2021-03-01 17:56:07 -05:00
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…