highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
aa69471ecd553dbcd7dd6d1b2e59dfb69d6a0cf3
bitcoin/src/wallet
History
MarcoFalke aa69471ecd Merge #21572: Fix wrong wallet RPC context set after #21366 
937fd4a66f Fix wrong wallet RPC context set after #21366 (Russell Yanofsky)

Pull request description:

  This bug doesn't have any effects currently because it only affects
  external signer RPCs which aren't currently using the wallet context,
  but it does cause an appveyor failure in a upcoming PR:

  https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/38512882

  This bug is subtle and could have been avoided if JSONRPCRequest didn't
  have constructors that were so loose with type checking.  Suggested
  change
  https://github.com/bitcoin/bitcoin/pull/21366#issuecomment-792044351
  eliminates these and would be a good followup for a future PR.

  This PR just implements the simplest possible fix.

ACKs for top commit:
  theStack:
    Code-review ACK 937fd4a66f
  meshcollider:
    Code review ACK 937fd4a66f

Tree-SHA512: 53e6265ed6c7abb47d2b3e77d1604edfeb993c3a2440f0c19679cfeb23516965e6707ff486196a0acfbeff21c79a9a08b5cd33bae9a232d33d0134bca1bd0ff3
2021-04-07 10:53:26 +02:00
..
test
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
bdb.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
bdb.h
wallet: Add BerkeleyDB version sanity check at init time
2021-01-17 18:10:20 +01:00
coincontrol.cpp
[rpc] walletcreatefundedpsbt: don't automatically append inputs
2020-03-12 13:07:17 +01:00
coincontrol.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
coinselection.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
coinselection.h
Merge #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping
2021-02-01 22:43:17 +13:00
context.cpp
Remove g_rpc_chain global
2020-05-28 02:13:19 -04:00
context.h
wallet: Pass unused args to StartWallets
2020-07-09 13:07:37 +02:00
crypter.cpp
Fix occurences of c_str() used with size() to data()
2019-10-28 13:41:45 +01:00
crypter.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
db.cpp
wallet: List all wallets in non-SQLite or non-BDB builds
2020-12-04 11:03:28 -04:00
db.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
dump.cpp
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
dump.h
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
external_signer_scriptpubkeyman.cpp
rpc: signerdisplayaddress
2021-02-23 14:34:31 +01:00
external_signer_scriptpubkeyman.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.cpp
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
feebumper.cpp
Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing
2021-03-09 10:42:21 +13:00
feebumper.h
wallet: Avoid translating RPC errors when creating txs
2020-05-01 07:39:06 -04:00
fees.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
fees.h
Remove uses of fee globals in wallet code
2019-02-22 15:43:02 -04:00
init.cpp
Add new format string placeholders for walletnotify to include relevant block information for transactions
2021-03-15 18:45:36 +02:00
interfaces.cpp
Fix wrong wallet RPC context set after #21366
2021-04-02 12:48:20 -04:00
ismine.h
doc: Add developer documentation to isminetype
2021-01-19 19:04:45 +08:00
load.cpp
remove unnecessary newline from initWarning() argument
2021-03-24 04:31:48 -06:00
load.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
rpcdump.cpp
Merge #21063: wallet, rpc: update listdescriptors response format
2021-04-02 13:18:35 +08:00
rpcsigner.cpp
rpc: don't require wallet for enumeratesigners
2021-03-11 15:15:14 +01:00
rpcsigner.h
rpc: add external signer RPC files
2021-02-23 14:34:30 +01:00
rpcwallet.cpp
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
rpcwallet.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
salvage.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
salvage.h
wallettool: Have RecoverDatabaseFile return errors and warnings
2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
scriptpubkeyman.h
wallet: ExternalSigner: add GetDescriptors method
2021-02-23 14:34:31 +01:00
sqlite.cpp
wallet: refactor: dedup sqlite statement deletions
2021-04-02 15:48:02 +02:00
sqlite.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
wallet.cpp
Merge #21040: wallet: Fix already-loading message grammar
2021-03-21 07:51:11 +01:00
wallet.h
refactor: Remove negative lock annotations from globals
2021-04-05 08:42:15 +02:00
walletdb.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
walletdb.h
Include wallet/bdb.h where it is actually being used
2020-11-18 11:55:43 -05:00
wallettool.cpp
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
wallettool.h
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
walletutil.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
walletutil.h
wallet: add external_signer flag
2021-02-23 14:34:30 +01:00