highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-13 06:04:42 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
ab8a7af74209e5d58203af14d9133d14de6a5776
bitcoin/src
History
merge-script 9581a0a5b1 Merge bitcoin/bitcoin#34615: mempool: expose optimality of mempool to log / rpc 
a9e59f7d95 rpc: add optimal result to getmempoolinfo (Greg Sanders)
a3fb3dd55c mempool: log if we detect a non-optimal mempool (Greg Sanders)

Pull request description:

  Post-SFL #34023 I don't think we expect the mempool to be unordered for long periods of time. If we consider it likely to be a serious regression in production, it would be useful to expose the fact  that the mempool is not known to be optimal.

  1. do a MEMPOOL log after any `DoWork()` returns false, meaning non-optimal
  2. expose it via getmempoolinfo, by calling `DoWork(0)`, which does nothing but return known-optimality

  I'm not wedded to either approach, I just think something is better than nothing for the next release.

ACKs for top commit:
  ajtowns:
    ACK a9e59f7d95
  ismaelsadeeq:
    reACK a9e59f7d95 [c89b93b95..a9e59f7d95](c89b93b958..a9e59f7d95) fixed typo, added more logging for block/reorg additions to mempool, and fixed brittle test case.
  sedited:
    ACK a9e59f7d95
  sipa:
    ACK a9e59f7d95

Tree-SHA512: 1560ad21cc1606df7279c102f35f61d4555c0ac920f02208b2a6eb89b14d7e22befb6d7f510a00a9074c2f9931f32e9af86bcea3a8dd9a1d947b0398c84666dd
2026-02-23 17:10:20 +01:00
..
bench
txgraph: pass fallback_order to TxGraph (preparation)
2026-02-09 15:55:58 -05:00
common
Merge bitcoin/bitcoin#34549: net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures
2026-02-19 16:57:54 -08:00
compat
Merge bitcoin/bitcoin#34090: net: Fix -Wmissing-braces
2026-01-22 12:39:52 +01:00
consensus
consensus/doc: explain GetValueOut() precondition
2026-02-02 19:32:14 +01:00
crc32c
…
crypto
iwyu: Add temporary mapping to work around upstream bug
2026-01-30 11:50:17 +00:00
index
Merge bitcoin/bitcoin#29770: index: Check all necessary block data is available before starting to sync
2026-02-20 15:58:48 -08:00
init
log: Print warning about privacy-sensitive log info unconditionally
2026-01-27 13:08:50 +01:00
interfaces
ipc mining: break compatibility with existing clients (version bump)
2026-02-12 03:34:08 +01:00
ipc
ipc mining: break compatibility with existing clients (version bump)
2026-02-12 03:34:08 +01:00
kernel
Merge bitcoin/bitcoin#34546: kernel: Avoid duplicating symbols in the kernel library
2026-02-13 11:11:14 +00:00
leveldb
Bump leveldb subtree
2026-02-03 11:19:01 +01:00
logging
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
minisketch
…
node
Merge bitcoin/bitcoin#29770: index: Check all necessary block data is available before starting to sync
2026-02-20 15:58:48 -08:00
policy
Merge bitcoin/bitcoin#34568: mining: Break compatibility with existing IPC mining clients
2026-02-20 11:06:06 +01:00
primitives
txgraph: pass fallback_order to TxGraph (preparation)
2026-02-09 15:55:58 -05:00
qt
qt: Update src/qt/locale/bitcoin_en.xlf after string freeze
2026-02-20 10:31:10 +00:00
rpc
Merge bitcoin/bitcoin#34615: mempool: expose optimality of mempool to log / rpc
2026-02-23 17:10:20 +01:00
script
Merge bitcoin/bitcoin#34141: miniscript: Use Func and Expr when parsing keys, hashes, and locktimes
2026-02-21 12:18:56 +01:00
secp256k1
Update secp256k1 subtree to latest master
2026-02-02 15:21:14 +00:00
support
kernel: avoid potential duplicate object in shared library/binary
2026-02-13 08:50:50 +01:00
test
Merge bitcoin/bitcoin#34141: miniscript: Use Func and Expr when parsing keys, hashes, and locktimes
2026-02-21 12:18:56 +01:00
univalue
ci, iwyu: Fix warnings in src/univalue and treat them as errors
2026-01-31 10:41:50 +00:00
util
Merge bitcoin/bitcoin#34577: http: fix submission during shutdown race
2026-02-19 12:41:12 -08:00
wallet
Merge bitcoin/bitcoin#34141: miniscript: Use Func and Expr when parsing keys, hashes, and locktimes
2026-02-21 12:18:56 +01:00
zmq
ci, iwyu: Fix warnings in src/zmq and treat them as errors
2026-01-29 14:38:35 +00:00
.clang-format
ci, iwyu: Fix warnings in src/zmq and treat them as errors
2026-01-29 14:38:35 +00:00
.clang-tidy
doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false
2026-02-06 08:37:19 +01:00
addrdb.cpp
…
addrdb.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addrman_impl.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
addrman.cpp
refactor: Unify asmap version calculation and naming
2026-01-20 23:45:29 +01:00
addrman.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
arith_uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
arith_uint256.h
…
attributes.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Add Handle/View pattern for BlockValidationState
2026-01-21 19:40:25 +05:30
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoin.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockencodings.cpp
log,blocks: avoid ComputeTotalSize and GetHash work when logging is disabled
2026-01-19 20:20:13 +01:00
blockencodings.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chain.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
chain.h
validation: remove BLOCK_FAILED_MASK
2026-02-17 21:40:46 +05:30
chainparams.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chainparams.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsbase.cpp
…
chainparamsbase.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsseeds.h
…
checkqueue.h
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
clientversion.cpp
…
clientversion.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cluster_linearize.h
clusterlin: inline GetReachable into Deactivate (optimization)
2026-02-17 09:04:36 -05:00
CMakeLists.txt
Merge bitcoin/bitcoin#24539: Add a "tx output spender" index
2026-02-20 09:27:17 +01:00
coins.cpp
Merge bitcoin/bitcoin#34165: coins: don't mutate main cache when connecting block
2026-02-19 22:10:41 -05:00
coins.h
Merge bitcoin/bitcoin#34165: coins: don't mutate main cache when connecting block
2026-02-19 22:10:41 -05:00
compressor.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
compressor.h
…
core_io.cpp
Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)
2026-02-09 13:32:28 +00:00
core_io.h
refactor: [move-only] Merge core_io module
2026-01-19 12:57:16 +01:00
core_memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cuckoocache.h
…
dbwrapper.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
dbwrapper.h
refactor: Use SpanReader over DataStream
2026-02-02 18:42:44 +01:00
deploymentinfo.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentinfo.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
deploymentstatus.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentstatus.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
dummywallet.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
external_signer.cpp
util: Remove brittle and confusing sp::Popen(std::string)
2026-02-17 12:55:26 +01:00
external_signer.h
util: Remove brittle and confusing sp::Popen(std::string)
2026-02-17 12:55:26 +01:00
flatfile.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
flatfile.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
hash.cpp
…
hash.h
…
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
httprpc.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
httpserver.cpp
Merge bitcoin/bitcoin#34577: http: fix submission during shutdown race
2026-02-19 12:41:12 -08:00
httpserver.h
http: replace WorkQueue and threads handling for ThreadPool
2026-01-30 16:17:12 -05:00
i2p.cpp
log: Remove brittle and confusing LogPrintLevel
2025-12-13 13:43:24 +01:00
i2p.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
indirectmap.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
init.cpp
Merge bitcoin/bitcoin#29770: index: Check all necessary block data is available before starting to sync
2026-02-20 15:58:48 -08:00
init.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key_io.cpp
…
key_io.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key.cpp
…
key.h
…
logging.cpp
logging: Move message formatting to util/log.h
2026-02-02 17:22:31 +00:00
logging.h
logging: Move message formatting to util/log.h
2026-02-02 17:22:31 +00:00
mapport.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
mapport.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
merkleblock.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
merkleblock.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
musig.cpp
…
musig.h
…
net_permissions.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_permissions.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_processing.cpp
rpc: Add abortprivatebroadcast
2026-02-11 19:46:19 -05:00
net_processing.h
rpc: Add abortprivatebroadcast
2026-02-11 19:46:19 -05:00
net_types.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_types.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net.cpp
Merge bitcoin/bitcoin#34483: refactor: Use SpanReader over DataStream
2026-02-06 18:00:18 -08:00
net.h
Merge bitcoin/bitcoin#34511: test: fully reset the state of CConnman in tests
2026-02-13 11:17:26 +00:00
netaddress.cpp
…
netaddress.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
netbase.cpp
Modernize GetBindAddress()
2026-01-22 10:35:14 -05:00
netbase.h
Merge bitcoin/bitcoin#34242: Prepare string and net utils for future HTTP operations
2026-01-23 13:25:42 +01:00
netgroup.cpp
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netgroup.h
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netmessagemaker.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
noui.cpp
noui: Remove always empty caption while formatting
2026-01-14 19:39:01 +01:00
noui.h
refactor: Remove empty caption from ThreadSafeMessageBox
2026-01-14 19:36:14 +01:00
outputtype.cpp
…
outputtype.h
…
pow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
pow.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
prevector.h
…
private_broadcast.cpp
net: Add PrivateBroadcast::GetBroadcastInfo
2026-02-11 19:46:12 -05:00
private_broadcast.h
net: Add PrivateBroadcast::GetBroadcastInfo
2026-02-11 19:46:12 -05:00
protocol.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
protocol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
psbt.cpp
refactor: Use SpanReader over DataStream
2026-02-06 07:56:57 +01:00
psbt.h
refactor: Avoid copies by using const references or by move-construction
2026-01-14 23:03:47 +01:00
pubkey.cpp
…
pubkey.h
…
random.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
random.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
randomenv.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
randomenv.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
rest.cpp
Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)
2026-02-09 13:32:28 +00:00
rest.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
semaphore_grant.h
…
serialize.h
refactor: Use empty() over eof() in the streams interface
2026-02-02 17:55:10 +01:00
signet.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
signet.h
kernel: Remove some unnecessary non-kernel includes
2025-12-21 10:24:09 +01:00
span.h
…
streams.cpp
…
streams.h
Merge bitcoin/bitcoin#34465: refactor: separate log generation from log handling
2026-02-07 23:01:17 +01:00
sync.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
sync.h
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
threadsafety.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
tinyformat.h
…
torcontrol.cpp
refactor: Use std::bind_front over std::bind
2026-01-20 15:30:46 +01:00
torcontrol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
txdb.cpp
validation: Use dirty entry count in flush warnings and disk space checks
2026-02-08 08:23:37 +01:00
txdb.h
Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void
2026-01-02 16:49:23 -08:00
txgraph.cpp
txgraph: use fallback order to sort chunks (feature)
2026-02-09 15:55:58 -05:00
txgraph.h
txgraph: pass fallback_order to TxGraph (preparation)
2026-02-09 15:55:58 -05:00
txmempool.cpp
mempool: log if we detect a non-optimal mempool
2026-02-20 09:19:24 -05:00
txmempool.h
Rework CTxMemPool::GetChildren() to not use epochs
2026-01-22 21:51:13 -05:00
txrequest.cpp
Fix compilation for old Boost versions
2025-12-18 22:38:02 +01:00
txrequest.h
doc: fix double-word typos in comments
2025-12-30 12:12:26 -08:00
uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
uint256.h
…
undo.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
validation.cpp
Merge bitcoin/bitcoin#34568: mining: Break compatibility with existing IPC mining clients
2026-02-20 11:06:06 +01:00
validation.h
Merge bitcoin/bitcoin#34568: mining: Break compatibility with existing IPC mining clients
2026-02-20 11:06:06 +01:00
validationinterface.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
validationinterface.h
refactor: Convert ChainstateRole enum to struct
2025-12-12 06:49:59 -04:00
versionbits_impl.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
versionbits.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
versionbits.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
walletinitinterface.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00