ab8a7af742
c462e54f9dtest: don't always assert NUM_PRIVATE_BROADCAST_PER_TX broadcasts (Vasil Dimov)3710566305test: move abortprivatebroadcast test at the end (Vasil Dimov) Pull request description: _test: move abortprivatebroadcast test at the end_ The piece of `p2p_private_broadcast.py` which tests the correctness of `abortprivatebroadcast` issues a new `sendrawtransaction` call. That call schedules up to 3 new connections: peer=13, peer=14 and possibly peer=15 before it gets aborted. These up to 3 in-the-process-of-opening private broadcast connections have `CNode::m_connected` set early - when the `CNode` object is created. Later in the test the mock time is advanced by 20 minutes and those "old" connections pick a transaction for rebroadcast but that triggers `PRIVATE_BROADCAST_MAX_CONNECTION_LIFETIME` immediately: ``` 2026-02-21T13:28:14.209766Z [privbcast] [net.cpp:4006] [CNode] [net] Added connection peer=20 2026-02-21T13:28:14.309792Z (mocktime: 2026-02-21T13:48:14Z) [msghand] [net.cpp:4074] [PushMessage] [net] sending inv (37 bytes) peer=20 2026-02-21T13:28:14.309801Z (mocktime: 2026-02-21T13:48:14Z) [msghand] [net_processing.cpp:5745] [SendMessages] [privatebroadcast] Disconnecting: did not complete the transaction send within 180 seconds, peer=20 ``` This prematurely stops the private broadcast connection and results in a failure like: ``` AssertionError: ... not({} == {'ping': 1, 'tx': 1}) ``` --- _test: don't always assert NUM_PRIVATE_BROADCAST_PER_TX broadcasts_ In `p2p_private_broadcast.py` in the function `check_broadcasts()` we should assert that the broadcast was done to `broadcasts_to_expect` peers, not to `NUM_PRIVATE_BROADCAST_PER_TX`. This is because in the "Basic" test we check the first broadcast manually because it is done to `nodes[1]` and then check the other two by `check_broadcasts(..., NUM_PRIVATE_BROADCAST_PER_TX - 1, ...)`. The first broadcast might not have fully concluded by the time we call `check_broadcasts()` to check the remaining 2. Demanding always `NUM_PRIVATE_BROADCAST_PER_TX` can lead to: ``` Traceback (most recent call last): File "/home/vd/gh/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 142, in main self.run_test() ~~~~~~~~~~~~~^^ File "/tmp/build/clang22/test/functional/p2p_private_broadcast.py", line 347, in run_test self.check_broadcasts("Basic", txs[0], NUM_PRIVATE_BROADCAST_PER_TX - 1, NUM_INITIAL_CONNECTIONS + 1) ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/build/clang22/test/functional/p2p_private_broadcast.py", line 313, in check_broadcasts assert_greater_than_or_equal(sum(1 for p in peers if "received" in p), NUM_PRIVATE_BROADCAST_PER_TX) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/vd/gh/bitcoin/bitcoin/test/functional/test_framework/util.py", line 94, in assert_greater_than_or_equal raise AssertionError("%s < %s" % (str(thing1), str(thing2))) AssertionError: 2 < 3 ``` ACKs for top commit: l0rinc: ACKc462e54f9dachow101: ACKc462e54f9dandrewtoth: ACKc462e54f9dTree-SHA512: 0de8d0eae079eeedc3bfad39df8129a8fa0d7734bdc03b4fb3e520a2f13a187d68118ffc210556af125d634f0ff51a1b081b34a023ac68a1c6a0caf541cecb91
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.