mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-10 05:57:59 +01:00

Files

fanquake b627924300 Merge bitcoin/bitcoin#26681 : contrib: Bugfix for checking bad dns seeds without casting in makeseeds.py

3cc989da5c Fix checking bad dns seeds without casting (Yusuf Sahin HAMZA)

Pull request description:

  - Since seed lines comes with `str` type, comparing `good` column directly with **0** (`int` type) in the if statement was not working at all. This is fixed by casting `int` type to the values in the `good` column of seeds text file.
  - Lines that starts with comment in the seeds text file are now ignored.
  - If statement for checking bad seeds are moved to the top of the `parseline` function as if a seed is bad; there is no point of going forward from there.

  Since this bug-fix eliminates bad seeds over **550k** in the first place, in my case; particular job for parsing all seeds speed is up by **600%** and whole script's speed is up by **%30**.

  Note that **stats** in the terminal are not going to include bad seeds after this fix, which would be the same if this bug were never there before.

ACKs for top commit:
  achow101:
    ACK 3cc989da5c
  jonatack:
    ACK 3cc989da5c

Tree-SHA512: 13c82681de4d72de07293f0b7f09721ad8514a2ad99b0584d1c94fa5f2818821df2000944f9514d6a222a5dccc82856d16c8c05aa36d905cfa7d4610c629fd38

2023-04-20 10:04:47 +01:00

.gitignore

contrib: Use asmap for ASN lookup in makeseeds

2022-05-31 11:57:49 +02:00

asmap.py

doc: typo fix

2022-06-18 18:34:50 +02:00

generate-seeds.py

script, test: fix python linter E275 errors with flake8 5.0.4

2023-01-03 10:59:56 -08:00

makeseeds.py

Merge bitcoin/bitcoin#26681 : contrib: Bugfix for checking bad dns seeds without casting in makeseeds.py

2023-04-20 10:04:47 +01:00

nodes_main_manual.txt

net: update manual hardcoded mainnet seeds for 24.x

2022-08-24 00:00:52 +02:00

nodes_main.txt

net: update hardcoded mainnet seeds for 24.x

2022-08-24 00:04:00 +02:00

nodes_test.txt

contrib: update testnet torv3 hardcoded seeds

2022-08-28 14:34:49 +02:00

README.md

contrib: make DNS seeds file an argument in CLI

2022-12-19 07:20:14 -03:00

README.md

Seeds

Utility to generate the seeds.txt list that is compiled into the client (see src/chainparamsseeds.h and other utilities in contrib/seeds).

Be sure to update PATTERN_AGENT in makeseeds.py to include the current version, and remove old versions as necessary (at a minimum when GetDesirableServiceFlags changes its default return value, as those are the services which seeds are added to addrman with).

The seeds compiled into the release are created from sipa's DNS seed and AS map data. Run the following commands from the /contrib/seeds directory:

curl https://bitcoin.sipa.be/seeds.txt.gz | gzip -dc > seeds_main.txt
curl https://bitcoin.sipa.be/asmap-filled.dat > asmap-filled.dat
python3 makeseeds.py -a asmap-filled.dat -s seeds_main.txt > nodes_main.txt
cat nodes_main_manual.txt >> nodes_main.txt
python3 generate-seeds.py . > ../../src/chainparamsseeds.h