mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00

Files

Ava Chow 011a895a82 Merge bitcoin/bitcoin#29015 : kernel: Streamline util library

c7376babd1 doc: Clarify distinction between util and common libraries in libraries.md (Ryan Ofsky)
4f74c59334 util: Move util/string.h functions to util namespace (Ryan Ofsky)
4d05d3f3b4 util: add TransactionError includes and namespace declarations (Ryan Ofsky)
680eafdc74 util: move fees.h and error.h to common/messages.h (Ryan Ofsky)
02e62c6c9a common: Add PSBTError enum (Ryan Ofsky)
0d44c44ae3 util: move error.h TransactionError enum to node/types.h (Ryan Ofsky)
9bcce2608d util: move spanparsing.h to script/parsing.h (Ryan Ofsky)
6dd2ad4792 util: move spanparsing.h Split functions to string.h (Ryan Ofsky)
23cc8ddff4 util: move HexStr and HexDigit from util to crypto (TheCharlatan)
6861f954f8 util: move util/message to common/signmessage (Ryan Ofsky)
cc5f29fbea build: move memory_cleanse from util to crypto (Ryan Ofsky)
5b9309420c build: move chainparamsbase from util to common (Ryan Ofsky)
ffa27af24d test: Add check-deps.sh script to check for unexpected library dependencies (Ryan Ofsky)

Pull request description:

  Remove `fees.h`, `errors.h`, and `spanparsing.h` from the util library. Specifically:

  - Move `Split` functions from `util/spanparsing.h` to `util/string.h`, using `util` namespace for clarity.
  - Move remaining spanparsing functions to `script/parsing.h` since they are used for descriptor and miniscript parsing.
  - Combine `util/fees.h` and `util/errors.h` into `common/messages.h` so there is a place for simple functions that generate user messages to live, and these functions are not part of the util library.

  Motivation for this change is that the util library is a dependency of the kernel, and we should remove functionality from util that shouldn't be called by kernel code or kernel applications. These changes should also improve code organization and make functions easier to discover. Some of these same moves are (or were) part of #28690, but did not help with code organization, or made it worse, so it is better to move them and clean them up in the same PR so code only has to change one time.

ACKs for top commit:
  achow101:
    ACK c7376babd1
  TheCharlatan:
    Re-ACK c7376babd1
  hebasto:
    re-ACK c7376babd1.

Tree-SHA512: 5bcef16c1255463b1b69270548711e7ff78ca0dd34e300b95e3ca1ce52ceb34f83d9ddb2839e83800ba36b200de30396e504bbb04fa02c6d0c24a16d06ae523d

2024-06-12 17:12:54 -04:00

abort.cpp

node: Make translations of fatal errors consistent

2024-03-21 16:40:22 +01:00

abort.h

node: Make translations of fatal errors consistent

2024-03-21 16:40:22 +01:00

blockmanager_args.cpp

kernel: Add less confusing reindex options

2024-06-07 19:17:11 +02:00

blockmanager_args.h

Add [[nodiscard]] where ignoring a Result return type is an error

2023-05-29 13:12:45 +02:00

blockstorage.cpp

blockman: Replace m_reindexing with m_blockfiles_indexed

2024-06-07 19:18:46 +02:00

blockstorage.h

blockman: Replace m_reindexing with m_blockfiles_indexed

2024-06-07 19:18:46 +02:00

caches.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

caches.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

chainstate.cpp

blockman: Replace m_reindexing with m_blockfiles_indexed

2024-06-07 19:18:46 +02:00

chainstate.h

kernel: Add less confusing reindex options

2024-06-07 19:17:11 +02:00

chainstatemanager_args.cpp

validation: allow to specify frequency for -checkblockindex

2024-04-26 13:31:28 -04:00

chainstatemanager_args.h

refactor: Move {MAX,DEFAULT}_SCRIPTCHECK_THREADS constants

2023-10-03 10:52:17 +01:00

coin.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

coin.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coins_view_args.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

coins_view_args.h

refactor, txdb: Add CoinsViewOptions struct

2023-02-10 04:39:11 -04:00

connection_types.cpp

net: expose transport types/session IDs of connections in RPC and logs

2023-10-02 18:11:11 -04:00

connection_types.h

net: expose transport types/session IDs of connections in RPC and logs

2023-10-02 18:11:11 -04:00

context.cpp

kernel: Remove key module from kernel library

2024-05-09 15:56:08 +02:00

context.h

kernel: Remove key module from kernel library

2024-05-09 15:56:08 +02:00

database_args.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

database_args.h

refactor, dbwrapper: Add DBParams and DBOptions structs

2023-02-10 04:39:11 -04:00

eviction.cpp

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

eviction.h

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

interface_ui.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

interface_ui.h

Add InitError(error, details) overload

2023-02-28 12:04:47 -05:00

interfaces.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

kernel_notifications.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

kernel_notifications.h

node: Make translations of fatal errors consistent

2024-03-21 16:40:22 +01:00

mempool_args.cpp

util: move fees.h and error.h to common/messages.h

2024-05-16 10:16:08 -05:00

mempool_args.h

refactor: Replace std::optional<bilingual_str> with util::Result

2023-05-24 08:55:47 -04:00

mempool_persist_args.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

mempool_persist_args.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

miner.cpp

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

miner.h

[refactor] rewrite BlockAssembler inBlock and failedTx as sets of txids

2023-11-10 16:44:45 +01:00

mini_miner.cpp

[refactor] Miniminer var cached_descendants to descendants

2023-11-07 08:56:43 -06:00

mini_miner.h

[refactor] updating miniminer comments to be more accurate

2023-11-08 14:45:18 -06:00

minisketchwrapper.cpp

Use steady clock in SeedStrengthen and FindBestImplementation

2023-03-02 14:48:28 +01:00

minisketchwrapper.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

peerman_args.cpp

Merge bitcoin/bitcoin#28149 : net processing: clamp PeerManager::Options user input

2023-08-09 14:26:03 +02:00

peerman_args.h

[net processing] Introduce PeerManager options

2023-07-24 18:30:59 +02:00

protocol_version.h

Rename version.h to node/protocol_version.h

2023-11-30 11:28:31 +01:00

psbt.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

psbt.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

README.md

…

timeoffsets.cpp

Add TimeOffsets helper class

2024-04-10 17:01:27 +02:00

timeoffsets.h

Add TimeOffsets helper class

2024-04-10 17:01:27 +02:00

transaction.cpp

util: add TransactionError includes and namespace declarations

2024-05-16 10:16:08 -05:00

transaction.h

util: move fees.h and error.h to common/messages.h

2024-05-16 10:16:08 -05:00

txreconciliation.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

txreconciliation.h

[net processing] Move -txreconciliation to PeerManager::Options

2023-07-24 18:35:28 +02:00

types.h

util: add TransactionError includes and namespace declarations

2024-05-16 10:16:08 -05:00

utxo_snapshot.cpp

lint: remove /* Continued */ markers from codebase

2023-08-03 17:52:24 +01:00

utxo_snapshot.h

assumeutxo: Add network magic ctor param to SnapshotMetadata

2024-05-24 18:44:02 +02:00

validation_cache_args.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

validation_cache_args.h

validationcaches: Add and use ValidationCacheSizes

2022-08-03 12:03:27 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.