merge-script c20a5ce106 Merge bitcoin/bitcoin#31901: contrib: Add deterministic-unittest-coverage ...

fa99c3b544 test: Exclude SeedStartup from coverage counts (MarcoFalke)
fa579d663d contrib: Add deterministic-unittest-coverage (MarcoFalke)
fa3940b1cb contrib: deterministic-fuzz-coverage fixups (MarcoFalke)
faf905b9b6 doc: Remove unused -fPIC (MarcoFalke)
fa1e0a7228 gitignore: target/ (MarcoFalke)

Pull request description:

  The `contrib/devtools/test_deterministic_coverage.sh` script is problematic:

  * It is written in bash. This can lead to issues when running with the ancient bash version shipped by macOS by default, or can lead to other compatibility issues, such as https://github.com/bitcoin/bitcoin/pull/31588#discussion_r1946784827. Also, pipefail isn't set, so IO errors may be silently ignored.
  * It is based on gcov. This can lead to issues, such as https://github.com/bitcoin/bitcoin/pull/31588#pullrequestreview-2602169248 (possibly due to prefix-map), or https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2646395385 (gcovr processing error), or https://github.com/bitcoin/bitcoin/pull/31588#pullrequestreview-2605954001 (gcovr assertion error).
  * The script is severely outdated, with the last update to `NON_DETERMINISTIC_TESTS` being in the prior decade.

  Instead of patching around all issues one-by-one, just provide a fresh rewrite, based on the recently added `deterministic-fuzz-coverage` tool based on clang, llvm-cov, and llvm-profdata. (Initial feedback indicates that this is a more promising attempt: https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2649356408 and https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2649354598).

  The new tool also sets `RANDOM_CTX_SEED=21` as suggested by hodlinator in https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2650784726.

ACKs for top commit:
  Prabhat1308:
    Concept ACK [`fa99c3b`](fa99c3b544)
  hodlinator:
    re-ACK fa99c3b544
  brunoerg:
    light ACK fa99c3b544
  dergoegge:
    tACK fa99c3b544
  janb84:
    Concept ACK [fa99c3b](fa99c3b544)

Tree-SHA512: 491d5e6413d929395a5c7caea54817bdc1a0e00562c9728a374d4e92f2e2017dba4a770ecdb2e7317e049df9fdeb390d83c90dff9aa5709f97aa3f6a0e70cdb4

2025-03-13 12:30:32 +08:00

..

util

…

addition_overflow.cpp

…

addrman.cpp

…

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

…

base_encode_decode.cpp

…

bech32.cpp

…

bip324.cpp

…

bitdeque.cpp

…

bitset.cpp

…

block_header.cpp

…

block_index.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

cluster_linearize.cpp

…

CMakeLists.txt

…

coins_view.cpp

…

coinscache_sim.cpp

…

connman.cpp

…

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

…

feeratediagram.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

test: Exclude SeedStartup from coverage counts

2025-02-25 10:15:00 +01:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

headerssync.cpp

…

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

…

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

…

miniscript.cpp

…

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

…

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

overflow.cpp

…

p2p_handshake.cpp

…

p2p_headers_presync.cpp

…

p2p_transport_serialization.cpp

…

package_eval.cpp

…

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

…

pcp.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

…

process_messages.cpp

…

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

…

rolling_bloom_filter.cpp

…

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_parsing.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

string.cpp

…

strprintf.cpp

…

system.cpp

…

timeoffsets.cpp

…

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

…

txdownloadman.cpp

…

txorphan.cpp

fuzz: add basic TxOrphanage::EraseForBlock cov

2025-02-20 14:00:21 -05:00

txrequest.cpp

…

util.cpp

…

util.h

…

utxo_snapshot.cpp

…

utxo_total_supply.cpp

…

validation_load_mempool.cpp

…

vecdeque.cpp

…

versionbits.cpp

…