Hodlinator b5e91e946c wallet: Remove CoinsResult::Clear() ...

Instead we fully reset CoinsResult-instances without forgetting any fields.

Fixes: https://github.com/bitcoin/bitcoin/issues/35449

Variant resetting the other fields in Clear():
₿ hyperfine --warmup 2 "./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test"
Benchmark 1: ./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test
  Time (mean ± σ):      4.289 s ±  0.008 s    [User: 4.252 s, System: 0.027 s]
  Range (min … max):    4.279 s …  4.301 s    10 runs

This variant:
₿ hyperfine --warmup 2 "./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test"
Benchmark 1: ./build/bin/test_bitcoin -t coinselector_tests/knapsack_solver_test
  Time (mean ± σ):      4.279 s ±  0.005 s    [User: 4.244 s, System: 0.026 s]
  Range (min … max):    4.271 s …  4.287 s    10 runs

2026-06-03 21:40:48 +02:00

77 KiB

Raw Blame History

View Raw