mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-01 08:24:21 +01:00

Files

merge-script df8bf65745 Merge bitcoin/bitcoin#31483 : kernel: Move kernel-related cache constants to kernel cache

2a92702baf init: Use size_t consistently for cache sizes (TheCharlatan)
65cde3621d kernel: Move default cache constants to caches (TheCharlatan)
8826cae285 kernel: Move non-kernel db cache size constants (TheCharlatan)
e758b26b85 kernel: Move kernel-specific cache size options to kernel (TheCharlatan)
d5e2c4a409 fuzz: Add fuzz test for checked and saturating add and left shift (TheCharlatan)
c03a2795a8 util: Add integer left shift helpers (TheCharlatan)
8bd5f8a38c [refactor] init: Simplify coinsdb cache calculation (TheCharlatan)
5db7d4d3d2 doc: Correct docstring describing max block tree db cache (TheCharlatan)

Pull request description:

  Carrying non-kernel related fields in the cache sizes for the indexes is confusing for kernel library users. The cache sizes are set currently with magic numbers in bitcoin-chainstate. The comments for the cache size calculations are not completely clear. The constants for the cache sizes are also currently in `txdb.h`, which is not an ideal place for holding all cache size related constants.

  Solve these things by moving the kernel-specific cache size fields to their own struct and moving the constants to either the node or the kernel cache sizes.

  This slightly changes the way the cache is allocated if (and only if) the txindex and/or blockfilterindex is used. Since they are now given precedence over the block tree db cache, this results in a bit less cache being allocated to the block tree db, coinsdb and coins caches. The effect is negligible though, i.e. cache sizes with default dbcache reported through the logs are:

  master:
  ```
  Cache configuration:
  * Using 2.0 MiB for block index database
  * Using 56.0 MiB for transaction index database
  * Using 49.0 MiB for basic block filter index database
  * Using 8.0 MiB for chain state database
  * Using 335.0 MiB for in-memory UTXO set (plus up to 286.1 MiB of unused mempool space)
  ```

  this PR:
  ```
  Cache configuration:
  * Using 2.0 MiB for block index database
  * Using 56.2 MiB for transaction index database
  * Using 49.2 MiB for basic block filter index database
  * Using 8.0 MiB for chain state database
  * Using 334.5 MiB for in-memory UTXO set (plus up to 286.1 MiB of unused mempool space)
  ```

  ---
  This PR is part of the [libbitcoinkernel project](https://github.com/bitcoin/bitcoin/issues/27587).

ACKs for top commit:
  stickies-v:
    re-ACK 2a92702baf
  ryanofsky:
    Code review ACK 2a92702baf. Changes since last review are fixing size options to use size_t instead of int64_t again, simplifying CheckedLeftShift more, and making other minor suggested cleanups
  hodlinator:
    re-ACK 2a92702baf

Tree-SHA512: 98376eaa0660b1b8c096a5ce1f3e7c8c30e7cd6644de36856c2d3e573108cfc9473c93ebb3952b7881047b5ae6c85c5b096e6726f30f35be58b98eca07c8c785

2025-01-16 15:04:58 +00:00

abort.cpp

…

abort.h

…

blockmanager_args.cpp

…

blockmanager_args.h

…

blockstorage.cpp

…

blockstorage.h

…

caches.cpp

init: Use size_t consistently for cache sizes

2025-01-15 15:44:56 +01:00

caches.h

init: Use size_t consistently for cache sizes

2025-01-15 15:44:56 +01:00

chainstate.cpp

init: Use size_t consistently for cache sizes

2025-01-15 15:44:56 +01:00

chainstate.h

kernel: Move kernel-specific cache size options to kernel

2025-01-15 15:44:16 +01:00

chainstatemanager_args.cpp

…

chainstatemanager_args.h

…

coin.cpp

…

coin.h

…

coins_view_args.cpp

…

coins_view_args.h

…

connection_types.cpp

…

connection_types.h

…

context.cpp

…

context.h

…

database_args.cpp

…

database_args.h

…

eviction.cpp

…

eviction.h

…

interface_ui.cpp

…

interface_ui.h

…

interfaces.cpp

…

kernel_notifications.cpp

…

kernel_notifications.h

…

mempool_args.cpp

…

mempool_args.h

…

mempool_persist_args.cpp

…

mempool_persist_args.h

…

mempool_persist.cpp

…

mempool_persist.h

…

miner.cpp

…

miner.h

…

mini_miner.cpp

…

mini_miner.h

…

minisketchwrapper.cpp

…

minisketchwrapper.h

…

peerman_args.cpp

…

peerman_args.h

…

protocol_version.h

…

psbt.cpp

…

psbt.h

…

README.md

…

timeoffsets.cpp

…

timeoffsets.h

…

transaction.cpp

…

transaction.h

…

txdownloadman_impl.cpp

…

txdownloadman_impl.h

…

txdownloadman.h

…

txreconciliation.cpp

…

txreconciliation.h

…

types.h

…

utxo_snapshot.cpp

…

utxo_snapshot.h

…

warnings.cpp

…

warnings.h

…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.