fanquake 505ba39665 Merge bitcoin/bitcoin#22910: net: Encapsulate asmap in NetGroupManager ...

36f814c0e8 [netgroupman] Remove NetGroupManager::GetAsmap() (John Newbery)
4709fc2019 [netgroupman] Move asmap checksum calculation to NetGroupManager (John Newbery)
1b978a7e8c [netgroupman] Move GetMappedAS() and GetGroup() logic to NetGroupManager (John Newbery)
ddb4101e63 [net] Only use public CNetAddr functions and data in GetMappedAS() and GetGroup() (John Newbery)
6b2268162e [netgroupman] Add GetMappedAS() and GetGroup() (John Newbery)
19431560e3 [net] Move asmap into NetGroupManager (John Newbery)
17c24d4580 [init] Add netgroupman to node.context (John Newbery)
9b3836710b [build] Add netgroup.cpp|h (John Newbery)

Pull request description:

  The asmap data is currently owned by addrman, but is used by both addrman and connman. #22791 made the data const and private (so that it can't be updated by other components), but it is still passed out of addrman as a reference to const, and used by `CNetAddress` to calculate the group and AS of the net address.

  This RFC PR proposes to move all asmap data and logic into a new `NetGroupManager` component. This is initialized at startup, and the client components addrman and connman simply call `NetGroupManager::GetGroup(const CAddress&)` and `NetGroupManager::GetMappedAS(const CAddress&)` to get the net group and AS of an address.

ACKs for top commit:
  mzumsande:
    Code Review ACK 36f814c0e8
  jnewbery:
    CI failure seems spurious. I rebased onto latest master to trigger a new CI run, but whilst I was doing that, mzumsande ACKed 36f814c0e8, so I've reverted to that.
  dergoegge:
    Code review ACK 36f814c0e8

Tree-SHA512: 244a89cdfd720d8cce679eae5b7951e1b46b37835fccb6bdfa362856761bb110e79e263a6eeee8246140890f3bee2850e9baa7bc14a388a588e0e29b9d275175

2022-04-22 14:43:14 +01:00

..

data

…

.gitignore

…

addrman.cpp

[net] Move asmap into NetGroupManager

2022-04-20 14:29:29 +01:00

base58.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

bech32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bench_bitcoin.cpp

Use GetPathArg where possible

2022-03-02 12:09:27 +01:00

bench.cpp

bench: Represents paths with fs::path instead of std::string

2022-02-04 09:33:41 -05:00

bench.h

bench: Represents paths with fs::path instead of std::string

2022-02-04 09:33:41 -05:00

block_assemble.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

ccoins_caching.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

chacha20.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

chacha_poly_aead.cpp

Do not run functions with necessary side-effects in assert()

2020-12-06 00:48:09 +00:00

checkblock.cpp

Use spans of std::byte in serialize

2022-01-02 11:40:31 +01:00

checkqueue.cpp

bench: Use CCheckQueue local thread pool

2020-09-24 06:55:34 +03:00

coin_selection.cpp

bench: fix incorrect named args in coin_selection bench

2022-03-25 21:27:39 +00:00

crypto_hash.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

data.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

data.h

…

duplicate_inputs.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

examples.cpp

bench: Avoid deprecated use of volatile +=

2022-02-17 17:25:57 +01:00

gcs_filter.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

hashpadding.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

lockedpool.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

logging.cpp

bench: Add logging benchmark

2021-12-15 14:33:59 +01:00

mempool_eviction.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

mempool_stress.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

merkle_root.cpp

Replace current benchmarking framework with nanobench

2020-06-13 12:24:18 +02:00

nanobench.cpp

Replace current benchmarking framework with nanobench

2020-06-13 12:24:18 +02:00

nanobench.h

bench: update nanobench from 4.3.4 to 4.3.6

2021-09-21 11:46:01 +02:00

peer_eviction.cpp

scripted-diff: Rename touched member variables

2021-12-13 13:32:08 +01:00

poly1305.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

prevector.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

rollingbloom.cpp

refactor: Remove deduplication of data in rollingbloom bench

2022-04-06 13:57:31 +01:00

rpc_blockchain.cpp

move-mostly: Make fHavePruned a BlockMan member

2022-04-19 14:34:56 -04:00

rpc_mempool.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

util_time.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

verify_script.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

wallet_balance.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

wallet_loading.cpp

bench: Add a benchmark for wallet loading

2022-04-18 17:02:57 -04:00