highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-06 05:00:12 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
fanquake 1c4f59728c
Merge #19879: [p2p] miscellaneous wtxid followups 
a8a64acaf32ac21feeb885671772282b531ef9a2 [BroadcastTransaction] Remove unsafe move operator (Amiti Uttarwar)
125c0381266e0e05a408f8e1818501ab73d29110 [p2p] Remove dead code (Amiti Uttarwar)
fc66d0a65cdc52a3b259effe0c29b5eafb1b5ff5 [p2p] Check for nullptr before dereferencing pointer (Adam Jonas)
cb79b9dbf4cd06e17c8c65b36bf15c3ea2641de4 [mempool] Revert unbroadcast set to tracking just txid (Amiti Uttarwar)

Pull request description:

  Addresses some outstanding review comments from #18044

  - reverts unbroadcast txids to a set instead of a map (simpler, communicates intent better, takes less space, no efficiency advantages of map)
  - adds safety around two touchpoints (check for nullptr before dereferencing pointer, remove an inaccurate std::move operator)
  - removes some dead code

  Links to comments on wtxid PR: [1](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r460495254) [2](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r460496023) [3](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r463532611)

  thanks to jnewbery & adamjonas for flagging these ! !

ACKs for top commit:
  sdaftuar:
    utACK a8a64acaf32ac21feeb885671772282b531ef9a2
  naumenkogs:
    utACK a8a64acaf32ac21feeb885671772282b531ef9a2
  jnewbery:
    utACK a8a64acaf32ac21feeb885671772282b531ef9a2

Tree-SHA512: 7be669cb30cc17fb9e06b50e636ef7887c6a27354697987e4e4d38dba4b8f50e175647587430cd9bc3295bec01ce8b1e6639a50a4249d8fff9b1ca1b9ead3277
2020-09-16 06:30:57 +08:00
..
coin.cpp
…
coin.h
…
coinstats.cpp
rpc: Add hash_type NONE to gettxoutsetinfo
2020-06-22 01:55:36 +02:00
coinstats.h
rpc: Add hash_type NONE to gettxoutsetinfo
2020-06-22 01:55:36 +02:00
context.cpp
Remove mempool global
2020-09-05 16:24:56 +02:00
context.h
scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager
2020-09-07 11:15:48 +01:00
psbt.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
psbt.h
…
README.md
…
transaction.cpp
[BroadcastTransaction] Remove unsafe move operator
2020-09-04 14:42:59 -07:00
transaction.h
Merge #17509: gui: save and load PSBT
2020-04-23 13:16:23 +12:00
ui_interface.cpp
gui: change combiner for signals to optional_last_value
2020-07-01 21:40:51 +08:00
ui_interface.h
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
utxo_snapshot.h
…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.