46339d29b1test, refactor: Reorder sendtxrcncl tests for better readability (Gleb Naumenko)14263c13f1p2p, refactor: Extend logs for unexpected sendtxrcncl (Gleb Naumenko)87493e112ep2p, test, refactor: Minor code improvements (Gleb Naumenko)00c5dec818p2p: Clarify sendtxrcncl policies (Gleb Naumenko)ac6ee5ba21test: Expand unit and functional tests for txreconciliation (Gleb Naumenko)bc84e24a4fp2p, refactor: Switch to enum class for ReconciliationRegisterResult (Gleb Naumenko)a60f729e29p2p: Drop roles from sendtxrcncl (Gleb Naumenko)6772cbf69ctests: stabilize sendtxrcncl test (Gleb Naumenko) Pull request description: Non-trivial changes include: - Getting rid of roles in `sendtxrcncl` message (summarized in the [BIP PR](https://github.com/bitcoin/bips/pull/1376)); - Disconnect the peer if it send `sendtxrcncl` although we are in `blocksonly` and notified the peer with `fRelay=0`; - Don't send `sendtxrcncl` to feeler connections. ACKs for top commit: vasild: ACK46339d29b1ariard: ACK46339d2mzumsande: Code Review ACK46339d29b1Tree-SHA512: b5cc6934b4670c12b7dbb3189e739ef747ee542ec56678bf4e4355bfb481b746d32363c173635685b71969b3fe4bd52b1c8ebd3ea3b35c82044bba69220f6417
src/node/
The src/node/ directory contains code that needs to access node state
(state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar
classes).
Code in src/node/ is meant to be segregated from code in
src/wallet/ and src/qt/, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/,
src/wallet/, or src/qt/ directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/ classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp and
src/txmempool.cpp might be moved there.