MarcoFalke 5e49b2a252 Merge bitcoin/bitcoin#24050: validation: Give m_block_index ownership of CBlockIndexs ...

6c23c41561 refactor: Rewrite AddToBlockIndex with try_emplace (Carl Dong)
c05cf7aa1e style: Modernize range-based loops over m_block_index (Carl Dong)
c2a1655799 style-only: Use using instead of typedef for BlockMap (Carl Dong)
dd79dad175 refactor: Rewrite InsertBlockIndex with try_emplace (Carl Dong)
531dce0347 tests: Remove now-unnecessary manual Unload's (Carl Dong)
bec86ae326 blockstorage: Make m_block_index own CBlockIndex's (Carl Dong)

Pull request description:

  Part of: #24303
  Split off from: #22564

  ```
  Instead of having CBlockIndex's live on the heap, which requires manual
  memory management, have them be owned by m_block_index. This means that
  they will live and die with BlockManager.
  ```

  The second commit demonstrates how this makes calls to `Unload()` to satisfy the address sanitizer unnecessary.

ACKs for top commit:
  ajtowns:
    ACK 6c23c41561
  MarcoFalke:
    re-ACK 6c23c41561 🎨

Tree-SHA512: 81b2b5119be27cc0f8a9457b11da60cc60930315d2a5be36be89fe253d32073ffe622348ff153114b9b3212197bddbc791810913a43811b33cc58e7162bd105b

2022-03-07 13:15:27 +01:00

..

blockchain.cpp

style: Modernize range-based loops over m_block_index

2022-02-22 11:56:49 -05:00

blockchain.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

client.cpp

Merge bitcoin/bitcoin#23706: rpc: getblockfrompeer followups

2022-01-25 18:48:41 +01:00

client.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

external_signer.cpp

doc: Fix RPC result documentation

2021-09-21 11:13:29 +02:00

mining.cpp

doc: Rework generate* doc

2022-02-21 11:02:20 +01:00

mining.h

rpc: create rpc/mining.h, hoist default max tries values to constant

2020-06-01 15:08:36 +02:00

misc.cpp

Replace "can not" with "cannot" in docs, user messages, and tests

2022-02-21 19:07:29 +01:00

net.cpp

Merge bitcoin/bitcoin#22834: net: respect -onlynet= when making outbound connections

2022-03-01 18:32:01 +01:00

protocol.h

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

rawtransaction_util.cpp

Extract CTxIn::MAX_SEQUENCE_NONFINAL constant

2022-01-26 15:10:44 +01:00

rawtransaction_util.h

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

rawtransaction.cpp

Merge bitcoin/bitcoin#24367: User-facing content and codebase doc fixups from transifex translator feedback

2022-02-22 13:08:08 +01:00

register.h

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

request.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

request.h

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

server_util.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

server_util.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

server.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

server.h

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

util.cpp

Move GetAllOutputTypes function from rpc/rawtransaction.cpp to rpc/util.{h|cpp}

2022-02-14 14:34:04 +01:00

util.h

Move GetAllOutputTypes function from rpc/rawtransaction.cpp to rpc/util.{h|cpp}

2022-02-14 14:34:04 +01:00