MacroFake 0d080a183b Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* and src/rpc/net.cpp ...

e71c51b27d refactor: rename command -> message type in comments in the src/net* files (Shashwat)
2b09593bdd scripted-diff: Rename message command to message type (Shashwat)

Pull request description:

  This PR is a follow-up to #24078.

  > a message is not a command, but simply a message of some type

  The first commit covers the message_command variable name and comments not addressed in the original PR in `src/net*` files.
  The second commit goes beyond the original `src/net*` limit of #24078 and does similar changes in the `src/rpc/net.cpp` file.

ACKs for top commit:
  MarcoFalke:
    review ACK e71c51b27d 💥

Tree-SHA512: 24015d132c00f15239e5d3dc7aedae904ae3103a90920bb09e984ff57723402763f697d886322f78e42a0cb46808cb6bc9d4905561dc6ddee9961168f8324b05

2022-05-05 08:37:35 +02:00

..

bench

Merge bitcoin/bitcoin#24852: util: optimize HexStr

2022-05-04 20:36:09 +02:00

common

…

compat

refactor: fix includes in src/compat

2022-04-20 13:51:33 +01:00

config

…

consensus

Merge bitcoin/bitcoin#23536: Enforce Taproot script flags whenever WITNESS is set

2022-03-25 14:11:18 +01:00

crc32c

…

crypto

refactor: Use [[maybe_unused]] attribute

2022-04-05 13:53:09 +02:00

index

Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions allowed by path append operators

2022-05-03 10:39:42 +02:00

init

refactor: fix includes in src/init

2022-04-20 13:51:33 +01:00

interfaces

…

ipc

…

kernel

b-cs: Define G_TRANSLATION_FUN in bitcoinkernel.cpp

2022-04-26 16:30:53 -04:00

leveldb

…

logging

…

minisketch

…

node

blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time

2022-05-03 22:20:31 +02:00

policy

…

primitives

…

qt

Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions allowed by path append operators

2022-05-03 10:39:42 +02:00

rpc

Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* and src/rpc/net.cpp

2022-05-05 08:37:35 +02:00

script

Precomputed hashes are note #16 in BIP341

2022-04-25 11:58:42 -04:00

secp256k1

Update secp256k1 subtree to latest upstream master

2022-04-06 20:20:30 +01:00

support

Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)

2022-04-26 10:41:45 +01:00

test

Merge bitcoin/bitcoin#24852: util: optimize HexStr

2022-05-04 20:36:09 +02:00

univalue

…

util

Merge bitcoin/bitcoin#24933: util: Replace non-threadsafe strerror

2022-05-04 21:08:30 +02:00

wallet

Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions allowed by path append operators

2022-05-03 10:39:42 +02:00

zmq

Remove not needed clang-format off comments

2022-04-25 10:55:07 +02:00

.bear-tidy-config

tidy: enable modernize-use-nullptr

2022-04-26 10:43:33 +01:00

.clang-format

…

.clang-tidy

tidy: add readability-redundant-declaration

2022-05-01 10:39:40 +01:00

addrdb.cpp

Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions allowed by path append operators

2022-05-03 10:39:42 +02:00

addrdb.h

[net] Move asmap into NetGroupManager

2022-04-20 14:29:29 +01:00

addrman_impl.h

[netgroupman] Add GetMappedAS() and GetGroup()

2022-04-20 14:35:52 +01:00

addrman.cpp

[netgroupman] Move asmap checksum calculation to NetGroupManager

2022-04-20 14:35:53 +01:00

addrman.h

[net] Move asmap into NetGroupManager

2022-04-20 14:29:29 +01:00

arith_uint256.cpp

Merge bitcoin/bitcoin#24077: util: Make base_uint::GetHex() and base_uint::SetHex() not depend on uint256

2022-04-14 07:15:22 +02:00

arith_uint256.h

Remove duplicate static_asserts

2022-04-14 19:26:22 +02:00

attributes.h

…

banman.cpp

…

banman.h

…

base58.cpp

scripted-diff: Rename ValidAsCString to ContainsNoNUL

2022-04-27 14:16:35 +02:00

base58.h

…

bech32.cpp

…

bech32.h

…

bitcoin-chainstate.cpp

Merge bitcoin/bitcoin#24322: [kernel 1/n] Introduce initial libbitcoinkernel

2022-04-28 15:14:32 +01:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Merge bitcoin/bitcoin#24632: add (none) in -getinfo Warnings: if no warning returned

2022-04-13 21:49:22 +02:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Use std::string_view throughout util strencodings/string

2022-04-27 14:13:39 +02:00

bitcoin-util-res.rc

…

bitcoin-util.cpp

refactor: remove unused boost header include in bitcoin-util.cpp

2022-03-25 15:30:20 +00:00

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

…

bitcoind-res.rc

…

bitcoind.cpp

util: Replace non-threadsafe strerror

2022-04-28 10:24:06 +02:00

blockencodings.cpp

…

blockencodings.h

…

blockfilter.cpp

…

blockfilter.h

…

chain.cpp

…

chain.h

…

chainparams.cpp

refactor: introduce single-separator split helper SplitString

2022-04-11 22:19:46 +02:00

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

…

clientversion.h

…

coins.cpp

…

coins.h

…

compat.h

compat: remove strnlen back-compat code

2022-03-29 10:15:33 +01:00

compressor.cpp

…

compressor.h

…

core_io.h

refactor: prefer snake case, TxToUniv arg hashBlock renamed block_hash

2022-03-30 20:00:27 +01:00

core_memusage.h

…

core_read.cpp

core_read: Replace boost::split with SplitString

2022-05-04 07:34:47 +02:00

core_write.cpp

refactor: add stdd:: includes to core_write

2022-03-30 20:11:15 +01:00

cuckoocache.h

…

dbwrapper.cpp

refactor: use Span in random.*

2022-03-23 17:36:33 -05:00

dbwrapper.h

…

deploymentinfo.cpp

…

deploymentinfo.h

…

deploymentstatus.cpp

…

deploymentstatus.h

…

dummywallet.cpp

…

external_signer.cpp

…

external_signer.h

…

flatfile.cpp

Disallow more unsafe string->path conversions allowed by path append operators

2022-04-21 12:01:00 -05:00

flatfile.h

…

fs.cpp

util: Replace non-threadsafe strerror

2022-04-28 10:24:06 +02:00

fs.h

Disallow more unsafe string->path conversions allowed by path append operators

2022-04-21 12:01:00 -05:00

hash.cpp

…

hash.h

Squashed 'src/secp256k1/' changes from 0559fc6e41..8746600eec

2022-04-06 20:20:30 +01:00

httprpc.cpp

http: replace boost::split with SplitString

2022-05-04 07:34:48 +02:00

httprpc.h

…

httpserver.cpp

Merge bitcoin/bitcoin#24681: build: Bump libevent minimum version up to 2.1.8

2022-04-06 13:19:36 +01:00

httpserver.h

Merge bitcoin/bitcoin#24681: build: Bump libevent minimum version up to 2.1.8

2022-04-06 13:19:36 +01:00

i2p.cpp

Make DecodeBase{32,64} return optional instead of taking bool*

2022-04-27 14:12:55 +02:00

i2p.h

…

indirectmap.h

…

init.cpp

Merge bitcoin/bitcoin#22235: script: add script to generate example bitcoin.conf

2022-05-04 21:12:56 +02:00

init.h

init: Disable syscall sandbox in the bitcoin-qt process

2022-04-05 13:29:42 +02:00

key_io.cpp

…

key_io.h

…

key.cpp

Merge bitcoin/bitcoin#24213: refactor: use Span in random.*

2022-04-21 16:38:04 +02:00

key.h

…

logging.cpp

Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive

2022-04-05 12:49:48 +02:00

logging.h

Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive

2022-04-05 12:49:48 +02:00

Makefile.am

Merge bitcoin/bitcoin#24933: util: Replace non-threadsafe strerror

2022-05-04 21:08:30 +02:00

Makefile.bench.include

Merge bitcoin/bitcoin#24852: util: optimize HexStr

2022-05-04 20:36:09 +02:00

Makefile.crc32c.include

build: Create .la library for crc32c

2022-04-26 16:25:38 -04:00

Makefile.leveldb.include

build: Create .la library for leveldb

2022-04-26 16:29:35 -04:00

Makefile.minisketch.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

build: Remove vestigial LIBLEVELDB_SSE42

2022-04-11 16:56:34 -04:00

Makefile.qttest.include

build: Remove vestigial LIBLEVELDB_SSE42

2022-04-11 16:56:34 -04:00

Makefile.test_fuzz.include

build: Don't add unrelated libs to LIBTEST_*

2022-04-11 16:56:34 -04:00

Makefile.test_util.include

build: Don't add unrelated libs to LIBTEST_*

2022-04-11 16:56:34 -04:00

Makefile.test.include

Merge bitcoin/bitcoin#24322: [kernel 1/n] Introduce initial libbitcoinkernel

2022-04-28 15:14:32 +01:00

Makefile.univalue.include

…

mapport.cpp

Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)

2022-04-26 10:41:45 +01:00

mapport.h

…

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

net_permissions.cpp

…

net_permissions.h

…

net_processing.cpp

Merge bitcoin/bitcoin#24543: net processing: Move remaining globals into PeerManagerImpl

2022-04-30 11:51:22 +02:00

net_processing.h

[net processing] Move mapNodeState into PeerManagerImpl

2022-04-20 13:33:07 +02:00

net_types.cpp

…

net_types.h

…

net.cpp

Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* and src/rpc/net.cpp

2022-05-05 08:37:35 +02:00

net.h

Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* and src/rpc/net.cpp

2022-05-05 08:37:35 +02:00

netaddress.cpp

tidy: add readability-redundant-declaration

2022-05-01 10:39:40 +01:00

netaddress.h

[netgroupman] Move GetMappedAS() and GetGroup() logic to NetGroupManager

2022-04-20 14:35:52 +01:00

netbase.cpp

scripted-diff: Rename ValidAsCString to ContainsNoNUL

2022-04-27 14:16:35 +02:00

netbase.h

net: use Sock::SetSockOpt() instead of standalone SetSocketNoDelay()

2022-04-15 09:39:25 +02:00

netgroup.cpp

[netgroup] Use nStartByte as offset for the last byte of the group

2022-04-25 15:09:14 +02:00

netgroup.h

[netgroupman] Remove NetGroupManager::GetAsmap()

2022-04-20 14:35:53 +01:00

netmessagemaker.h

…

noui.cpp

…

noui.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

validation: make CScriptCheck and prevector swap member functions noexcept

2022-04-28 20:22:56 +02:00

protocol.cpp

…

protocol.h

…

psbt.cpp

Make DecodeBase{32,64} return optional instead of taking bool*

2022-04-27 14:12:55 +02:00

psbt.h

Make DecodeBase{32,64} always return vector, not string

2022-04-27 14:12:55 +02:00

pubkey.cpp

…

pubkey.h

…

random.cpp

Merge bitcoin/bitcoin#24213: refactor: use Span in random.*

2022-04-21 16:38:04 +02:00

random.h

refactor: use Span in random.*

2022-03-23 17:36:33 -05:00

randomenv.cpp

tidy: add readability-redundant-declaration

2022-05-01 10:39:40 +01:00

randomenv.h

…

rest.cpp

Merge bitcoin/bitcoin#22953: refactor: introduce single-separator split helper (boost::split replacement)

2022-04-26 09:54:49 +01:00

rest.h

…

reverse_iterator.h

…

scheduler.cpp

Pass lifetimebound reference to SingleThreadedSchedulerClient

2022-04-30 09:17:17 +02:00

scheduler.h

Pass lifetimebound reference to SingleThreadedSchedulerClient

2022-04-30 09:17:17 +02:00

serialize.h

scripted-diff: rename BytePtr to AsBytePtr

2022-04-26 09:41:45 +01:00

shutdown.cpp

Guard #include <config/bitcoin-config.h>

2022-05-02 16:41:30 +02:00

shutdown.h

…

signet.cpp

…

signet.h

…

span.h

scripted-diff: rename BytePtr to AsBytePtr

2022-04-26 09:41:45 +01:00

streams.h

…

sync.cpp

…

sync.h

Merge bitcoin/bitcoin#24355: util, refactor: Add UNIQUE_NAME helper macro

2022-04-13 22:59:33 +02:00

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

…

timedata.h

…

tinyformat.h

…

torcontrol.cpp

Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)

2022-04-26 10:41:45 +01:00

torcontrol.h

…

txdb.cpp

Merge bitcoin/bitcoin#24236: Remove utxo db upgrade code

2022-04-05 15:38:14 +02:00

txdb.h

…

txmempool.cpp

Merge bitcoin/bitcoin#23416: doc: Remove fee delta TODO from txmempool.cpp

2022-04-14 09:42:22 +02:00

txmempool.h

…

txorphanage.cpp

…

txorphanage.h

…

txrequest.cpp

…

txrequest.h

…

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions allowed by path append operators

2022-05-03 10:39:42 +02:00

validation.h

Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions allowed by path append operators

2022-05-03 10:39:42 +02:00

validationinterface.cpp

Pass lifetimebound reference to SingleThreadedSchedulerClient

2022-04-30 09:17:17 +02:00

validationinterface.h

…

version.h

…

versionbits.cpp

…

versionbits.h

…

walletinitinterface.h

…

warnings.cpp

…

warnings.h

…