mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-18 22:35:39 +01:00

Files

fanquake 8071ec179d Merge bitcoin/bitcoin#21789 : refactor: Remove ::Params() global from CChainState

fa0d9211ef refactor: Remove chainparams arg from CChainState member functions (MarcoFalke)
fa38947125 refactor: Remove ::Params() global from inside CChainState member functions (MarcoFalke)

Pull request description:

  The `::Params()` global is verbose and confusing. Also it makes tests a bit harder to write because they'd have to mock a global.

  Fix all issues by simply using a member variable that points to the right params.

  (Can be reviewed with `--word-diff-regex=.`)

ACKs for top commit:
  jnewbery:
    ACK fa0d9211ef
  kiminuo:
    utACK fa0d9211
  theStack:
    ACK fa0d9211ef 🍉

Tree-SHA512: 44676b19c9ed471ccb536331d3029bad192d7d50f394fd7b8527ec431452aeec8c4494164b9cf8e16e0123c4463b16be864366c6b599370032c17262625a0356

2021-06-29 11:22:57 +08:00

blockstorage.cpp

refactor: Remove chainparams arg from CChainState member functions

2021-06-13 09:43:54 +02:00

blockstorage.h

add missing atomic include

2021-06-22 11:06:30 +02:00

coin.cpp

scripted-diff: tree-wide: Remove all review-only assertions

2021-06-10 15:05:24 -04:00

coin.h

node: Use mempool from node context instead of global

2019-12-05 14:22:05 -05:00

coinstats.cpp

scripted-diff: tree-wide: Remove all review-only assertions

2021-06-10 15:05:24 -04:00

coinstats.h

index, rpc: Add use_index option for gettxoutsetinfo

2021-04-19 21:11:33 +02:00

context.cpp

validation: Farewell, global Chainstate!

2021-06-10 15:05:25 -04:00

context.h

validation: Farewell, global Chainstate!

2021-06-10 15:05:25 -04:00

interfaces.cpp

script, doc: spelling update

2021-06-23 13:33:18 +02:00

psbt.cpp

Construct and use PrecomputedTransactionData in PSBT signing

2021-06-12 12:25:28 -07:00

psbt.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

README.md

doc: Remove irrelevant link to GitHub

2021-04-06 09:34:21 +02:00

transaction.cpp

scripted-diff: tree-wide: Remove all review-only assertions

2021-06-10 15:05:24 -04:00

transaction.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

ui_interface.cpp

gui: change combiner for signals to optional_last_value

2020-07-01 21:40:51 +08:00

ui_interface.h

scripted-diff: Move ui_interface to the node lib

2020-06-27 11:49:28 -04:00

utxo_snapshot.h

validation: remove nchaintx from assumeutxo metadata

2021-04-26 13:22:37 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.