mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00

Files

fanquake 2ac71d20b2 Merge bitcoin/bitcoin#25595 : Verify PSBT inputs rather than check for fields being empty

e133264c5b Add test for PSBT input verification (Greg Sanders)
d25699280a Verify PSBT inputs rather than check for fields being empty (Greg Sanders)

Pull request description:

  In a few keys spots, PSBT finality is checked by looking for non-empty witness data.

  This complicates a couple things:
  1) Empty data can be valid in certain cases
  2) User may be passed bogus final data by a counterparty during PSBT work happening, and end up with incorrect signatures that they may not be able to check in other contexts if the UTXO doesn't exist yet in chain/mempool, timelocks, etc.

  On the whole I think these heavier checks are worth it in case someone is actually assuming the signatures are correct if our API is saying so.

ACKs for top commit:
  achow101:
    ACK e133264c5b

Tree-SHA512: 9de4fbb0be1257b081781f5df908fd55666e3acd5c4e36beb3b3f2f5a6aed69ff77068c44cde6127e159e773293fd9ced4c0bb47e693969f337e74dc8af030da

2022-10-20 08:13:14 +08:00

blockstorage.cpp

Merge bitcoin/bitcoin#25667 : assumeutxo: snapshot initialization

2022-10-13 10:19:27 -04:00

blockstorage.h

Merge bitcoin/bitcoin#24858 : incorrect blk file size calculation during reindex results in recoverable blk file corruption

2022-10-12 14:13:54 -04:00

caches.cpp

refactor: move DEFAULT_TXINDEX from validation to txindex

2022-10-03 18:19:39 +01:00

caches.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

chainstate.cpp

init: add utxo snapshot detection

2022-09-13 13:30:14 -04:00

chainstate.h

refactor: Fix iwyu on node/chainstate

2022-07-21 20:23:23 +02:00

coin.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

coin.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

connection_types.cpp

[net] Move ConnectionType to its own file

2022-07-06 18:13:53 +02:00

connection_types.h

[net] Move ConnectionType to its own file

2022-07-06 18:13:53 +02:00

context.cpp

init: Initialize globals with kernel::Context's life

2022-06-02 11:40:03 -04:00

context.h

kernel: Introduce empty and unused kernel::Context

2022-05-31 14:18:31 -04:00

eviction.cpp

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

eviction.h

[net] Move eviction logic to its own file

2022-07-06 18:13:54 +02:00

interface_ui.cpp

Make validation interface capable of signalling header presync

2022-08-29 08:10:35 -04:00

interface_ui.h

Make validation interface capable of signalling header presync

2022-08-29 08:10:35 -04:00

interfaces.cpp

refactor: mempool: use CTxMempool::Limits

2022-10-05 13:07:11 +01:00

mempool_args.cpp

Merge bitcoin/bitcoin#25872 : Fix issues when calling std::move(const&)

2022-08-31 08:38:24 +01:00

mempool_args.h

scripted-diff: Move mempool_args to src/node

2022-08-02 15:31:01 +02:00

mempool_persist_args.cpp

DumpMempool: Pass in dump_path, stop using gArgs

2022-07-15 11:30:50 -04:00

mempool_persist_args.h

Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel

2022-07-15 12:26:20 -04:00

miner.cpp

Merge bitcoin/bitcoin#26118 : log: Use steady clock for bench logging

2022-10-10 12:00:34 +02:00

miner.h

scripted-diff: rename CChainState -> Chainstate

2022-09-09 11:47:27 -04:00

minisketchwrapper.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

minisketchwrapper.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

psbt.cpp

Verify PSBT inputs rather than check for fields being empty

2022-10-17 11:13:02 -04:00

psbt.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

README.md

…

transaction.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

refactor: Remove defunct attributes.h includes

2022-05-21 13:54:33 -05:00

txreconciliation.cpp

p2p: Finish negotiating reconciliation support

2022-10-17 12:35:44 +03:00

txreconciliation.h

p2p: Finish negotiating reconciliation support

2022-10-17 12:35:44 +03:00

utxo_snapshot.cpp

init: add utxo snapshot detection

2022-09-13 13:30:14 -04:00

utxo_snapshot.h

init: add utxo snapshot detection

2022-09-13 13:30:14 -04:00

validation_cache_args.cpp

validationcaches: Use size_t for sizes

2022-08-03 12:03:28 -04:00

validation_cache_args.h

validationcaches: Add and use ValidationCacheSizes

2022-08-03 12:03:27 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.