mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-22 07:12:47 +01:00

Files

merge-script 8f0e1f6540 Merge bitcoin/bitcoin#34465 : refactor: separate log generation from log handling

37cc2a2d95 logging: use util/log.h where possible (stickies-v)
bb8e9e7c4c logging: Move message formatting to util/log.h (stickies-v)
001f0a428e move-only: Move logging macros to util/log.h (stickies-v)
94c0adf4e8 move-onlyish: Move logging levels to util/log.h (stickies-v)
56d113cab0 move-only: move logging categories to logging/categories.h (stickies-v)
f5233f7e98 move-only: Move SourceLocation to util/log.h (stickies-v)

Pull request description:

  This is a mostly move-only change. It's a small refactoring that allows logging macros to be used by including a simple `util/log.h` header instead of the full `logging.h` logging implementation. Most of the changes here were cherry-picked from #34374.

  Original motivation for this change was to reduce the size and complexity of #34374 (kernel structured logging PR) and reduce the number of conflicts it causes with other PRs. But this should also make sense as a standalone change to have a clearer separation of concerns between log generation and log handling, and avoid needing to depend on the whole logging framework in call sites that only emit log messages.

  Recommended to review with `--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space`

ACKs for top commit:
  l0rinc:
    diff ACK 37cc2a2d95
  stickies-v:
    re-ACK 37cc2a2d95
  optout21:
    crACK 37cc2a2d95
  sedited:
    ACK 37cc2a2d95

Tree-SHA512: c7a761323ae63f07ad290d4e3766ba1348a132c8cc68a9895fa9ae5c89206599c00646c42ef77223ac757b9d8bfe6c181bead15e7058e4d8966b3bac88a8f950

2026-02-07 23:01:17 +01:00

abort.cpp

…

abort.h

…

blockmanager_args.cpp

…

blockmanager_args.h

…

blockstorage.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

blockstorage.h

Merge bitcoin/bitcoin#34179 : refactor: Enable transparent lookup for setBlockIndexCandidates to remove const_cast

2026-02-02 08:49:02 +01:00

caches.cpp

…

caches.h

…

chainstate.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

chainstate.h

…

chainstatemanager_args.cpp

…

chainstatemanager_args.h

…

coin.cpp

…

coin.h

…

coins_view_args.cpp

…

coins_view_args.h

…

connection_types.cpp

…

connection_types.h

…

context.cpp

…

context.h

…

database_args.cpp

…

database_args.h

…

eviction.cpp

…

eviction.h

…

interface_ui.cpp

refactor: Remove empty caption from ThreadSafeMessageBox

2026-01-14 19:36:14 +01:00

interface_ui.h

refactor: Remove empty caption from ThreadSafeMessageBox

2026-01-14 19:36:14 +01:00

interfaces.cpp

doc: fix invalid arg name hints for bugprone validation

2026-01-24 00:44:22 +01:00

kernel_notifications.cpp

…

kernel_notifications.h

…

mempool_args.cpp

…

mempool_args.h

…

mempool_persist_args.cpp

…

mempool_persist_args.h

…

mempool_persist.cpp

…

mempool_persist.h

…

miner.cpp

[miner] omit dummy extraNonce via IPC

2026-01-27 14:45:35 +01:00

miner.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

mini_miner.cpp

…

mini_miner.h

…

minisketchwrapper.cpp

…

minisketchwrapper.h

…

peerman_args.cpp

…

peerman_args.h

…

protocol_version.h

…

psbt.cpp

…

psbt.h

…

README.md

…

timeoffsets.cpp

…

timeoffsets.h

…

transaction.cpp

Merge bitcoin/bitcoin#33962 : refactor: replace manual promise with SyncWithValidationInterfaceQueue

2026-01-27 18:00:05 +01:00

transaction.h

refactor: Enforce readability-avoid-const-params-in-decls

2026-01-14 23:04:12 +01:00

txdownloadman_impl.cpp

…

txdownloadman_impl.h

…

txdownloadman.h

…

txorphanage.cpp

…

txorphanage.h

…

txreconciliation.cpp

…

txreconciliation.h

…

types.h

[miner] omit dummy extraNonce via IPC

2026-01-27 14:45:35 +01:00

utxo_snapshot.cpp

logging: use util/log.h where possible

2026-02-02 17:22:31 +00:00

utxo_snapshot.h

…

warnings.cpp

…

warnings.h

…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.