highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-20 00:41:53 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
fanquake 1f14130cb0
Merge #21575: refactor: Create blockstorage module 
fadcd3f78e1dd1acd7a774f8fad68dc471ff9e1f doc: Remove irrelevant link to GitHub (MarcoFalke)
fa121b628d51bb0e25eb3fbd716881fa55527dc7 blockstorage: [refactor] Use chainman reference where possible (MarcoFalke)
fa0c7d9ad24d3c9515d3f9c136af4071cbd79055 move-only: Move *Disk functions to blockstorage (MarcoFalke)
fa91b2b2b3447a3645e7958c7dc4e1946a69cb9c move-only: Move AbortNode to shutdown (MarcoFalke)
fa413f07a14744e7d7f7746e861aabd9cf938f61 move-only: Move ThreadImport to blockstorage (MarcoFalke)
faf843c07f99f91603e08ea858f972516f1d669a refactor: Move load block thread into ChainstateManager (MarcoFalke)

Pull request description:

  This picks up the closed pull request #21030 and is the first step toward fixing #21220.

  The basic idea is to move all disk access into a separate module with benefits:
  * Breaking down the massive files init.cpp and validation.cpp into logical units
  * Creating a standalone-module to reduce the mental complexity
  * Pave the way to fix validation related circular dependencies
  * Pave the way to mock disk access for testing, especially where it is performance critical (like fuzzing)

ACKs for top commit:
  promag:
    Code review ACK fadcd3f78e, checked (almost) moved only changes. This is a nice tidy up change and doesn't change behavior. Easily reviewed commit by commit.
  jamesob:
    ACK fadcd3f78e1dd1acd7a774f8fad68dc471ff9e1f ([`jamesob/ackr/21575.1.MarcoFalke.refactor_create_blocksto`](https://github.com/jamesob/bitcoin/tree/ackr/21575.1.MarcoFalke.refactor_create_blocksto))
  ryanofsky:
    Code review ACK fadcd3f78e1dd1acd7a774f8fad68dc471ff9e1f. New organization makes sense, moves extraneous things outside of validation.cpp. PR is also easy to review with helpfully split up moveonly commits.

Tree-SHA512: 917996592b6d8f9998289d8cb2b1b78b23d1fdb3b07216c9caec1380df33baa09dc2c1e706da669d440b497e79c9c62a01ca20dc202df5ad974a75f3ef7a143b
2021-04-13 22:00:28 +08:00
..
blockstorage.cpp
blockstorage: [refactor] Use chainman reference where possible
2021-04-05 20:26:32 +02:00
blockstorage.h
move-only: Move *Disk functions to blockstorage
2021-04-05 20:26:14 +02:00
coin.cpp
node: Avoid potential UB by asserting assumptions
2021-03-30 13:52:22 -04:00
coin.h
…
coinstats.cpp
refactor: Prefer clean assert over UB in coinstats
2021-04-04 07:37:43 +02:00
coinstats.h
node/coinstats: Replace #include with fwd-declaration
2021-03-24 15:40:56 -04:00
context.cpp
[net] Construct addrman outside connman
2021-03-20 10:24:36 +00:00
context.h
[net] Construct addrman outside connman
2021-03-20 10:24:36 +00:00
interfaces.cpp
Merge #21575: refactor: Create blockstorage module
2021-04-13 22:00:28 +08:00
psbt.cpp
…
psbt.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
README.md
doc: Remove irrelevant link to GitHub
2021-04-06 09:34:21 +02:00
transaction.cpp
node: Avoid potential UB by asserting assumptions
2021-03-30 13:52:22 -04:00
transaction.h
scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
2020-11-26 09:05:59 +00:00
ui_interface.cpp
gui: change combiner for signals to optional_last_value
2020-07-01 21:40:51 +08:00
ui_interface.h
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
utxo_snapshot.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.