mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-11 09:42:17 +01:00

Files

Andrew Chow d232e36abd Merge bitcoin/bitcoin#28207 : mempool: Persist with XOR

fa6b053b5c mempool: persist with XOR (MarcoFalke)

Pull request description:

  Currently the `mempool.dat` file stores data received from remote peers as-is. This may be problematic when a program other than Bitcoin Core tries to interpret them by accident. For example, an anti-virus program or other program may scan the file and move it into quarantine, or delete it, or corrupt it.

  While the local wallet is expected to re-submit any pending transactions, unrelated transactions may be missing from the mempool after a restart. This may cause fee estimates to be off, or may cause block relay to be slower.

  Fix this, similar to https://github.com/bitcoin/bitcoin/pull/6650, by rolling a random XOR pattern over the dat file when writing or reading it.

  Obviously this can only protect against programs that accidentally and unintentionally are trying to mess with the dat file. Any program that intentionally wants to mess with the dat file can still trivially do so.

ACKs for top commit:
  achow101:
    re-ACK fa6b053b5c
  glozow:
    reACK fa6b053b5c
  ismaelsadeeq:
    ACK fa6b053b5c

Tree-SHA512: ded2ce3d81bc944b828263534e3178a1e45a914fe8e024f4a14c6561a73e301820944ecc75dd704b3d4221a7a3a5c0597ccab79546250c1197609ee981fe324e

2023-11-13 11:28:15 -05:00

abort.cpp

kernel: Add fatalError method to notifications

2023-06-28 09:52:33 +02:00

abort.h

kernel: Add fatalError method to notifications

2023-06-28 09:52:33 +02:00

blockmanager_args.cpp

refactor: Move stopafterblockimport handling out of blockstorage

2023-07-11 12:00:57 +02:00

blockmanager_args.h

Add [[nodiscard]] where ignoring a Result return type is an error

2023-05-29 13:12:45 +02:00

blockstorage.cpp

assumeutxo, blockstorage: prevent core dump on invalid hash

2023-10-24 23:39:10 -03:00

blockstorage.h

refactor: Remove CBlockFileInfo::SetNull

2023-10-20 16:29:02 +02:00

caches.cpp

…

caches.h

…

chainstate.cpp

validation: remove unused mempool param in DetectSnapshotChainstate

2023-10-06 18:11:24 +02:00

chainstate.h

validation: Stricter assumeutxo error handling in LoadChainstate

2023-06-15 15:11:32 -04:00

chainstatemanager_args.cpp

kernel: Remove StartShutdown calls from validation code

2023-07-11 12:30:56 -04:00

chainstatemanager_args.h

Add [[nodiscard]] where ignoring a Result return type is an error

2023-05-29 13:12:45 +02:00

coin.cpp

…

coin.h

…

coins_view_args.cpp

…

coins_view_args.h

…

connection_types.cpp

net: expose transport types/session IDs of connections in RPC and logs

2023-10-02 18:11:11 -04:00

connection_types.h

net: expose transport types/session IDs of connections in RPC and logs

2023-10-02 18:11:11 -04:00

context.cpp

kernel: Add notification interface

2023-05-20 12:03:22 +02:00

context.h

refactor: init indexes, decouple 'Start()' from the creation step

2023-07-07 19:31:27 -03:00

database_args.cpp

…

database_args.h

…

eviction.cpp

…

eviction.h

…

interface_ui.cpp

…

interface_ui.h

…

interfaces.cpp

Merge bitcoin/bitcoin#28721 : multiprocess compatibility updates

2023-11-13 12:32:55 +00:00

kernel_notifications.cpp

kernel: Remove StartShutdown calls from validation code

2023-07-11 12:30:56 -04:00

kernel_notifications.h

kernel: Remove StartShutdown calls from validation code

2023-07-11 12:30:56 -04:00

mempool_args.cpp

mempool: persist with XOR

2023-11-09 19:44:50 +01:00

mempool_args.h

refactor: Replace std::optional<bilingual_str> with util::Result

2023-05-24 08:55:47 -04:00

mempool_persist_args.cpp

…

mempool_persist_args.h

…

miner.cpp

[refactor] rewrite BlockAssembler inBlock and failedTx as sets of txids

2023-11-10 16:44:45 +01:00

miner.h

[refactor] rewrite BlockAssembler inBlock and failedTx as sets of txids

2023-11-10 16:44:45 +01:00

mini_miner.cpp

[refactor] Miniminer var cached_descendants to descendants

2023-11-07 08:56:43 -06:00

mini_miner.h

[refactor] updating miniminer comments to be more accurate

2023-11-08 14:45:18 -06:00

minisketchwrapper.cpp

…

minisketchwrapper.h

…

peerman_args.cpp

Merge bitcoin/bitcoin#28149 : net processing: clamp PeerManager::Options user input

2023-08-09 14:26:03 +02:00

peerman_args.h

[net processing] Introduce PeerManager options

2023-07-24 18:30:59 +02:00

psbt.cpp

…

psbt.h

…

README.md

…

transaction.cpp

…

transaction.h

…

txreconciliation.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

txreconciliation.h

[net processing] Move -txreconciliation to PeerManager::Options

2023-07-24 18:35:28 +02:00

utxo_snapshot.cpp

lint: remove /* Continued */ markers from codebase

2023-08-03 17:52:24 +01:00

utxo_snapshot.h

refactor: Remove unused nchaintx from SnapshotMetadata constructor

2023-10-12 11:14:32 +02:00

validation_cache_args.cpp

…

validation_cache_args.h

…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.