mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-27 20:31:44 +02:00

History

Merge bitcoin/bitcoin#29401 : test: Remove struct.pack from almost all places

fa52e13ee81fcc7543890dbd6986fcb55168583f test: Remove struct.pack from almost all places (MarcoFalke)
fa826db477a981b48bff53021f9695a5f6682dc0 scripted-diff: test: Use int.to_bytes over struct packing (MarcoFalke)
faf2a975ad46799d075e3a70c699da0d8182aab9 test: Use int.to_bytes over struct packing (MarcoFalke)
faf3cd659a72473a1aa73c4367a145f4ec64f146 test: Normalize struct.pack format (MarcoFalke)

Pull request description:

  `struct.pack` has many issues:

  * The format string consists of characters that may be confusing and may need to be looked up in the documentation, as opposed to using easy to understand self-documenting code.

  This lead to many test bugs, which weren't hit, which is fine, but still confusing. Ref: https://github.com/bitcoin/bitcoin/pull/29400, https://github.com/bitcoin/bitcoin/pull/29399, https://github.com/bitcoin/bitcoin/pull/29363, fa3886b7c69cbbe564478f30bb2c35e9e6b1cffa, ...

  Fix all issues by using the built-in `int` helpers `to_bytes` via a scripted diff.

  Review notes:

  * For `struct.pack` and `int.to_bytes` the error behavior is the same, although the error messages are not identical.
  * Two `struct.pack` remain. One for float serialization in a C++ code comment, and one for native serialization.

ACKs for top commit:
  achow101:
    ACK fa52e13ee81fcc7543890dbd6986fcb55168583f
  rkrux:
    tACK [fa52e13](fa52e13ee8)
  theStack:
    Code-review ACK fa52e13ee81fcc7543890dbd6986fcb55168583f

Tree-SHA512: ee80d935b68ae43d1654b047e84ceb80abbd20306df35cca848b3f7874634b518560ddcbc7e714e2e7a19241e153dee64556dc4701287ae811e26e4f8c57fe3e

2024-06-06 19:18:55 -04:00

.gitignore

contrib: Use asmap for ASN lookup in makeseeds

2022-05-31 11:57:49 +02:00

generate-seeds.py

test: Remove struct.pack from almost all places

2024-05-07 15:41:17 +02:00

makeseeds.py

Merge bitcoin/bitcoin#28793 : contrib: Add asmap-tool

2024-05-09 11:57:30 -04:00

nodes_main_manual.txt

seeds: Update mainnet seeds

2024-03-04 19:53:24 -05:00

nodes_main.txt

seeds: Update mainnet seeds

2024-03-04 19:53:24 -05:00

nodes_test.txt

seeds: Update testnet seeds

2024-03-04 19:53:30 -05:00

README.md

net: decouple state independent service flags from desirable ones

2024-01-15 10:28:20 -03:00

README.md

Seeds

Utility to generate the seeds.txt list that is compiled into the client (see src/chainparamsseeds.h and other utilities in contrib/seeds).

Be sure to update PATTERN_AGENT in makeseeds.py to include the current version, and remove old versions as necessary (at a minimum when SeedsServiceFlags() changes its default return value, as those are the services which seeds are added to addrman with).

The seeds compiled into the release are created from sipa's DNS seed and AS map data. Run the following commands from the /contrib/seeds directory:

curl https://bitcoin.sipa.be/seeds.txt.gz | gzip -dc > seeds_main.txt
curl https://bitcoin.sipa.be/asmap-filled.dat > asmap-filled.dat
python3 makeseeds.py -a asmap-filled.dat -s seeds_main.txt > nodes_main.txt
cat nodes_main_manual.txt >> nodes_main.txt
python3 generate-seeds.py . > ../../src/chainparamsseeds.h