17cf9ff7efUse cluster size limit for -maxmempool bound, and allow -maxmempool=0 in general (Suhas Daftuar)315e43e5d8Sanity check `GetFeerateDiagram()` in CTxMemPool::check() (Suhas Daftuar)de2e9a24c4test: extend package rbf functional test to larger clusters (Suhas Daftuar)4ef4ddb504doc: update policy/packages.md for new package acceptance logic (Suhas Daftuar)79f73ad713Add check that GetSortedScoreWithTopology() agrees with CompareMiningScoreWithTopology() (Suhas Daftuar)a86ac11768Update comments for CTxMemPool class (Suhas Daftuar)9567eaa66dInvoke TxGraph::DoWork() at appropriate times (Suhas Daftuar)6c5c44f774test: add functional test for new cluster mempool RPCs (Suhas Daftuar)72f60c877edoc: Update mempool_replacements.md to reflect feerate diagram checks (Suhas Daftuar)21693f031aExpose cluster information via rpc (Suhas Daftuar)72e74e0d42fuzz: try to add more code coverage for mempool fuzzing (Suhas Daftuar)f107417490bench: add more mempool benchmarks (Suhas Daftuar)7976eb1ae7Avoid violating mempool policy limits in tests (Suhas Daftuar)84de685cf7Stop tracking parents/children outside of txgraph (Suhas Daftuar)88672e205bRewrite GatherClusters to use the txgraph implementation (Suhas Daftuar)1ca4f01090Fix miniminer_tests to work with cluster limits (Suhas Daftuar)1902111e0fEliminate CheckPackageLimits, which no longer does anything (Suhas Daftuar)3a646ec462Rework RBF and TRUC validation (Suhas Daftuar)19b8479868Make getting parents/children a function of the mempool, not a mempool entry (Suhas Daftuar)5560913e51Rework truc_policy to use descendants, not children (Suhas Daftuar)a4458d6c40Use txgraph to calculate descendants (Suhas Daftuar)c8b6f70d64Use txgraph to calculate ancestors (Suhas Daftuar)241a3e666bSimplify ancestor calculation functions (Suhas Daftuar)b9cec7f0a1Make removeConflicts private (Suhas Daftuar)0402e6c780Remove unused limits from CalculateMemPoolAncestors (Suhas Daftuar)08be765ac2Remove mempool logic designed to maintain ancestor/descendant state (Suhas Daftuar)fc4e3e6bc1Remove unused members from CTxMemPoolEntry (Suhas Daftuar)ff3b398d12mempool: eliminate accessors to mempool entry ancestor/descendant cached state (Suhas Daftuar)b9a2039f51Eliminate use of cached ancestor data in miniminer_tests and truc_policy (Suhas Daftuar)ba09fc9774mempool: Remove unused function CalculateDescendantMaximum (Suhas Daftuar)8e49477e86wallet: Replace max descendant count with cluster_count (Suhas Daftuar)e031085fd4Eliminate Single-Conflict RBF Carve Out (Suhas Daftuar)cf3ab8e1d0Stop enforcing descendant size/count limits (Suhas Daftuar)89ae38f489test: remove rbf carveout test from mempool_limit.py (Suhas Daftuar)c0bd04d18fCalculate descendant information for mempool RPC output on-the-fly (Suhas Daftuar)bdcefb8a8bUse mempool/txgraph to determine if a tx has descendants (Suhas Daftuar)69e1eaa6edAdd test case for cluster size limits to TRUC logic (Suhas Daftuar)9cda64b86cStop enforcing ancestor size/count limits (Suhas Daftuar)1f93227a84Remove dependency on cached ancestor data in mini-miner (Suhas Daftuar)9fbe0a4ac2rpc: Calculate ancestor data from scratch for mempool rpc calls (Suhas Daftuar)7961496ddaReimplement GetTransactionAncestry() to not rely on cached data (Suhas Daftuar)feceaa42e8Remove CTxMemPool::GetSortedDepthAndScore (Suhas Daftuar)21b5cea588Use cluster linearization for transaction relay sort order (Suhas Daftuar)6445aa7d97Remove the ancestor and descendant indices from the mempool (Suhas Daftuar)216e693729Implement new RBF logic for cluster mempool (Suhas Daftuar)ff8f115decpolicy: Remove CPFP carveout rule (Suhas Daftuar)c3f1afc934test: rewrite PopulateMempool to not violate mempool policy (cluster size) limits (Suhas Daftuar)47ab32fdb1Select transactions for blocks based on chunk feerate (Suhas Daftuar)dec138d1ddfuzz: remove comparison between mini_miner block construction and miner (Suhas Daftuar)6c2bceb200bench: rewrite ComplexMemPool to not create oversized clusters (Suhas Daftuar)1ad4590f63Limit mempool size based on chunk feerate (Suhas Daftuar)b11c89cab2Rework miner_tests to not require large cluster limit (Suhas Daftuar)95a8297d48Check cluster limits when using -walletrejectlongchains (Suhas Daftuar)95762e6759Do not allow mempool clusters to exceed configured limits (Suhas Daftuar)edb3e7cdf6[test] rework/delete feature_rbf tests requiring large clusters (glozow)435fd56711test: update feature_rbf.py replacement test (Suhas Daftuar)34e32985e8Add new (unused) limits for cluster size/count (Suhas Daftuar)838d7e3553Add transactions to txgraph, but without cluster dependencies (Suhas Daftuar)d5ed9cb3ebAdd accessor for sigops-adjusted weight (Suhas Daftuar)1bf3b51396Add sigops adjusted weight calculator (Suhas Daftuar)c18c68a950Create a txgraph inside CTxMemPool (Suhas Daftuar)29a94d5b2fMake CTxMemPoolEntry derive from TxGraph::Ref (Suhas Daftuar)92b0079fe3Allow moving CTxMemPoolEntry objects, disallow copying (Suhas Daftuar)6c73e47448mempool: Store iterators into mapTx in mapNextTx (Suhas Daftuar)51430680ecAllow moving an Epoch::Marker (Suhas Daftuar) Pull request description: [Reopening #28676 here as a new PR, because GitHub is slow to load the page making it hard to scroll through and see comments. Also, that PR was originally opened with a prototype implementation which has changed significantly with the introduction of `TxGraph`.] This is an implementation of the [cluster mempool proposal](https://delvingbitcoin.org/t/an-overview-of-the-cluster-mempool-proposal/393). This branch implements the following observable behavior changes: - Maintains a partitioning of the mempool into connected clusters (via the `txgraph` class), which are limited in vsize to 101 kvB by default, and limited in count to 64 by default. - Each cluster is sorted ("linearized") to try to optimize for selecting highest-feerate-subsets of a cluster first - Transaction selection for mining is updated to use the cluster linearizations, selecting highest feerate "chunks" first for inclusion in a block template. - Mempool eviction is updated to use the cluster linearizations, selecting lowest feerate "chunks" first for removal. - The RBF rules are updated to: (a) drop the requirement that no new inputs are introduced; (b) change the feerate requirement to instead check that the feerate diagram of the mempool will strictly improve; (c) replace the direct conflicts limit with a directly-conflicting-clusters limit. - The CPFP carveout rule is eliminated (it doesn't make sense in a cluster-limited mempool) - The ancestor and descendant limits are no longer enforced. - New cluster count/cluster vsize limits are now enforced instead. - Transaction relay now uses chunk feerate comparisons to determine the order that newly received transactions are announced to peers. Additionally, the cached ancestor and descendant data are dropped from the mempool, along with the multi_index indices that were maintained to sort the mempool by ancestor and descendant feerates. For compatibility (eg with wallet behavior or RPCs exposing this), this information is now calculated dynamically instead. ACKs for top commit: instagibbs: reACK17cf9ff7efglozow: reACK17cf9ff7efsipa: ACK17cf9ff7efTree-SHA512: bbde46d913d56f8d9c0426cb0a6c4fa80b01b0a4c2299500769921f886082fb4f51f1694e0ee1bc318c52e1976d7ebed8134a64eda0b8044f3a708c04938eee7
Functional tests
Writing Functional Tests
Example test
The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.
Coverage
Assuming the build directory is build,
running build/test/functional/test_runner.py with the --coverage argument tracks which RPCs are
called by the tests and prints a report of uncovered RPCs in the summary. This
can be used (along with the --extended argument) to find out which RPCs we
don't have test cases for.
Style guidelines
- Where possible, try to adhere to PEP-8 guidelines
- Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
- The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
- See the python lint script that checks for violations that could lead to bugs and issues in the test code.
- Use type hints in your code to improve code readability and to detect possible bugs earlier.
- Avoid wildcard imports.
- If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
- Use a module-level docstring to describe what the test is testing, and how it is testing it.
- When subclassing the BitcoinTestFramework, place overrides for the
set_test_params(),add_options()andsetup_xxxx()methods at the top of the subclass, then locally-defined helper methods, then therun_test()method. - Use
f'{x}'for string formatting in preference to'{}'.format(x)or'%s' % x. - Use
platform.system()for detecting the running operating system andos.nameto check whether it's a POSIX system (see also theskip_if_platform_not_{linux,posix}methods in theBitcoinTestFrameworkclass, which can be used to skip a whole test depending on the platform).
Naming guidelines
- Name the test
<area>_test.py, where area can be one of the following:featurefor tests for full features that aren't wallet/mining/mempool, egfeature_rbf.pyinterfacefor tests for other interfaces (REST, ZMQ, etc), eginterface_rest.pymempoolfor tests for mempool behaviour, egmempool_reorg.pyminingfor tests for mining features, egmining_prioritisetransaction.pyp2pfor tests that explicitly test the p2p interface, egp2p_disconnect_ban.pyrpcfor tests for individual RPC methods or features, egrpc_listtransactions.pytoolfor tests for tools, egtool_wallet.pywalletfor tests for wallet features, egwallet_keypool.py
- Use an underscore to separate words
- exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg
rpc_decodescript.py, notrpc_decode_script.py
- exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg
- Don't use the redundant word
testin the name, eginterface_zmq.py, notinterface_zmq_test.py
General test-writing advice
- Instead of inline comments or no test documentation at all, log the comments to the test log, e.g.
self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug. - Set
self.num_nodesto the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel). - Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
- Set the
self.setup_clean_chainvariable inset_test_params()toTrueto initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value ofFalse. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test. - When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
- Many of the core test framework classes such as
CBlockandCTransactiondon't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.
RPC and P2P definitions
Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:
/src/rpc/*for RPCs/src/wallet/rpc*for wallet RPCsProcessMessage()in/src/net_processing.cppfor parsing P2P messages
Using the P2P interface
-
P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock,CTransaction, etc, along with the network-level wrappers for them,msg_block,msg_tx, etc). -
P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.
-
P2PConnectionis the class used to connect to a bitcoind.P2PInterfacecontains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.
P2PConnections can be used as such:
p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)
They can also be referenced by indexing into a TestNode's p2ps list, which
contains the list of test framework p2p objects connected to itself
(it does not include any TestNodes):
node.p2ps[0].sync_with_ping()
More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.
Prototyping tests
The TestShell class exposes the BitcoinTestFramework
functionality to interactive Python3 environments and can be used to prototype
tests. This may be especially useful in a REPL environment with session logging
utilities, such as
IPython.
The logs of such interactive sessions can later be adapted into permanent test
cases.
Test framework modules
The following are useful modules for test developers. They are located in test/functional/test_framework/.
authproxy.py
Taken from the python-bitcoinrpc repository.
test_framework.py
Base class for functional tests.
util.py
Generally useful functions.
p2p.py
Test objects for interacting with a bitcoind node over the p2p interface.
script.py
Utilities for manipulating transaction scripts (originally from python-bitcoinlib)
key.py
Test-only secp256k1 elliptic curve implementation
blocktools.py
Helper functions for creating blocks and transactions.
Benchmarking with perf
An easy way to profile node performance during functional tests is provided
for Linux platforms using perf.
Perf will sample the running node and will generate profile data in the node's
datadir. The profile data can then be presented using perf report or a graphical
tool like hotspot.
There are two ways of invoking perf: one is to use the --perf flag when
running tests, which will profile each node during the entire test run: perf
begins to profile when the node starts and ends when it shuts down. The other
way is the use the profile_with_perf context manager, e.g.
with node.profile_with_perf("send-big-msgs"):
# Perform activity on the node you're interested in profiling, e.g.:
for _ in range(10000):
node.p2ps[0].send_without_ping(some_large_message)
To see useful textual output, run
perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less
See also:
- Installing perf
- Perf examples
- Hotspot: a GUI for perf output analysis