mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-11 21:20:39 +02:00
Also, add a missing quote around -DCMAKE_INSTALL_PREFIX to avoid word splitting. Otherwise, cmake would warn: ``` + cmake -S /home/runner/work/_temp -B /home/runner/work/_temp/build -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DCMAKE_INSTALL_PREFIX=/home/runner/work/_temp/ci/scratch_ ₿🧪_/out -Werror=dev --preset=dev-mode -DSANITIZERS=address,float-divide-by-zero,integer,undefined -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_FLAGS=-ftrivial-auto-var-init=pattern -DCMAKE_CXX_FLAGS=-ftrivial-auto-var-init=pattern -DCMAKE_EXE_LINKER_FLAGS=-fuse-ld=mold -DAPPEND_CXXFLAGS=-std=c++23 '-DAPPEND_CPPFLAGS=-DARENA_DEBUG -DDEBUG_LOCKORDER' CMake Warning: Ignoring extra path from command line: "₿🧪_/out" ``` Also, allow spaces in the debug log file regex in a test. Otherwise, the test would fail: ``` TestFramework (ERROR): Unexpected exception: Traceback (most recent call last): File "./test/functional/test_framework/test_framework.py", line 142, in main self.run_test() ~~~~~~~~~~~~~^^ File "./test/functional/feature_logging.py", line 40, in run_test self.nodes[0].assert_start_raises_init_error([f"-debuglogfile={invalidname}"], exp_stderr, match=ErrorMatch.FULL_REGEX) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "./test/functional/test_framework/test_node.py", line 743, in assert_start_raises_init_error self._raise_assertion_error( ~~~~~~~~~~~~~~~~~~~~~~~~~~~^ 'Expected message "{}" does not fully match stderr:\n"{}"'.format(expected_msg, stderr)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "./test/functional/test_framework/test_node.py", line 229, in _raise_assertion_error raise AssertionError(self._node_msg(msg)) AssertionError: [node 0] Expected message "Error: Could not open debug log file \S+$" does not fully match stderr: "Error: Could not open debug log file /Users/runner/work/bitcoin-core-with-ci/bitcoin-core-with-ci/repo_archive/ci/scratch_ ₿🧪_/test_runner/test_runner_₿_🏃_20260218_095938/feature_logging_31/node0/regtest/foo/foo.log" ``` Also, add missing quotes in a test. Otherwise, the test would fail: ``` 455/455 - feature_notifications.py failed, Duration: 402 s stdout: TestFramework (INFO): Initializing test directory /home/runner/work/_temp/ci/scratch_ ₿🧪_/test_runner/test_runner_₿_🏃_20260218_113529/feature_notifications_128 TestFramework (INFO): test -blocknotify TestFramework.utils (ERROR): wait_until() failed. Predicate: '''' self.wait_until(lambda: len(os.listdir(self.blocknotify_dir)) == block_count, timeout=10) '''
5.3 KiB
Executable File
5.3 KiB
Executable File