highperfocused/grimoire
1
0
Fork 0
mirror of https://github.com/purrgrammer/grimoire.git synced 2026-06-06 10:41:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Move pop-out action to window menu dropdown

Browse Source 
Move the pop-out button from a standalone icon to the three-dot
menu dropdown to reduce toolbar clutter. The menu now always
appears since pop-out is always available.
This commit is contained in:
Claude
2026-01-14 14:16:42 +00:00
parent a6164d9afd
commit c99000d1f2
1 changed files with 57 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

117
src/components/WindowToolbar.tsx
View File

@@ -155,18 +155,6 @@ export function WindowToolbar({
<Pencil className="size-4" />
</Button>
{/* Pop Out button */}
<Button
variant="link"
size="icon"
className="text-muted-foreground"
onClick={handlePopOut}
title="Pop out window"
aria-label="Pop out window"
>
<ExternalLink className="size-4" />
</Button>
{/* Copy button for NIPs */}
{isNipWindow && (
<Button
@@ -182,55 +170,64 @@ export function WindowToolbar({
</Button>
)}
{/* More actions menu - shows when multiple workspaces exist */}
{hasMultipleWorkspaces && (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
variant="link"
size="icon"
className="text-muted-foreground"
title="More actions"
aria-label="More actions"
>
<MoreVertical className="size-4" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
{/* Move to tab submenu */}
<DropdownMenuSub>
<DropdownMenuSubTrigger
disabled={otherWorkspaces.length === 0}
>
<ArrowRightFromLine className="size-4 mr-2" />
Move to tab
</DropdownMenuSubTrigger>
<DropdownMenuSubContent>
{otherWorkspaces.map((ws) => (
<DropdownMenuItem
key={ws.id}
onClick={() => handleMoveToWorkspace(ws.id)}
>
{ws.number}
{ws.label ? ` ${ws.label}` : ""}
</DropdownMenuItem>
))}
</DropdownMenuSubContent>
</DropdownMenuSub>
{/* More actions menu */}
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
variant="link"
size="icon"
className="text-muted-foreground"
title="More actions"
aria-label="More actions"
>
<MoreVertical className="size-4" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
{/* Pop out window */}
<DropdownMenuItem onClick={handlePopOut}>
<ExternalLink className="size-4 mr-2" />
Pop out window
</DropdownMenuItem>
{/* REQ-specific actions */}
{isReqWindow && (
<>
<DropdownMenuSeparator />
<DropdownMenuItem onClick={handleTurnIntoSpell}>
<WandSparkles className="size-4 mr-2" />
Save as spell
</DropdownMenuItem>
</>
)}
</DropdownMenuContent>
</DropdownMenu>
)}
{/* Move to tab submenu - only show if multiple workspaces */}
{hasMultipleWorkspaces && (
<>
<DropdownMenuSeparator />
<DropdownMenuSub>
<DropdownMenuSubTrigger
disabled={otherWorkspaces.length === 0}
>
<ArrowRightFromLine className="size-4 mr-2" />
Move to tab
</DropdownMenuSubTrigger>
<DropdownMenuSubContent>
{otherWorkspaces.map((ws) => (
<DropdownMenuItem
key={ws.id}
onClick={() => handleMoveToWorkspace(ws.id)}
>
{ws.number}
{ws.label ? ` ${ws.label}` : ""}
</DropdownMenuItem>
))}
</DropdownMenuSubContent>
</DropdownMenuSub>
</>
)}
{/* REQ-specific actions */}
{isReqWindow && (
<>
<DropdownMenuSeparator />
<DropdownMenuItem onClick={handleTurnIntoSpell}>
<WandSparkles className="size-4 mr-2" />
Save as spell
</DropdownMenuItem>
</>
)}
</DropdownMenuContent>
</DropdownMenu>
{/* Spell Dialog */}
{isReqWindow && (