mirror of
https://github.com/purrgrammer/grimoire.git
synced 2026-04-10 15:36:53 +02:00
9c30a179e9
Addressed all 10 PR review comments:
1. Accessibility: Add role="slider", tabIndex, keyboard navigation
(Arrow keys, Home, End) and ARIA attributes to waveform/progress
2. Waveform parsing: Filter NaN values using getVoiceNoteMetadata
from imeta utility with proper validation
3. Seek function: Use `duration > 0` instead of truthy check
4. JSDoc: Fix terminology to "Voice Message Reply"
5. ParentEventCard: Match NoteRenderer API with icon and tooltipText
props for consistency
6. Math.max: Use reduce-based safeMax() to avoid stack overflow
on large waveform arrays
7. CORS: Add crossOrigin="anonymous" to audio element
8. Audio cleanup: Pause audio in useEffect cleanup to prevent
continued playback after unmount
9. Error reset: Add useEffect to reset error state when URL changes
10. Code reuse: Use getVoiceNoteMetadata from @/lib/imeta instead
of custom parsing, extending ImetaEntry with waveform/duration