highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#32737: rpc, doc: clarify the response of listtransactions RPC

Browse Source 
1ed8e76165 rpc, doc: clarify the response of listtransactions RPC (rkrux)

Pull request description:

  I noticed this behaviour while perf testing PR #27286 and it was not something that I expected, updating the doc to make it present in the RPCHelp command.

ACKs for top commit:
  achow101:
    ACK 1ed8e76165
  furszy:
    ACK 1ed8e76165
  musaHaruna:
    ACK [1ed8e76](1ed8e76165) since my last review. New changes looks good, it's much easier to understand as well, looking at it  from a user's perspective.

Tree-SHA512: 893a8e259201ac2140f46f827d81e681d2ec478c9571cceb10864aaa1b941991ce2263357d7c2b0024c04a9f8fbc372a020104b26e022c96289d271675947033
This commit is contained in:
Ava Chow
2025-12-22 15:12:07 -08:00
parent d018876696 1ed8e76165
commit 25636500c2
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/wallet/rpc/transactions.cpp
View File

@@ -418,7 +418,11 @@ RPCHelpMan listtransactions()
return RPCHelpMan{
"listtransactions",
"If a label name is provided, this will return only incoming transactions paying to addresses with the specified label.\n"
"\nReturns up to 'count' most recent transactions skipping the first 'from' transactions.\n",
"Returns up to 'count' most recent transactions ordered from oldest to newest while skipping the first number of \n"
"transactions specified in the 'skip' argument. A transaction can have multiple entries in this RPC response. \n"
"For instance, a wallet transaction that pays three addresses — one wallet-owned and two external — will produce \n"
"four entries. The payment to the wallet-owned address appears both as a send entry and as a receive entry. \n"
"As a result, the RPC response will contain one entry in the receive category and three entries in the send category.\n",
{
{"label", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "If set, should be a valid label name to return only incoming transactions\n"
"with the specified label, or \"*\" to disable filtering and return all transactions."},