highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-12 05:32:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

fuzz: prepare deterministic mempool rebuilds

Browse Source 
Reset the global PRNG before the dirty-state reset in process_message
and process_messages.

This prepares the reset path for the following change, which rebuilds
the reused mempool together with the chainman. The mempool construction
path consumes PRNG-backed state, so the rebuild should start from a
fixed seed rather than from the RNG state left by the fuzz input.
This commit is contained in:
Hao Xu
2026-06-17 20:10:20 +08:00
parent b11456386b
commit d522fd3196
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/fuzz/process_message.cpp
View File

@@ -23,6 +23,7 @@
#include <test/util/setup_common.h>
#include <test/util/time.h>
#include <test/util/validation.h>
#include <uint256.h>
#include <util/check.h>
#include <util/time.h>
#include <validation.h>
@@ -57,6 +58,8 @@ void ResetChainman(TestingSetup& setup)
}
} // namespace
extern void MakeRandDeterministicDANGEROUS(const uint256& seed) noexcept;
void initialize_process_message()
{
if (const auto val{std::getenv("LIMIT_TO_MESSAGE_TYPE")}) {
@@ -143,7 +146,9 @@ FUZZ_TARGET(process_message, .init = initialize_process_message)
node.validation_signals->UnregisterValidationInterface(node.peerman.get());
node.connman->StopNodes();
if (block_index_size != WITH_LOCK(chainman.GetMutex(), return chainman.BlockIndex().size())) {
// Reuse the global chainman, but reset it when it is dirty
// Reuse the global chainman, but reset it when it is dirty. Reset the
// rng first, so ResetChainman() consumes it from a fixed seed.
MakeRandDeterministicDANGEROUS(uint256::ZERO);
ResetChainman(*g_setup);
}
}

7
src/test/fuzz/process_messages.cpp
View File

@@ -23,6 +23,7 @@
#include <test/util/setup_common.h>
#include <test/util/time.h>
#include <test/util/validation.h>
#include <uint256.h>
#include <util/time.h>
#include <validation.h>
#include <validationinterface.h>
@@ -51,6 +52,8 @@ void ResetChainman(TestingSetup& setup)
}
} // namespace
extern void MakeRandDeterministicDANGEROUS(const uint256& seed) noexcept;
void initialize_process_messages()
{
static const auto testing_setup{
@@ -142,7 +145,9 @@ FUZZ_TARGET(process_messages, .init = initialize_process_messages)
node.validation_signals->UnregisterValidationInterface(node.peerman.get());
node.connman->StopNodes();
if (block_index_size != WITH_LOCK(chainman.GetMutex(), return chainman.BlockIndex().size())) {
// Reuse the global chainman, but reset it when it is dirty
// Reuse the global chainman, but reset it when it is dirty. Reset the
// rng first, so ResetChainman() consumes it from a fixed seed.
MakeRandDeterministicDANGEROUS(uint256::ZERO);
ResetChainman(*g_setup);
}
}