lint: Clarify rmtree/remove_all error message with preferred alternatives

This commit is contained in:
MarcoFalke
2026-04-01 10:24:32 +02:00
parent 8e789322c5
commit fa955af618
3 changed files with 6 additions and 4 deletions

View File

@@ -139,7 +139,8 @@ pub fn lint_remove_all() -> LintResult {
.success();
if found {
Err(r#"
Use of fs::remove_all or std::filesystem::remove_all is dangerous and should be avoided.
Use of fs::remove_all or std::filesystem::remove_all is dangerous and should be avoided. If removal
is required, prefer fs::remove.
"#
.trim()
.to_string())

View File

@@ -89,7 +89,8 @@ pub fn lint_rmtree() -> LintResult {
.success();
if found {
Err(r#"
Use of shutil.rmtree() is dangerous and should be avoided.
Use of shutil.rmtree() is dangerous and should be avoided. If it
is really required for the test, use self.cleanup_folder(_).
"#
.trim()
.to_string())
@@ -97,4 +98,3 @@ Use of shutil.rmtree() is dangerous and should be avoided.
Ok(())
}
}

View File

@@ -14,7 +14,8 @@ use std::fs;
use std::process::{Command, ExitCode};
use lint_cpp::{
lint_boost_assert, lint_includes_build_config, lint_remove_all, lint_rpc_assert, lint_std_filesystem,
lint_boost_assert, lint_includes_build_config, lint_remove_all, lint_rpc_assert,
lint_std_filesystem,
};
use lint_docs::{lint_doc_args, lint_doc_release_note_snippets, lint_markdown};
use lint_py::{lint_py_lint, lint_rmtree};