Luke Dashjr
a58d80d1b2
GUI: Options: Remove the upper-bound limit from pruning size setting
...
Hypothetically, someone may wish to begin pruning at a future blockchain size, and there's no reason to limit it lower
Github-Pull: #15801
Rebased-From: 8a33f4d63f
Tree-SHA512: 814dc5f004c3418216a12f8e0ef1a8db2c586d98b515d48b31a8ccd7f4e0deb12b9f2b6110bf702576a32802ca1d30e518df5ad7c28046deb4d0e9be46a6e7b8
2019-04-18 17:47:10 +02:00
Luke Dashjr
55462077fd
GUI: Options: Set the range of pruning size before loading its value
...
Without this, an out-of-default-range value gets limited to the range
Github-Pull: #15801
Rebased-From: 4ddeb2f860
Tree-SHA512: 64c18c8be6756fc0130d3fe934edb1ea7758877d4049c5729fa2adb05abb3af4e4bbe1d5f910224e16070aada5470637a35ed14b12391efd48cf035e8a22a949
2019-04-18 17:47:08 +02:00
Wladimir J. van der Laan
e753cbd645
Merge #15818 : [0.18] doc backports
...
a644780a2f doc: Clarify RPC versioning (MarcoFalke)
194226f679 doc: describe onlynet option in doc/tor.md (Jon Atack)
6d2448ca8e doc/dependencies: Fix typo libsrvg->librsvg (Luke Dashjr)
9c572e3b21 doc: mention creating application support bitcoin folder on OSX (Jack Mallers)
c69138a0d6 gitignore: add *.plist (clang-check) (James O'Beirne)
8f7cfb0096 gitignore: add *.dat (James O'Beirne)
Pull request description:
Backports #15684 , #15792 , #15802 , #15809 to the `0.18` branch.
ACKs for commit a64478:
Tree-SHA512: 6ed524a7b94242f8a738710d4321b98b9e80d6625d384fd83280b38fcb6bb8c468bcec1d980789ad2f4c91a5629ffe5c5314a7353181f08884c5a081840431cc
2019-04-18 17:45:43 +02:00
MarcoFalke
e57462c6ba
Merge #15803 : [0.18] Backport 15749: importmulti only imports origin info for PKH outputs
...
235550d019 Take non-importing keys into account for spendability warning in descriptor import (Pieter Wuille)
802dcd37d1 Import all origin info in importmulti; even for non-importing pubkeys (Pieter Wuille)
7fcbe7dc11 Keep full pubkeys in FlatSigningProvider::origins (Pieter Wuille)
Pull request description:
Clean backport of #15749 by sipa to 0.18
ACKs for commit 235550:
fanquake:
utACK 235550d
MarcoFalke:
ACK 235550d019 (Checked that they are clean cherry-picks)
Tree-SHA512: 1ccc19f51137ac4ef971c0bcca4c87ab2383610aa51c5d02680c485b9ce6abd698dddd7f4a45946d56b1aa741cc3fd94b4180ff15901824d20eeba89b4f12853
2019-04-16 07:55:31 -04:00
Pieter Wuille
235550d019
Take non-importing keys into account for spendability warning in descriptor import
...
Github-Pull: #15749
Rebased-From: b5d3987724
2019-04-16 19:35:25 +12:00
Pieter Wuille
802dcd37d1
Import all origin info in importmulti; even for non-importing pubkeys
...
Github-Pull: #15749
Rebased-From: 6e597001a4
2019-04-16 19:34:38 +12:00
Pieter Wuille
7fcbe7dc11
Keep full pubkeys in FlatSigningProvider::origins
...
Github-Pull: #15749
Rebased-From: 9a93c91c88
2019-04-16 19:34:22 +12:00
MarcoFalke
a644780a2f
doc: Clarify RPC versioning
...
Github-Pull: #15799
Rebased-From: fa747498f7
2019-04-16 08:58:38 +08:00
Jon Atack
194226f679
doc: describe onlynet option in doc/tor.md
...
as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102 .
Description adapted from https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429 .
Also fixes a typo in doc/dependencies.md.
Github-Pull: #15792
Rebased-From: 140bbeec45
2019-04-16 08:58:38 +08:00
Luke Dashjr
6d2448ca8e
doc/dependencies: Fix typo libsrvg->librsvg
...
Github-Pull: #15684
Rebased-From: 7d01b5cf2c
2019-04-16 08:58:38 +08:00
Jack Mallers
9c572e3b21
doc: mention creating application support bitcoin folder on OSX
...
Github-Pull: #15802
Rebased-From: 8dfbb5cf23
2019-04-16 08:58:38 +08:00
James O'Beirne
c69138a0d6
gitignore: add *.plist (clang-check)
...
Github-Pull: #15809
Rebased-From: 17be9e0e30
2019-04-16 08:58:38 +08:00
James O'Beirne
8f7cfb0096
gitignore: add *.dat
...
Github-Pull: #15809
Rebased-From: e7acf44bbf
2019-04-16 08:58:38 +08:00
MarcoFalke
fa3993bfe8
Merge #15800 : Backport: [rpc] Remove the addresses field from the getaddressinfo return object
...
b3a04c963d [rpc] Remove the addresses field from the getaddressinfo return object (John Newbery)
Pull request description:
Backport #15750
ACKs for commit b3a04c:
MarcoFalke:
ACK b3a04c963d (checked cherry-pick)
Tree-SHA512: d6e586fb6e22b9825267d6c45dd3090b7f8dc1a06804ca238103d1c665b178f8c2b3004f67aae67ea51c2c3df97561894f3f2e85d45400c760c3b7f057ff4bb8
2019-04-15 13:15:19 -04:00
John Newbery
b3a04c963d
[rpc] Remove the addresses field from the getaddressinfo return object
...
The "addresses" field was confusing because it refered to public keys
using their P2PKH address. It was included in the return object when
needed for backward compatibility. Remove that compatibility now that
the -deprecatedrpc=validateaddress option has been removed.
New applications should use the 'embedded'->'address' field for P2SH or
P2WSH wrapped addresses, and 'pubkeys' for inspecting multisig
participants.
Github-Pull: 15750
Rebased-From: b4338c151d
2019-04-15 12:16:21 -04:00
Wladimir J. van der Laan
f42ed1442e
Merge #15790 : [0.18] backport #15754
...
60d4621975 rpc: getrpcinfo docs (Ben Carman)
Pull request description:
Backports #15754 to the 0.18 branch
#15754 added the help message for `getrpcinfo`
ACKs for commit 60d462:
promag:
utACK 60d4621 .
fanquake:
utACK 60d4621
Tree-SHA512: 3c0f0aded2dbd300b1cb5e3a3abb1d84852a165aa6ebb337833f06ba135730192a6e86b58323e4c5eb3a7636268125bea7be05925b5b316220bfa5ac1de4a5f4
2019-04-15 14:29:17 +02:00
Ben Carman
60d4621975
rpc: getrpcinfo docs
...
Github-Pull: #15754
Rebased-From: f4b7a2f205
2019-04-11 00:42:49 -05:00
MarcoFalke
164082c822
Merge #15775 : [0.18] Doc Backports
...
bf32bc4b3d Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
1b0752a265 Mention new PSBT RPCs in psbt.md (Pieter Wuille)
956c0aac28 doc: correct bitcoinconsensus_version in shared-libraries (fanquake)
538fef6625 Update bips.md for 0.18.0 (Pieter Wuille)
Pull request description:
Can be bumped to 0.18.1 if `rc3` ends up being final.
ACKs for commit bf32bc:
MarcoFalke:
ACK bf32bc4b3d
Tree-SHA512: 60ad8f0ca53b9fbf6f2a4941bd10971cfece192032d1feff3b25e1b8572caf72cd63c5b8507c376a8bdfb57da6551ac9c2c32dc1f8dc2658a3ea4abf75b0fd9a
2019-04-09 09:51:04 -04:00
Pieter Wuille
bf32bc4b3d
Mention new descriptor RPCs in descriptors.md
...
Github-Pull: #15757
Rebased-From: 9b085f4863
2019-04-09 19:10:50 +08:00
Pieter Wuille
1b0752a265
Mention new PSBT RPCs in psbt.md
...
Github-Pull: #15757
Rebased-From: 28d78de00b
2019-04-09 19:10:23 +08:00
fanquake
956c0aac28
doc: correct bitcoinconsensus_version in shared-libraries
...
Github-Pull: #15765
Rebased-From: 8ae6d020b8
2019-04-09 19:09:15 +08:00
Pieter Wuille
538fef6625
Update bips.md for 0.18.0
...
Github-Pull: #15763
Rebased-From: 65d2f5d2de
2019-04-09 19:08:18 +08:00
Wladimir J. van der Laan
32ec900850
Merge #15691 : 0.18: rc3 backports
...
95faffed26 qa: Check unconfirmed balance after loadwallet (João Barbosa)
59716ec395 wallet: Update transactions with current mempool after load (João Barbosa)
ed0498af28 interfaces: Add Chain::requestMempoolTransactions (João Barbosa)
ebf65666c2 wallet: Move CWallet::ReacceptWalletTransactions locks to callers (João Barbosa)
a90db2f175 [tests] Add test for wallet rebroadcasts (John Newbery)
50c56f2fcf Interrupt orphan processing after every transaction (Pieter Wuille)
bb60121da1 [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx (Pieter Wuille)
6355214fd7 Simplify orphan processing in preparation for interruptibility (Pieter Wuille)
Pull request description:
Remaining backports for rc3
ACKs for commit 95faff:
promag:
ACK 95faffe , well done in ed0498af28 - verified all cherry picks.
Tree-SHA512: 597ee45493ac04e8c3149628a357c3238169d4b4f78158f22a3531e5f66289c228ecd6582f99026698883216f1ee7934d6315d19c99fc5f4f33dd1bed4300186
v0.18.0rc3
2019-04-02 14:02:06 +02:00
João Barbosa
95faffed26
qa: Check unconfirmed balance after loadwallet
...
Github-Pull: #15652
Rebased-From: 4bf1b1cefa
2019-04-01 16:40:10 -04:00
João Barbosa
59716ec395
wallet: Update transactions with current mempool after load
...
Github-Pull: #15652
Rebased-From: 2ebf650b2e
2019-04-01 16:34:37 -04:00
João Barbosa
ed0498af28
interfaces: Add Chain::requestMempoolTransactions
...
Github-Pull: #15652
Rebased-From: 57908a739c
2019-04-01 16:34:37 -04:00
João Barbosa
ebf65666c2
wallet: Move CWallet::ReacceptWalletTransactions locks to callers
...
Github-Pull: #15652
Rebased-From: 0440481c6b
2019-04-01 15:46:42 -04:00
John Newbery
a90db2f175
[tests] Add test for wallet rebroadcasts
...
The existing wallet_resendwallettransactions.py test only tests the
resendwallettransactions RPC. It does not test whether transactions are
actually rebroadcast, or whether the rebroadcast logic is called on a
timer.
This commit updates the test to not use the resendwallettransactions RPC and
test that transactions are rebroadcast on a timer.
Github-Pull: #15646
Rebased-From: 529c1ae4a0
2019-04-01 15:46:32 -04:00
Pieter Wuille
50c56f2fcf
Interrupt orphan processing after every transaction
...
This makes orphan processing work like handling getdata messages:
After every actual transaction validation attempt, interrupt
processing to deal with messages arriving from other peers.
Github-Pull: #15644
Rebased-From: 866c8058a7
2019-03-28 18:09:05 -04:00
Pieter Wuille
bb60121da1
[MOVEONLY] Move processing of orphan queue to ProcessOrphanTx
...
Github-Pull: #15644
Rebased-From: 6e051f3d32
2019-03-28 18:09:03 -04:00
Pieter Wuille
6355214fd7
Simplify orphan processing in preparation for interruptibility
...
Github-Pull: #15644
Rebased-From: 9453018fdc
2019-03-28 18:09:01 -04:00
Wladimir J. van der Laan
7bcf90cb01
doc: Update manpages for changes since rc2
...
Tree-SHA512: f42885f9b866b1172622c4ff2003b1abe5d26e2bfc060b141475761ddfb69b89c99ed5e9d15a23cf4581e77588f77eaecbbea5b7621c1ca22e7a2da6a788e746
2019-03-28 06:43:21 +01:00
Cory Fields
dcd96b84cf
release: Update the Windows Codesigning certificate
...
Github-Pull: #15682
Rebased-From: 43ae1e96ed
Tree-SHA512: 10b7ef7f58b9ded4d6a446f7a03173de6d2ce5d31a09945308b32e250c9ee7550ad2d6ae3aecb0447731a98f2ddfd62a0dcfa61106b6cc1da78d9985407ecf47
2019-03-28 06:41:09 +01:00
Wladimir J. van der Laan
f14a0aa99b
build: Bump to rc3
...
Tree-SHA512: 0d7a73946d75ac79df65dc6fb5c885353729a3401d985e2d452bf9e5964be7e169ae2cab481cba5307f5d3480d307e1c9e198090f2ede2c9c020543947d44db4
2019-03-28 06:30:04 +01:00
Wladimir J. van der Laan
09a05e86d4
qt: Translations update pre-rc3
...
Tree-SHA512: 52b66903e169fc3f53f8e4eccb0f765df9a6fbc149ba98fbe7f8b8e7f03e8196ebef8c19ed7412f6d09ddfa4b82e38aa357e1fca6942b0d1d7fe89ea66053556
2019-03-28 06:28:24 +01:00
MarcoFalke
7eab2db849
Merge #15647 : [rpc] Remove deprecated functionality message from validateaddress help
...
be8b9c62bf [rpc] Remove deprecated functionality message from validateaddress help (John Newbery)
Pull request description:
This functionality was removed in v0.18.
ACKs for commit be8b9c:
MarcoFalke:
utACK be8b9c62bf
fanquake:
utACK be8b9c6
Tree-SHA512: 7e30f1e56020aa3a59e736574075191155866788156d0d30eaf963c0a5015ad0de43787c6b73a765319f2dccec0117a2230a312d18ca3f9be3986ce3de4afdb3
2019-03-23 10:05:24 -04:00
John Newbery
be8b9c62bf
[rpc] Remove deprecated functionality message from validateaddress help
...
This functionality was removed in v0.18.
2019-03-22 15:19:58 -04:00
Wladimir J. van der Laan
b022242887
Merge #15641 : Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active
...
98a24a262e gui: Defer removeAndDeleteWallet when no modal widget is active (João Barbosa)
Pull request description:
0.18 Backport of #15614
Tree-SHA512: 8f785705325364ecfa37045090f10ca615f457e279789b0ce0d61f2667f491bce9b44f5e5cdeeecf63d61356213d9a97a3578841295cc8480cf42e037c2decb2
2019-03-22 16:47:47 +01:00
João Barbosa
98a24a262e
gui: Defer removeAndDeleteWallet when no modal widget is active
2019-03-22 11:55:11 +01:00
Pieter Wuille
238ef33692
Do not relay banned IP addresses
...
Github-Pull: #15617
Rebased-From: 054d01d0a8
Tree-SHA512: 2c47cf823cc51aee5a224513a0ca2fd1132f4c567d255ead661e88f009dc5d1db73da79b5e65a63b11b222e17292fdff9035a93cb2e53215d9bbb21a5bce7a41
2019-03-20 11:40:34 +01:00
MarcoFalke
d3a0382007
Merge #15602 : 0.18: [p2p] Enable reject messages by default
...
a7563633d2 [docs] document BIP 61 deprecation (John Newbery)
da14d90984 [p2p] Enable BIP 61 REJECT messages by default (John Newbery)
Pull request description:
This PR reverts #14054 following discussion on the bitcoin-dev mailing list.
It also adds release notes to clearly document that the `enablebip61` option will be disabled by default in a future release before being removed entirely.
Tree-SHA512: 0c9162045a4fb95689a0cb2de19f98a83636c9a6fb7ffa6809773b593c6c00b14e0480683e4d1c48e9b7f90e89cf7c2dca18bff42f5d2da2a43c522039e9f1ee
v0.18.0rc2
2019-03-14 16:45:32 -04:00
John Newbery
a7563633d2
[docs] document BIP 61 deprecation
2019-03-14 15:45:46 -04:00
John Newbery
da14d90984
[p2p] Enable BIP 61 REJECT messages by default
2019-03-14 15:32:17 -04:00
Wladimir J. van der Laan
889af0eaac
doc: Update manpages
...
Tree-SHA512: 97a6d7193da6f9d84e35e2511d949b08be990e035ffb38a149bf45df085ea41f4c84953ddd7a38b0165574f7168419fc2bd3ad6351f5012d89cf884d055693e7
2019-03-14 19:05:38 +01:00
Wladimir J. van der Laan
85f1755163
build: bump to rc2
...
Tree-SHA512: 8ce284bd20cfeee8bfb9f7144c9a4239b460f83ac18df840b417b43b11e8028b649fb056c9266d01ac39a926a8f4e931d0dc3ee302d0c84f5fcb2c7d18126322
2019-03-14 19:00:08 +01:00
João Barbosa
ef27a060ac
wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
...
Github-Pull: #15583
Rebased-From: 15c69b158d
Tree-SHA512: edef7cafc5a2cb8d3355591a7742ef61454a5dedbb1dc22f6cc6bae42329d887f3f4a054f2aeedf31180051f50b6478d09e204066205699dabc0cb67b0ce4a96
2019-03-14 18:59:26 +01:00
Wladimir J. van der Laan
a01925c150
doc: Pre-rc2 translations update
...
Tree-SHA512: a494a9039555b24a7a4f4ecebc2a1b7c47bf8937b2ec583659e4443b49919e6ddd0e276c273ce2f89955f433de300ea0c36216e288309a7fac5b2e3d2534a604
2019-03-14 15:05:04 +01:00
Pieter Wuille
232ef630ec
Fix overflow bug in analyzepsbt fee: CAmount instead of int
...
Github-Pull: #15582
Rebased-From: c9963ae8b1
Tree-SHA512: ed1dcfafb7015de5405112938b04c4009bec3349a8d4e8aca641598ccab31a34c7f16b5045670909fd2e795fc40640a79658ef6b1771e9f21abd0ca759b239b5
2019-03-13 19:36:36 +01:00
fanquake
2edd0c40c3
rpc: return a number for estimated_feerate in analyzepsbt
...
Github-Pull: #15559
Rebased-From: 335931df4a
Tree-SHA512: ebe460e935e33fbbbe725db403654ee65c86a606401e8519e1180551e2ccd43661eb4ad20bf065f2c0c2a8026c3bb3bce796789f8d612e9e197ceb8d541a63a9
2019-03-13 12:20:05 +01:00
fanquake
20fd64fe10
doc: correct analysepsbt rpc doc
...
Github-Pull: #15559
Rebased-From: a4d0fd026b
Tree-SHA512: 43f985ccb1af22e416230b8f351396d1fa677ee4e60f6952962ed37e842f5746df8a58ae7c35d6a7518af4b5974ee753b17ec3578394122584ca10e9ed561268
2019-03-13 12:20:01 +01:00