26e9db2df0
721a051320test: add coverage for -netinfo header and local services (l0rinc)f7d2db28e9netinfo: return shortened services, if peers list requested (Jon Atack)4489ab526anetinfo: return local services in the default report (Jon Atack) Pull request description: Add local services info to -netinfo dashboard that already provides this info for each of the peer connections. - `bitcoin-cli -netinfo` with no args passed provides a nice easy-to-understand services list: ``` Bitcoin Core client v28.99.0 - server 70016/Satoshi:28.99.0/ ipv4 ipv6 onion i2p cjdns total block manual in 0 0 12 8 0 20 out 6 0 4 3 2 15 3 4 total 6 0 16 11 2 35 Local services: network, bloom, witness, compact filters, network limited, p2p v2 Local addresses ``` - With a details level passed, e.g. `-netinfo 3`, print the services in the versions header instead (to avoid adding a line for more static information), in the same format as the peers list (see `-netinfo help` for info on the output of the `serv` column): ``` Bitcoin Core client v28.99.0 - server 70016/Satoshi:28.99.0/ - services nbwcl2 <-> type net serv v mping ping send recv txn blk hb addrp addrl age asmap id version in onion 1 283 498 48 48 * . 77 388 70016 in onion nwl2 2 318 485 5 111 79 372 70016/Satoshi:28.0.0/ in onion nwl 1 342 344 4 1 53 96 84 344 70016/Satoshi:26.0.0/ in onion nwl 1 411 601 4 1 35 124 85 339 70016/Satoshi:26.0.0/ in onion nwcl2 2 436 4330 2 2 2 31 13 623 70016/Satoshi:28.0.0/ in onion wl2 2 445 503 4 4 6 138 81 363 70016/Satoshi:28.0.0/ in onion nwl 1 462 726 4 1 56 92 81 365 70016/Satoshi:23.0.0/ in onion nwl 1 500 765 4 1 34 94 83 351 70016/Satoshi:25.0.0/ in onion nwl2 2 578 684 4 0 1 134 87 327 70016/Satoshi:28.0.0/ in i2p nwl2 2 712 1322 4 2 35 204 1 93 308 70016/Satoshi:27.2.0/ in onion nwl2 2 727 873 5 5 56 162 85 342 70016/Satoshi:27.1.0/ in i2p nwl2 2 749 976 4 2 25 120 72 408 70016/Satoshi:27.1.0/ in i2p nwl2 2 776 954 4 1 0 72 68 426 70016/Satoshi:28.0.0/ in i2p nbwl 1 883 1735 4 4 53 34 551 70016/Satoshi:26.0.0/ in i2p nwcl2 2 920 1044 2 0 0 131 83 350 70016/Satoshi:28.0.0/ in onion wl 1 1021 20832 29 67 3 49 501 70016/Satoshi:23.0.0/ in i2p nwcl2 2 1830 1830 5 0 3 3 668 70016/Satoshi:27.1.0/ in onion nwl 1 41155 41155 87 204 4 658 70016/Satoshi:25.0.0/ out full ipv4 nwl2 2 74 93 0 0 0 1028 85 1221 338 70016/Satoshi:27.1.0/ out full ipv4 nwl 1 82 104 0 2 0 5 . 1076 95 13536 301 70016/Satoshi:26.0.0/ out full ipv4 nwl 1 147 178 2 2 0 28 . 1104 95 395570 300 70016/Satoshi:25.0.0/ out block ipv4 nwl2 2 166 513 2 2 * . 88 38001 324 70016/Satoshi:27.2.0/ out full ipv4 wl 1 193 201 0 4 0 1035 94 31376 307 70016/Satoshi:25.99.0/ out full ipv4 nwl2 2 199 796 1 1 0 1027 94 9723 304 70016/Satoshi:27.2.0/ out manual cjdns nwl2 2 213 235 1 9 0 1109 83 353 70016/Satoshi:28.99.0/ out full onion nbwl 1 282 457 3 3 1 1130 73 404 70016/Satoshi:25.0.0/ out block onion nbwl 1 324 353 23 23 * . 85 341 70016/Satoshi:26.0.0/ out manual cjdns nwl2 2 340 445 1 1 7 1059 82 361 70016/Satoshi:27.0.0/ out manual onion wl2 2 386 386 1 1 1 1048 84 345 70016/Satoshi:28.99.0/ out manual i2p nwcl2 2 697 1084 1 1 8 1113 3 93 310 70016/Satoshi:27.0.0/ out full i2p nwcl2 2 730 1254 1 9 0 1128 89 318 70016/Satoshi:28.0.0/ out full i2p nwcl2 2 765 1804 1 1 1 1132 72 409 70016/Satoshi:28.0.0/ ms ms sec sec min min min ipv4 ipv6 onion i2p cjdns total block manual in 0 0 12 6 0 18 out 6 0 3 3 2 14 2 4 total 6 0 15 9 2 32 Local addresses ``` ACKs for top commit: l0rinc: Redid the rebase, reran the test, reACK721a0513200xB10C: ACK721a051320danielabrozzoni: reACK721a051320Tree-SHA512: 7206b0eadfe6bafea2a483eb898e7e5b104aca9c117d3bf68cd4c01bfa1108f179ff8a1061d97cdfc57f71ff5351774c83824b035892f7f382fdeaf10d3df359
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.