449a25b958
c31166ac77af8fbdc9012999b345540fe88cc394 cmake: Fail if `Libmultiprocess` is missing when `WITH_MULTIPROCESS=ON` (Hennadii Stepanov) Pull request description: Fixes https://github.com/bitcoin/bitcoin/issues/31708: ``` $ cmake -B build -DWITH_MULTIPROCESS=ON -- The CXX compiler identification is GNU 13.3.0 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found SQLite3: /usr/include (found suitable version "3.45.1", minimum required is "3.7.17") CMake Error at CMakeLists.txt:146 (find_package): By not providing "FindLibmultiprocess.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Libmultiprocess", but CMake did not find one. Could not find a package configuration file provided by "Libmultiprocess" with any of the following names: LibmultiprocessConfig.cmake libmultiprocess-config.cmake Add the installation prefix of "Libmultiprocess" to CMAKE_PREFIX_PATH or set "Libmultiprocess_DIR" to a directory containing one of the above files. If "Libmultiprocess" provides a separate development package or SDK, be sure it has been installed. -- Configuring incomplete, errors occurred! ``` ACKs for top commit: vasild: ACK c31166ac77af8fbdc9012999b345540fe88cc394 ryanofsky: Code review ACK c31166ac77af8fbdc9012999b345540fe88cc394 TheCharlatan: ACK c31166ac77af8fbdc9012999b345540fe88cc394 Tree-SHA512: 503e6d7ff253c9ae95b13ff0649af7db97c74a97c04ca6fe88130defae251b94bfe9f4466300d3fab16397c7c8346b392a80a7b80a2d6517464a4eabe3aa40db
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.