59e10a5463
c2fcf25069clusterlin: inline GetReachable into Deactivate (optimization) (Pieter Wuille)d90f98ab4aclusterlin: inline UpdateChunk into (De)Activate (optimization) (Pieter Wuille)b684f954bbclusterlin: unidirectional MakeTopological initially (optimization) (Pieter Wuille)1daa600c1cclusterlin: track suboptimal chunks (optimization) (Pieter Wuille)63b06d5523clusterlin: keep track of active children (optimization) (Pieter Wuille)ae16485aa9clusterlin: special-case self-merges (optimization) (Pieter Wuille)3221f1a074clusterlin: make MergeSequence take SetIdx (simplification) (Pieter Wuille)7194de3f7cclusterlin: precompute reachable sets (optimization) (Pieter Wuille)6f898dbb8bclusterlin: simplify PickMergeCandidate (optimization) (Pieter Wuille)dcf458ffb9clusterlin: split up OptimizeStep (refactor) (Pieter Wuille)cbd684a471clusterlin: abstract out functions from MergeStep (refactor) (Pieter Wuille)b75574a653clusterlin: improve TxData::dep_top_idx type (optimization) (Pieter Wuille)73cbd15d45clusterlin: get rid of DepData (optimization) (Pieter Wuille)7c6f63a8a9clusterlin: pool SetInfos (preparation) (Pieter Wuille)20e2f3e96dscripted-diff: rename _rep -> _idx in SFL (Pieter Wuille)268fcb6a53clusterlin: add more Assumes and sanity checks (tests) (Pieter Wuille)d69c9f56eaclusterlin: count chunk deps without loop (optimization) (Pieter Wuille)f66fa69ce0clusterlin: split tx/chunk dep counting (preparation) (Pieter Wuille)900e459778clusterlin: avoid depgraph argument in SanityCheck (cleanup) (Pieter Wuille)666b37970fclusterlin: fix type to count dependencies (Pieter Wuille) Pull request description: Follow-up to #32545, part of #30289. This contains many of the optimizations that were originally part of #32545 itself. Here is a list of commits and the geometric average of the benchmark timings. Note that these aren't worst cases, but because of the nature of the optimizations here, I do expect them to apply roughly equally to all kinds of clusters. In other words, the relative improvement shown by these numbers should be representative: | commit title | ns per optimal linearization | |:--|--:| | clusterlin: split tx/chunk dep counting (preparation) | 24,760.30 | | clusterlin: count chunk deps without loop (optimization) | 24,677.64 | | scripted-diff: rename _rep -> _idx in SFL | 24,640.08 | | clusterlin: get rid of DepData, reuse sets (optimization) | 24,389.01 | | clusterlin: improve TxData::dep_top_idx type (optimization) | 22,578.58 | | clusterlin: abstract out functions from MergeStep (refactor) | 22,577.15 | | clusterlin: split up OptimizeStep (refactor) | 22,981.11 | | clusterlin: simplify PickMergeCandidate (optimization) | 22,018.63 | | clusterlin: precompute reachable sets (optimization) | 21,194.91 | | clusterlin: make MergeSequence take SetIdx (simplification) | 21,135.60 | | clusterlin: special-case self-merges (optimization) | 20,588.13 | | clusterlin: keep track of active children (optimization) | 13,911.22 | | clusterlin: track suboptimal chunks (optimization) | 13,629.42 | | clusterlin: unidirectional MakeTopological initially (optimization) | 12,796.57 | | clusterlin: inline UpdateChunk into (De)Activate (optimization) | 12,706.35 | | clusterlin: inline GetReachable into Deactivate (optimization) | 12,525.66 | And to show that they apply to all clusters roughly similarly: <img width="1239" height="640" alt="output(1)" src="https://github.com/user-attachments/assets/edd73937-3f87-4582-b2b9-eaed7e6ff352" /> ACKs for top commit: instagibbs: reACKc2fcf25069ajtowns: reACKc2fcf25069Tree-SHA512: e8920f7952a6681b4c1d70c864bd0e9784127ae4fd7c740be3e24a473f72e83544d2293066ed9b3e685b755febd6bbbc6c7da0c9b6ef3699b05eaa8d5bc073a0
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.